From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010033.outbound.protection.outlook.com [52.101.46.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6402E375F8E for ; Tue, 7 Jul 2026 17:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.33 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444360; cv=fail; b=Ltix50d2VZJrWuko/Ke4ufm2s3He/2WmrupAhU2EgGu/cggskp7MhU0om9Xvnp9i443W+Dbj7JdhuNP6oIhgBKiexUE6j1ezM7l7BnZ155d06Rrttv3HQe9e0Ts8kNA5wdm2ymrbqWVAQBQg6s+AwR3l8qyeFg54/te8UpQXRO4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444360; c=relaxed/simple; bh=QYPv2SRrFDlOjkVNzVY8LwspziAihyU4qE6aK5Zenzw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X9bwDyRVAWTnQRepTnn/lKssaWIlnlV+pKUNpUVDM02Q8rsk44vrm3AJnIVy+9jbF412wcJmxc2XkB3o6CKbaE/0iQwgx/AmVSyYdYFB+bpSP6lN+z3jtrnJJnpCyPiStrT3642XcNuMaZOGrVRlKnDnAjPjRjdNd1RG/jy2B/Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com; spf=pass smtp.mailfrom=gehealthcare.com; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b=ynSjF5qM; arc=fail smtp.client-ip=52.101.46.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b="ynSjF5qM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xl/OVJcXdaxcnjBnmw563iOyenndwPrCWoiQQLQ48uiMxYlEY2eJ4UsKrHt6QEx9oYpUhi9bhEXDGlTHeKajD8oKJjCapT7hCe9AAESFAfxTY5qxb7uABlfy6teo64XjUxRwPOpbI1u1iQilVqL3RnZGdD5nbydonLu31/zuOShogJsC5unirP3AxwzP9pK7qG8e78H1NlOJ7zmBDJC5ugg0XXTKmeztV49k5YHXr8dhCLQ/WFn+yAxsWW9XPJmewFyNQFxZpy3UGDgT79WRfKoimlD1wf3MQIVm9y8K87bve6134E35pNk3u0Lip+GHa7IwM9RpFDY5BjN0reF82g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lo7PmIFxBNtvtBxythlsA10aKndfTss3YtrS2J1ZD1Y=; b=cQzrXTw868j7+gIJtrRUbXqPZ2HSJ6UXnph0X919YGew786jKNkROxDDsmkQ8ytfoeGbEPvaEWyEy0ZdUxCegWuIKgIgMvS6EKoxqIGctqak929GzdxDZK5yy/5x9GcmQv3UmoIYhQ5eMj646gh/pXwERoV54e981zOdkBCxAPXTXcd9/2GEIhSXPP7n3dfEArNpp/QiJNPilbCy4nhCJGxIqa08y++nV2ds6+3LchnNV+MGNYWMtCHfxT+KjXu1mnY/bnfcwjcfPyxeLu5NG8ZA6RLRaIsfPkAt68xz2Vkdo3C8HJuKhrtSaSC9IavJmrp/nceNVbj3rRcxKnAykA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 165.85.157.49) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=gehealthcare.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=gehealthcare.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gehealthcare.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lo7PmIFxBNtvtBxythlsA10aKndfTss3YtrS2J1ZD1Y=; b=ynSjF5qMsklBt4tqil0b2Xegn4fKP7w2zbb4F2d29uf7Cv2brxxof1Or1xRt17DdoglZ6XJtBswmOKiv6gRYH/EWdj9efpdPrSg0TLWsfBwYTORTB5N2H7v87ZI32EaGyQaBgGIU7DCbot67Ge/1NuFR47SbU0ZPXnyye5+b2RqvQ8yGqLkyN3/ildT7RLoT/qbF5w5fh+/CfNpF57DRcqYoalu263CkKuV/gRe13Z7LSVE2vsw4R5TZgcfhG96mF0mBragIzj1jxVzSdnVL5cS3ZBpK3zl5sjRShlF3ANzA3cz0kRyoHxC9S+szQhOngLls0PE+xc+J3ARsqtaRpQ== Received: from BN9PR03CA0070.namprd03.prod.outlook.com (2603:10b6:408:fc::15) by CH3PR22MB4311.namprd22.prod.outlook.com (2603:10b6:610:169::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Tue, 7 Jul 2026 17:12:35 +0000 Received: from BN1PEPF00006001.namprd05.prod.outlook.com (2603:10b6:408:fc:cafe::13) by BN9PR03CA0070.outlook.office365.com (2603:10b6:408:fc::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.8 via Frontend Transport; Tue, 7 Jul 2026 17:12:31 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 165.85.157.49) smtp.mailfrom=gehealthcare.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=gehealthcare.com; Received-SPF: Fail (protection.outlook.com: domain of gehealthcare.com does not designate 165.85.157.49 as permitted sender) receiver=protection.outlook.com; client-ip=165.85.157.49; helo=atlrelay1.compute.ge-healthcare.net; Received: from atlrelay1.compute.ge-healthcare.net (165.85.157.49) by BN1PEPF00006001.mail.protection.outlook.com (10.167.243.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 17:12:31 +0000 Received: from zeus (zoo13.fihel.lab.ge-healthcare.net [10.168.174.111]) by builder1.fihel.lab.ge-healthcare.net (Postfix) with ESMTP id 6E50E1290D; Tue, 7 Jul 2026 20:12:29 +0300 (EEST) Date: Tue, 7 Jul 2026 20:12:29 +0300 From: Ian Ray To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: David Heidelberg , Carl Lee , Jakub Kicinski , Krzysztof Kozlowski , Tomasz Unger , oe-linux-nfc@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 03/12] nfc: Initialize acpi_device_id arrays using member names Message-ID: References: <5f60cd3e9831aac3995ed1a1b074ca1ae32e5286.1783091699.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f60cd3e9831aac3995ed1a1b074ca1ae32e5286.1783091699.git.u.kleine-koenig@baylibre.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00006001:EE_|CH3PR22MB4311:EE_ X-MS-Office365-Filtering-Correlation-Id: c1cbe1f7-a271-4eca-9a0a-08dedc4aee6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|82310400026|36860700016|376014|5023799004|4143699003|11063799006|18002099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: oJuSjwLtHzpQUXEGg6+LeAR55trkjFCSaKqFlrA+aD1H6dUPyG+Yn0pmOKRli3DL8ujV32+QQPaMTIaByXT83xGtg9npuZ85ydjmnNwXGVLj9nWdgDDMKTVFgpv9SuTk/omZ3PB1ltSyKKqSaRa7jkccFWw0ut0k1pyOT1DJShki3jZH6WgvkBBZ8Qt278Zjx82lxZwrhm3+KmSpOme4i2LIJBBeIeOQuXy/O8s3HE46MdsSolEQxf6BlkSGxY4kONhfy80fVvilapznP9WYU2sLIQWnfhqxqLSiOzJPxUNduNJTTtxMBN+hY2cXYdMd6kwfy0CrG5l+FyYsMGBMMRyDQXS5QGgv+kysW/+U58/VYBeGN0wDozO9JQb2Gs3smLMrldrVXzRLJfLzAYRhDp/OVjq0ssLcHqAxUHiPwPXMM5RkyzXP31acLx86O6l3//zMd7JkhW5AuvWcORxdMFRkOAhEUm7WhH5HTaqSEv5PcqWe8xJr4+ZsBv0oAbnGBGW8VA6Khetdv83hLIHs0CnW0AIVJQueDy/xhjIzRfAbUJemsdoC8pYmi8k38/8eTeS1kZYK08tx2ktTcjwck1DBGMTUfnUlxOpTM8aRcfEeCQ/xQKS+TkBbysxEq5O2V0mvzzpXPtkSEdlhUlDhs5FluoWmXIV0znyEDrDoZRqo4SxMn2Ef/EDR6oiZhl+n3H1LrPt1TQIkW36UgjxG4w== X-Forefront-Antispam-Report: CIP:165.85.157.49;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:atlrelay1.compute.ge-healthcare.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(82310400026)(36860700016)(376014)(5023799004)(4143699003)(11063799006)(18002099003)(56012099006)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Nxbn3R7rwEH7susMyGg9pROBqQlV+dKAAQWMSAePWiz55qj4GCcdEGgbZ2r3YxcIBuBEP9Q7bMdaEu1uPdXp3hIO1bg5X6/ccG10Oe88j2gQjVNoid4NCHaj6aaRUvDrM5MrAHcvAxub3hGXHPf0h8iLSqKooW5U+RSP8efDywKOCYS4UfRFoACWVKxAaGtvu5Go54jm63TVxPEzvztn1miYlyqPmLFB4I3Mc3F35paKKORgplD30snAR5WH6TFPTDqG6qstVdhI4BR4I9eGExjsLNyqOmwsm3PUBk8fXE8ieAicRk6MOVnGe25rAGdTnkak+lBEDOs7YPBY/J/4bv36NDCSzt02rDG8wGSZT+A8O9mFDhGgJ2dKJxA3Muu9TBZ4ngA23N+9j098v7uNqa/umkvQaWk+hEcl7HzBS/mno1FG+XS65o5YMBeZQprm X-OriginatorOrg: gehealthcare.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 17:12:31.7346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1cbe1f7-a271-4eca-9a0a-08dedc4aee6d X-MS-Exchange-CrossTenant-Id: 9a309606-d6ec-4188-a28a-298812b4bbbf X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=9a309606-d6ec-4188-a28a-298812b4bbbf;Ip=[165.85.157.49];Helo=[atlrelay1.compute.ge-healthcare.net] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN1PEPF00006001.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR22MB4311 On Fri, Jul 03, 2026 at 05:46:17PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > The mentioned robustness is relevant for a planned change to struct > acpi_device_id that replaces .driver_data by an anonymous union. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) Nice clarity improvement. Reviewed-by: Ian Ray > --- > drivers/nfc/fdp/i2c.c | 2 +- > drivers/nfc/nxp-nci/i2c.c | 6 +++--- > drivers/nfc/pn544/i2c.c | 2 +- > drivers/nfc/st-nci/i2c.c | 4 ++-- > drivers/nfc/st-nci/spi.c | 2 +- > drivers/nfc/st21nfca/i2c.c | 2 +- > 6 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c > index 9d589b388432..47f3838ac9d4 100644 > --- a/drivers/nfc/fdp/i2c.c > +++ b/drivers/nfc/fdp/i2c.c > @@ -349,7 +349,7 @@ static void fdp_nci_i2c_remove(struct i2c_client *client) > } > > static const struct acpi_device_id fdp_nci_i2c_acpi_match[] = { > - { "INT339A" }, > + { .id = "INT339A" }, > {} > }; > MODULE_DEVICE_TABLE(acpi, fdp_nci_i2c_acpi_match); > diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c > index faebc89a7ef5..39b43f8f3bf0 100644 > --- a/drivers/nfc/nxp-nci/i2c.c > +++ b/drivers/nfc/nxp-nci/i2c.c > @@ -362,9 +362,9 @@ MODULE_DEVICE_TABLE(of, of_nxp_nci_i2c_match); > > #ifdef CONFIG_ACPI > static const struct acpi_device_id acpi_id[] = { > - { "NXP1001" }, > - { "NXP1002" }, > - { "NXP7471" }, > + { .id = "NXP1001" }, > + { .id = "NXP1002" }, > + { .id = "NXP7471" }, > { } > }; > MODULE_DEVICE_TABLE(acpi, acpi_id); > diff --git a/drivers/nfc/pn544/i2c.c b/drivers/nfc/pn544/i2c.c > index 66d070b18b4d..ccca07eb828c 100644 > --- a/drivers/nfc/pn544/i2c.c > +++ b/drivers/nfc/pn544/i2c.c > @@ -51,7 +51,7 @@ static const struct i2c_device_id pn544_hci_i2c_id_table[] = { > MODULE_DEVICE_TABLE(i2c, pn544_hci_i2c_id_table); > > static const struct acpi_device_id pn544_hci_i2c_acpi_match[] = { > - { "NXP5440" }, > + { .id = "NXP5440" }, > {} > }; > MODULE_DEVICE_TABLE(acpi, pn544_hci_i2c_acpi_match); > diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c > index 4ddf0cc2a259..3906a806ec8b 100644 > --- a/drivers/nfc/st-nci/i2c.c > +++ b/drivers/nfc/st-nci/i2c.c > @@ -263,8 +263,8 @@ static const struct i2c_device_id st_nci_i2c_id_table[] = { > MODULE_DEVICE_TABLE(i2c, st_nci_i2c_id_table); > > static const struct acpi_device_id st_nci_i2c_acpi_match[] = { > - {"SMO2101"}, > - {"SMO2102"}, > + { .id = "SMO2101" }, > + { .id = "SMO2102" }, > {} > }; > MODULE_DEVICE_TABLE(acpi, st_nci_i2c_acpi_match); > diff --git a/drivers/nfc/st-nci/spi.c b/drivers/nfc/st-nci/spi.c > index c94d67f33184..8fc60a972d98 100644 > --- a/drivers/nfc/st-nci/spi.c > +++ b/drivers/nfc/st-nci/spi.c > @@ -278,7 +278,7 @@ static struct spi_device_id st_nci_spi_id_table[] = { > MODULE_DEVICE_TABLE(spi, st_nci_spi_id_table); > > static const struct acpi_device_id st_nci_spi_acpi_match[] = { > - { "SMO2101" }, > + { .id = "SMO2101" }, > {} > }; > MODULE_DEVICE_TABLE(acpi, st_nci_spi_acpi_match); > diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c > index d6cb74a89f93..e5109f701795 100644 > --- a/drivers/nfc/st21nfca/i2c.c > +++ b/drivers/nfc/st21nfca/i2c.c > @@ -578,7 +578,7 @@ static const struct i2c_device_id st21nfca_hci_i2c_id_table[] = { > MODULE_DEVICE_TABLE(i2c, st21nfca_hci_i2c_id_table); > > static const struct acpi_device_id st21nfca_hci_i2c_acpi_match[] = { > - { "SMO2100" }, > + { .id = "SMO2100" }, > {} > }; > MODULE_DEVICE_TABLE(acpi, st21nfca_hci_i2c_acpi_match); > -- > 2.55.0.11.g153666a7d9bb >