From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9EB03AE6FD for ; Tue, 7 Jul 2026 19:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783453479; cv=none; b=lUk4kTOMLnnhzZQLg6OG4tMv3vE6bRqFNTCEM3aHSEXFwqAY53y1kHdppbkqYkUahIQG1hw3Paih4KJfRDkxCxIf4OI/TS9MYFTAa+0WrJaxfROuavjvqF+K+WtnbDyJmlOr3KfcmMq2HOinicvEWpcxluIecLwmjWBmcEfu+vA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783453479; c=relaxed/simple; bh=MjkFSwyNhKgAhyFItFeRe/l/Dn2xgXUjFalUpUSo1R8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F7Q+gEPxdzeGwEtxUVBAADKNWWhqdVX8FvQk/XQv0rMFlPW0MalsQILuO0wYeWr6mqApEQ1Q2+JnEsR+PU0NajJE62pLqoPyUWAQ5qYn18POQ/BDMDwqecxzm+al9PxmC/FhUYAUkMutXcVo7Z+7h1ygnux0DA/Xg51XPjk+2lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VAXVcJlX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jVVaUybt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VAXVcJlX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jVVaUybt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783453476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVFAgGtoBt3yMgSGiPb3d96SZc0L9n2DCPFDDVyk6cc=; b=VAXVcJlX1+olp62ZMgiEmTuVcrrDm2QxLAqMkA4l4wxxROCY+HAZULDrZAOb2Od/I/KdLp 9Cgfsk81GpqKUiQ+SMvQjgeFkMM4kvdNxbt0bN1uFv16kPwAn56RclBEBz2jXhvTOAHKPQ UweRDbAyP9dHDbqoQHUpD/r4nLusy50= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-6uN27odaMAGMGwR8aMliqQ-1; Tue, 07 Jul 2026 15:44:35 -0400 X-MC-Unique: 6uN27odaMAGMGwR8aMliqQ-1 X-Mimecast-MFC-AGG-ID: 6uN27odaMAGMGwR8aMliqQ_1783453475 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-6a14a3ef8deso6073513eaf.3 for ; Tue, 07 Jul 2026 12:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783453475; x=1784058275; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=IVFAgGtoBt3yMgSGiPb3d96SZc0L9n2DCPFDDVyk6cc=; b=jVVaUybt5wRYBd9vdiyKMAcn9LV47N4E7HCCulO+EVtlHJxjymXo0ErOZHd04sOQZJ 8rC82kCFHfbGttKMYTWOYAJPCthGg/LRAcjQc5WJLCUNypEvUX6YtzK7ezGboZwWgR8X 1BuFeuLnVhdOOEFlcDbo62qErUswGrEyxJfXfN97abK7AMMPRiopshYYxSPSjWZN9haV ph3k8cTkqByPp9pVw0IRPGNeu93jY3bMFiNNDufLTWlzzfo76DgECcQ+q7TY+sCKB+Fy XmFarjSH71dSNJWBoYSgnt5iQgwcaSDO3wCI+HQR/5EU/Rt91j3DaQ1sITk9wN7qI+K8 VmdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783453475; x=1784058275; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IVFAgGtoBt3yMgSGiPb3d96SZc0L9n2DCPFDDVyk6cc=; b=AjsFl9WlxfgbNsRJKMN052auW4WGdsTdTfjMCgd0hyQuNaHxF3IxI1OnHCKH/71cY5 IuyBsjdHct23+A5Uy6riFrutQZ/oovre7VgyWa/OSzXmcsI/OHwmDHCmmdX4tmBskseW 4Mwg2tzJZDpI8Uu+q9z7NsYD0Rl0n8/xsJ9o21kQwolGTBQgiFLrHWNEWg6pEVJqnZk8 xdNDqWeaERGxj2yZhwpOIBiePtiu0VBA9yIVXTbITOHjTycAnbc9Vy/PTmLaRHlkURyl tpaez1srFx01XiYMCwX0iriKf7NoO1F9WhUDFanYfj0gFfLZyCMmCnWUVVrJ7KqUcDGX a+3A== X-Forwarded-Encrypted: i=1; AFNElJ9pUUBA7GMrza6Z160OMQU4/aAfIwjkTJdMKgoakxM2EJxFgHT3cRnkIag8z4B+L7BkvKYZfJJWAwCX1UY=@vger.kernel.org X-Gm-Message-State: AOJu0YyflhWC5oLN3UCFlKPurl9Mpv1ouoLipBi1YSAkfPtGgzemt6wv tGvl5aiqw8PqPbkex6elr43Nb+U3xPLKl/3YYowjfjg2xgUckyeJP3iHbLGa2bqpGnZqL4Bsfnq CYS4JnGkItrX+BivDvJzy9pogpQB9aI+TUGIqNT+tINKRZBxTM21ClWMhqiVt4dS/Xw== X-Gm-Gg: AfdE7ckEz4fG/H3MoiU0dOiVfY1luVHvygnCplCr2YRkUWFLk5IRWJONdr+2bRz93pT qVxRPclOs3yABd1p13JN3L5WyfrzIGmBoUhb5o+v//+l8Pzfw5wQnIonbEVp6dfytVJ+L9v655Y b8yTZuvFFWz/slAClZ+JWXHLnnyM1zZb7iJ6XmOIvfRIpFbOEacndTNTz4Ip1knm0hxjBWgtBCH 3ZD2lRREjc5C+G96kneW3agctDJ8Ygh1F9sEkrNwgRUWofdQzwjfgxYNvqeSsQUFU1nSnuy2Ya1 Sro/nzKSyXDpaPI1YJML1V/GAz+UquHlcUDHa0aqDcQwXvnNCqX8saXU01hsODspOCe9NnLb5uN UoCkxwQRI X-Received: by 2002:a05:6820:1b05:b0:6a1:42bd:d005 with SMTP id 006d021491bc7-6a35556aa59mr4024191eaf.48.1783453474840; Tue, 07 Jul 2026 12:44:34 -0700 (PDT) X-Received: by 2002:a05:6820:1b05:b0:6a1:42bd:d005 with SMTP id 006d021491bc7-6a35556aa59mr4024176eaf.48.1783453474395; Tue, 07 Jul 2026 12:44:34 -0700 (PDT) Received: from redhat.com ([2600:382:8102:284f:288:4331:f63e:598f]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a36a8cb24dsm208450eaf.14.2026.07.07.12.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 12:44:33 -0700 (PDT) Date: Tue, 7 Jul 2026 15:44:30 -0400 From: Brian Masney To: Jia Wang , Krzysztof Kozlowski , Conor Dooley Cc: Michael Turquette , Stephen Boyd , Rob Herring , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: clock: ultrarisc: Add DP1000 Clock Controller Message-ID: References: <20260617-ultrarisc-clock-v2-0-9cb16083e15e@ultrarisc.com> <20260617-ultrarisc-clock-v2-1-9cb16083e15e@ultrarisc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617-ultrarisc-clock-v2-1-9cb16083e15e@ultrarisc.com> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Krzysztof / Conor, On Wed, Jun 17, 2026 at 02:02:54PM +0800, Jia Wang wrote: > diff --git a/include/dt-bindings/clock/ultrarisc,dp1000-clk.h b/include/dt-bindings/clock/ultrarisc,dp1000-clk.h > new file mode 100644 > index 000000000000..751125f99965 > --- /dev/null > +++ b/include/dt-bindings/clock/ultrarisc,dp1000-clk.h > @@ -0,0 +1,27 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +#ifndef _DT_BINDINGS_CLOCK_ULTRARISC_DP1000_CLK_H > +#define _DT_BINDINGS_CLOCK_ULTRARISC_DP1000_CLK_H > + > +#define DP1000_CLK_SYSPLL 0 > +#define DP1000_CLK_SYSPLL_DIV2 1 > +#define DP1000_CLK_SUBSYS 2 > +#define DP1000_CLK_GMAC 3 > +#define DP1000_CLK_UART_ROOT 4 > +#define DP1000_CLK_I2C_ROOT 5 > +#define DP1000_CLK_SPI_ROOT 6 > +#define DP1000_CLK_PCIE_DBI 7 > +#define DP1000_CLK_PCIEX4_CORE 8 > +#define DP1000_CLK_PCIEX16_CORE 9 > +#define DP1000_CLK_PCIE_AUX 10 > +#define DP1000_CLK_UART0 11 > +#define DP1000_CLK_UART1 12 > +#define DP1000_CLK_UART2 13 > +#define DP1000_CLK_UART3 14 > +#define DP1000_CLK_I2C0 15 > +#define DP1000_CLK_I2C1 16 > +#define DP1000_CLK_I2C2 17 > +#define DP1000_CLK_I2C3 18 > +#define DP1000_CLK_SPI0 19 > +#define DP1000_CLK_SPI1 20 A common scenario for the driver side is that it needs to know how many clocks are present. For example, the driver in this series has the following in drivers/clk/ultrarisc/clk-dp1000.c: #define DP1000_CLK_NUM 21 Which seems a bit fragile to me having it in a separate file. I've seen where some dt-bindings will have the define right below the last clock, so DP1000_CLK_SPI1 in this particular case. There are a few clock dt-bindings that have it this way. For example, see include/dt-bindings/clock/nuvoton,npcm7xx-clock.h. Personally, I prefer it this way, however I can see where the argument could be made that this doesn't belong in the dt-bindings. Do you have guidance for what you'd like to see? Brian