From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0782B2EBB9E for ; Wed, 8 Jul 2026 03:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783479911; cv=none; b=nbZwpSlD4QyrG+kcDL2WEgwYYux9eeQjWmEbp6TIrDfeoLswRyyCnsu1DnGer0ER6kZBzNOGVTS+9TUQ3ptUl99kBZtYJh2NfttcySdeI9hzP5jQTy3/IE9i1qipe3CV7Fgdc45ReNdDc/Xnu2wCp0t4g1gQMFn3lI//u/4kT9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783479911; c=relaxed/simple; bh=lDkrN7TEV3W2iPCZlUY1PLvMiA3LImtRz8mNfzXbJ4E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r8fpTdQJlFQKzWbGR8TllEEzDy60lsL8HJXHMLUSjnT3R2PUI8h3ZCmVj25LHaS/WLWuuEpFkIA1YIWLc1HX4SG9rM7z9+xTwg0YLt85Fc9LBtGptpozjtiz89+KTKnV6Io2FAzti1BtNk0zWOiQ5bCS2nARXnd0bi/+B15esRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mbAkEL4G; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mbAkEL4G" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cc73e322dbso2047465ad.1 for ; Tue, 07 Jul 2026 20:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783479909; x=1784084709; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/2EyXuA0RqvzIxJQ42DvJAEkPUcEt3WncopO+pVd7fw=; b=mbAkEL4GFSp8e6YrS0IE+uKvRcWUsVULf40KYKwwmb6QaiarVWaBHRWcCEPlzRlVlf /ENBoLVey8pEK8T/bzXEbwyg/PJy5ftalRZUd1bBVKrE+VVFrGoxy0VOPnk6kGD8MTEc eAbjFQPMmfsNRaFopLP7KwGW0RRJn2nBFd8XX+ZydK/n8QvqwD2fwJbiGjgAlO3HmnW1 b4YGrdnsUp/yfNkq66wnoZYmARQgB4+4AEI3N8u1uf+c/IpquX9OnpDSLzVW6lePKu8i pyTOX7PmuvaDDKf5hFYNQkXHf7TwnIf5b75d4RiNVe50KIMAj3w6nBTPCjjw9k3au4Mk v1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783479909; x=1784084709; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/2EyXuA0RqvzIxJQ42DvJAEkPUcEt3WncopO+pVd7fw=; b=BqGIy66U/+oISgpUVQzHdKj7JaQ0wYW5Gv+UwruDLA/mVygCB/NsCIB+OOjq0stH/q 1OX6ucot4iXZBrMIw5jw/15jPKh18LBcoAZdpetRe8a/VcmpHwPvLN7ClKpQ2fejOP+L vsM57TtcDf0+MWHO51Oveiq4R+WfzpzrLmM3/iK2AbXAXhHlPkRF/KGT+1NirM0tIgGh 0SMA27OexAU1C4h3IqENyT5YW3FbAU7dtZSIhfB/wcwGTgYifw/kJ9UXplHmYRl1lfYj 0BkRQnD73lE0qyfsL608gyE/AbOUcUolmLw3pb7pbpxj3DUxtDKtBMgle6be3kEdHiIJ vRdg== X-Forwarded-Encrypted: i=1; AHgh+RoonOgnU/TV5hqCqhpcAB5fmkVd5OW6+LQxgblsfEdNO+EVlDIURx/YPaHegnah3BN9v7sfxlnm/rZZypk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9tG1d9sTztptk2tNE89+DIc86znwz4f0ZV3zhxSc8MEczo79K ArRVk7b1YLMynENVLqnw6KOG+o29mMIetrM/O+d4rGHHlCwmOsxxEA4s X-Gm-Gg: AfdE7ck7by/lPItb3rjjfYeI0L+5DQYL3BgaUHTRjiNtq77vZpXjbPQsSlXQNubZyJj RsIl+MyOaZbTnDXtc1f2ntwmAzw5dLcHviqWkSQqJOvtS36utGeLj8NXIP9632QKD9zXBDYIe3n GimV82iqrqsxM3LB1kcsuISAu3p7HR5xYEjmfMEQzmi65Ygo6ZEv4rINL2p3fvDQeR+wtV05mFE IinAZ2I+7PBYEpf3I1gJXfHZ+NDnYehZ9isXxY7COcfyqAGiu9PPoscdaXlX7KevEe+faU8YbOD 26fx37eaDsyIc8PuhGDmQ2WTnJ0UBDE+2mBMHqXPwwwbjVYaxJJU2aonT7tgSReQ7MFaAT0VHak tzg9c4+rFGIq/U79+XPynS+6k8o3gcX+OXU7u0Zcys34Bv/yaOriksvueD9omwgtXA03T7KH5UF 8mHTykyys= X-Received: by 2002:a17:903:1745:b0:2ca:ed41:d331 with SMTP id d9443c01a7336-2ccea5aaac6mr6489615ad.45.1783479909029; Tue, 07 Jul 2026 20:05:09 -0700 (PDT) Received: from xiaowei ([2406:da18:1aa1:6600:7a60:aa58:4b0c:e1c0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5c804sm20225105ad.82.2026.07.07.20.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 20:05:08 -0700 (PDT) Date: Wed, 8 Jul 2026 11:05:00 +0800 From: Kevin Hao To: "Taedcke, Christian" Cc: christian.taedcke@weidmueller.com, =?iso-8859-1?Q?Th=E9o?= Lebrun , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Robert Hancock , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH net 1/2] net: macb: reprogram TBQP after shuffling the TX ring on link-up Message-ID: References: <20260706-upstreaming-macb-irq-storm-v1-0-ab3115b5a13a@weidmueller.com> <20260706-upstreaming-macb-irq-storm-v1-1-ab3115b5a13a@weidmueller.com> <8d53c3d9-7918-456c-8c27-e9d73c896452@weidmueller.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kyG29oqcChhEWuEU" Content-Disposition: inline In-Reply-To: <8d53c3d9-7918-456c-8c27-e9d73c896452@weidmueller.com> --kyG29oqcChhEWuEU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I agree that the TRM says the transmit pointer is reset while TE is low. My > question is whether this describes an internal pointer being reloaded from TBQP, > or whether TBQP itself is restored to the original ring base. The Zynq UltraScale TRM [1] describes the receive-buffer queue pointer as follows: An internal counter represents the receive-buffer queue pointer and it is not visible through the CPU interface. I could not find a similar description for the transmit-buffer queue pointer, but I believe it behaves the same way. From a software perspective, it should be safe to assume that the TBQP is reset to point to the start of the transmit descriptor list upon reset. This assumption is supported by the description of the transmit_q_ptr (GEM) Register [2]: Reading this register returns the location of the descriptor currently being accessed. Since the DMA handles two frames at once, this may not necessarily be pointing to the current frame being transmitted. [1] https://docs.amd.com/v/u/en-US/ug1085-zynq-ultrascale-trm [2] https://docs.amd.com/r/en-US/ug1087-zynq-ultrascale-registers/transmit_q_ptr-GEM-Register Thanks, Kevin --kyG29oqcChhEWuEU Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAmpNvlsACgkQk1jtMN6u sXEU6Qf9ENUqNjx8NFL9ReOVIph7o6p3txHaKrhJNj5yOldBQKaAhd3ulWrxdDo+ mBtBwyWjckjL6a66Nknb+FHUYCOSThofTjjzujesS5acHoyVDfTOn4ygarN4h3gx Vo9tcn9AaxvJi91DZPS0pGMyZgw0LVgiWwBwW29/z/hjn2bnvVRh8+VuCCEUPwjE 32Zn7Oqe4fk6yghgBVebUAn1LcySVtLRm0Xxi2nJw6k4GFdeb8RJ8hTTz9jGrBz4 Tq4oYVreIMzMfcC3G4vqKpinByTiswzqoXhFDlPXup8X6zu6DecFqWdz3isOa+4D A7RfNYlyO90plRZbnLNauVS1oQZucw== =QDLt -----END PGP SIGNATURE----- --kyG29oqcChhEWuEU--