From: Nicolin Chen <nicolinc@nvidia.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: <linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
<joro@8bytes.org>, <jgg@nvidia.com>, <yi.l.liu@intel.com>,
<kevin.tian@intel.com>, <vasant.hegde@amd.com>,
<jon.grimm@amd.com>, <santosh.shukla@amd.com>, <sairaj.k@amd.com>,
<jay.chen@amd.com>, <wvw@google.com>, <wnliu@google.com>,
<dantuluris@google.com>, <chriscli@google.com>,
<kpsingh@google.com>
Subject: Re: [PATCH 1/2] iommufd: add hw_queue_init for guest-address queue setup
Date: Tue, 7 Jul 2026 19:39:31 -0700 [thread overview]
Message-ID: <ak24Y5CKa0U91dBC@Asurada-Nvidia> (raw)
In-Reply-To: <20260708015628.255088-2-suravee.suthikulpanit@amd.com>
On Wed, Jul 08, 2026 at 01:56:27AM +0000, Suravee Suthikulpanit wrote:
> Factor HW queue allocation into _iommufd_hw_queue_init()
Why do we need this factor? There is only one call site. Nothing
really benefits from this _iommufd_hw_queue_init(). Can we unwrap
it and keep everything in one function?
It could be a smaller patch, as I recall I suggested previously..
Nicolin
next prev parent reply other threads:[~2026-07-08 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 1:56 [PATCH 0/2] iommufd: Add AMD vIOMMU HW queue support Suravee Suthikulpanit
2026-07-08 1:56 ` [PATCH 1/2] iommufd: add hw_queue_init for guest-address queue setup Suravee Suthikulpanit
2026-07-08 2:39 ` Nicolin Chen [this message]
2026-07-08 1:56 ` [PATCH 2/2] iommu/amd: add vIOMMU HW queue initialization Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak24Y5CKa0U91dBC@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=chriscli@google.com \
--cc=dantuluris@google.com \
--cc=iommu@lists.linux.dev \
--cc=jay.chen@amd.com \
--cc=jgg@nvidia.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kpsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sairaj.k@amd.com \
--cc=santosh.shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=wnliu@google.com \
--cc=wvw@google.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox