From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974E8420868 for ; Wed, 8 Jul 2026 00:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783470241; cv=none; b=RYfgSdQPevTm6rTJTooKQ/0ysDQ7tKOSA0unmxiBDOaNaPWz9zJECow/ZRTQYt5fhl7w2GIQBbCac0Xw9GewHaJ7wjtBiUSC4EPduBU3glltZXC5zjaMnOHzWNS4qCu6e1fAFvKgbnp5wwkcO7z3nrxSgjl67b/z4zwTJcJBoiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783470241; c=relaxed/simple; bh=dLmRL9t64e2yQcG717DJtuL5Mz7das7A59NcAle5gP8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvlqtwcyp/kYo1358qwBUFgy5v5K7MAUJ+H/4+wklY5nMSQOGx2gUvNaXesmEXK9Jum3sbwiBLhAEFeBu5tNjLIXP6h1kHIF7VuiOaqRl4rn1pZ0XUSFe+PugVugbXGKEHc39RQl2N0B+s84sk3P1XJJGfrwtK4Wv6dcR5wC5VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RWXiEDYD; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RWXiEDYD" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cacef7d299so20825ad.1 for ; Tue, 07 Jul 2026 17:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783470240; x=1784075040; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Fwb6T7QVdGDxs2wP5yfln48hkZneD+IuZNOtsCtvSik=; b=RWXiEDYDeA6rNKK6KibWzBnzCU6fOf5hjWg9c1uefdTq32mPk9sfiNmpfIjsHVdAXv Zu1yX57vMSRR90soYmkYhL222Gg3G/AeOn8RReuTeA2ZlBNa90TZXuPbluuXJFWghLB0 2JOwMlzzZPi4jrRnitijJLC5UtmfqBc0xXqg+toGHSJ2vheib7/ZYpJL/BEb2SJAYaVn A2sW+Stu7NNAGtwHdEOIqOeub5zVjMMdD/pwQK/1UhvMmoOT//cwRBekMoNSzDKBH8AK AE+c+22sMQtvD7zsgvNUMhSK4dgX/HsyGo/WTwFqag1MhGp4gNiB/x6Ew4Kqyyu8LmyX RFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783470240; x=1784075040; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fwb6T7QVdGDxs2wP5yfln48hkZneD+IuZNOtsCtvSik=; b=P+ZN7RrcmJ9jR5oZpiAcbyU1Qjg224IZ9P8NNy8dygS2wjey6y/frSUrxeN3rgBzho 9XqXXHBlMoAaWCWlCNYp/WNO13/LrTi4vp4r11Zb4nOmdke66exoZFBgsF+FlXgouIwf Yan0D1RcGYyVVuVUL4rMfH9+CAAbqe5CfMG+zO0rYrskm4foU+mlUROXaUyRAMiuSzJI bSHtkmqgmvZXzv10NaJOQfbCySAxvtogRZTleJkJEBMfe4M2JZ6d8VUazmo4+UAfp1TZ 5J/E6jdGv/sOowqtb+y/zqTC/sP5XmhsnPh98I5JKnsyWReERdfcIVzEAKYjZRxBgxbo SRDw== X-Forwarded-Encrypted: i=1; AHgh+RrAZcyRjmj6n2Ngep4VMkuXzd04aKI69LmmGkShS4PH7fmEEFx0q81wvGiRj/isCxRBUMG4Lg/SAVJ7/xQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8QpjxXGq+AvpaLJa7x8gk5mCIzGdgzjFzDBxKIjPgIs5qUOFa P9KHrBDdbjCxKYKNOAXvVNASuMF610Mg2VS45Ma1+NnU+WBrBP/s5ua1xzjorVlRbg== X-Gm-Gg: AfdE7cmB9QFcpfnlaEPXUWBog+c2BJ4MSoQXMS+7rY7fjAgJZZX8A3Zt9KC/gl3Y+nD 1zWEf8gsxnF3oKr18ErRNOxboZsqYje0M5RPPT08R4k0NhaykTaxfdcXrINlfoebL+jZXs6CI0r UQhblo+YT2dJks3z9LtybCBlwc9oJAQlYe42ftB4ePtbHwzgAG0mG5uUfpx8SBerT71grcvD0jX Kqgy7QLfIDBbWFLknWP7D0lLl0L7Ff02BBZPUmOU0ZO1ezkgfpXxUxY9ufU3F7Q8GQiCfzhX8qa OAYbESf3/1iBep0t/kFEDN0pFDVqas12Mk8QNCU6CqSd8/LpfP1fFWnVweD09euMKs8LeRcrdal kw9LKE+G+kvVMV+dDg6TQdSclvijMeL/0Zif/0Z6PhHcXOhzFOyEBXKLWYeUWsGvC19M4g1xIYX 4QlJNNYPL4Z2cTPckHpXHu9B/mwfdZjZMZbWmSpx4a1rgH7rCm+yKYm1a/Md72p/mS1dKpottFP uXGL9m/q4A= X-Received: by 2002:a17:902:d589:b0:2bf:3579:cdaa with SMTP id d9443c01a7336-2ccc9c2d137mr5761425ad.10.1783470239360; Tue, 07 Jul 2026 17:23:59 -0700 (PDT) Received: from google.com (168.136.83.34.bc.googleusercontent.com. [34.83.136.168]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6dd9237sm6303930b3a.59.2026.07.07.17.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 17:23:58 -0700 (PDT) Date: Wed, 8 Jul 2026 00:23:55 +0000 From: Samiullah Khawaja To: Mike Rapoport Cc: Pranjal Shrivastava , Pasha Tatashin , Pratyush Yadav , Alexander Graf , David Matlack , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/4] kho: Introduce kho_split_preserved_pages() helper Message-ID: References: <20260703020832.1731864-1-praan@google.com> <20260703020832.1731864-5-praan@google.com> <178341290877.3292146.993563652569119942.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <178341290877.3292146.993563652569119942.b4-review@b4> On Tue, Jul 07, 2026 at 11:28:28AM +0300, Mike Rapoport wrote: >> A driver may need to split a high-order allocation that has already >> been preserved. If the pages are split using split_page() manually, > >Why? >Are there particular examples? > >> the refcounts would change but KHO won't record the change in the >> preserved page-type, resulting in a metadata mismatch during >> restoration in the new kernel. >> >> Introduce kho_split_preserved_pages() to handle splitting of preserved >> pages. The helper follows an unpreserve -> split -> re-preserve sequence, >> while ensuring that the KHO radix tree is updated with the correct >> KHO_PAGE_SPLIT type bits. >> >> The helper returns 0 on success, or a negative error code if the >> re-preservation fails. Callers must ensure the provided order matches >> the original allocation and that the operation is serialized against >> other preservation API calls. > >Let's put this on hold until there are actual users. +1 I think we discussed in this in one of the hypervisor liveudpate meeting sessions and it was concluded that the split of preseved pages is not needed. > >-- >Sincerely yours, >Mike. >