From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B330A3B6377 for ; Wed, 8 Jul 2026 05:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783487130; cv=none; b=n93Bb3fgPhdlOwpssCxTTX0gOa1EftTCL28RXCTC/Hme3WDOVawsoYqgdsiQzVRDsrg7SE2qepL1T0gztlotuG+01OlLw4NUAGAjPeSoZ6nZ0kq+R7cYjwSIQYyoSam4b5+nNObLxdcL8/Yvnaoydausv6DATTTxyq8AI04pPPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783487130; c=relaxed/simple; bh=A5EH4vrpCYxkHq9d3wTWMZ1A/AycKXK0ePR/KubP8MI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uPlPFDdn2+5W5Y17Yjgv887qjUyRreCiLPZUY2xwsyilwZfg/STqsvmPoKY/wR4ZWyF5mEwLacwZB1pdVqrKt7vWB9+/IGJVX+paLiYL5cZQQ5kPMme6xmHFfcSdpM7aT86jvVOIdJnCuTYOy6j8TXPtiPuZWeU8zsWuetYyltk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Nr+1f+M9; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Nr+1f+M9" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b691cb44so1229175e9.0 for ; Tue, 07 Jul 2026 22:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783487126; x=1784091926; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2bRMxPUxBcXrhb0PApy6D/IVMbVi3E/LkCHcDJDbkO0=; b=Nr+1f+M9jHTQu372R03NlEyMtbyRXt41oHGfE4XxwYQIMKaMKnWrxYk3Bmr9sTPtoy xO/69O1l7kyb4+Ao5IrGiXu9GXxIjm8W08aiuRKiqUZgQUhVrsAckppKxcswptvwq5RL p07oywDpRg3T8Wn64lkVxlq34PEcGdstgN6EMTvu3MktVFlf7tB56soXK3YsapKkGNf2 aBXGHlHw85EyeJ/7Zj9UlaaYcyoW+WikBUISxJmNBfyUO7SJtYBQPv71+g+pLmiNw4be icIGUF0925R1kKZTjvBhDZK4ZF9oyVVFoP9QbVwGCePyGkTq3whTuExRLearv1d6s1Q2 270g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783487126; x=1784091926; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2bRMxPUxBcXrhb0PApy6D/IVMbVi3E/LkCHcDJDbkO0=; b=D/Q31i8x69pVZdXUAoea5utiqUiN/EiAeUENTAtPXV8ZAPWKWcv48IesHuILUao80r TrqrYlgywZdXpq7UUo4KfQD5YmPrMugKop337++Ec+TouLZIjkmw5267t6XwJ7X5Dn7U ub6oW849ExlIM+CDOGalRPnFceeQ8L0MOZrUVjV+2E1nNTqkBiFkDzsqhUjFm7HHIAfo YEUFD9yfj1tmjFJZDx4wSQiLECO8uEtVGJ9s2ixjDAl9Da3vwziDNAG7RA6nIuuLSeFn eqtjccT8hN4vRHW105h8tnfEC7vrFvVjdQuWULC3BKEFP04QMKhM7A2sRfxo/udDUrPV Q1UQ== X-Forwarded-Encrypted: i=1; AHgh+Rp58k2Auu+NqhBT7xBm86QJlLELIy3HqpDRoEHIiKrHTzg49EtRveiDrM1RDgXgEPtxNBKsi3xSJxN6FX4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyuoia3f+Ccj0YGRLTEY1Y4xWbRnnVUo8TuGUCWc6yl6YJ/Qaxy chdVd0B7nkK8KyiyoFm9QXAsAXPJ8ZwYmwoUBinxXewdConQVnSPhoJzYiJsOULowKI= X-Gm-Gg: AfdE7ck4IshcYL+NEjiemflxjvLpD2HgBMkANcPSYaFJVhaA/xH8TyypTq2q0PKGh1J Eto1f48DFLDYume2x5rhoukbOI1wtdwAOKRHByWuLXKk7hZBhQoF+sorg077VEl6SoBQo7R8RbO /6dqGpjFJgJNggKv3MsgzCnY1lovtp7BDoTyxvhvfjHtIzwidaoHdh2Zt8Jcqv+5evpZFPcDc1F 5lLFQD/w4EgBnY63HVku6TIJEh8FjD/exr5UWY+qN2YX9UFrIlUGprqaKNP3YZOx10QWgze3FBM 14qEw9Laev7e2NJJs3Wl9aN8llTmRV7EiDuEzJpO/uru4CpKQ6IhjcA3cbLqOSjgDdYAdfu5M09 EQ1z+EJCiQIclEouSvG06kBWKq67E/c+YDSbAXn4RjtfREaesdY5up0miyBxBPI/iNr+7J928MI 2kJ0gZG7l5nMlr45W4LA== X-Received: by 2002:a05:600c:4fd4:b0:493:e3ea:b23f with SMTP id 5b1f17b1804b1-493e6861ac2mr6417425e9.10.1783487126073; Tue, 07 Jul 2026 22:05:26 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493e0f5bc78sm131093755e9.14.2026.07.07.22.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 22:05:25 -0700 (PDT) Date: Wed, 8 Jul 2026 07:05:23 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Krzysztof Kozlowski Cc: David Heidelberg , Mark Greer , Simon Horman , Tomasz Unger , oe-linux-nfc@lists.linux.dev, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v1 07/12] nfc: Drop __maybe_unused from of_device_id tables Message-ID: References: <031ea0ae38838df3261f844eb13e9841769b49a7.1783091699.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="khemwuvx25deahm2" Content-Disposition: inline In-Reply-To: --khemwuvx25deahm2 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 07/12] nfc: Drop __maybe_unused from of_device_id tables MIME-Version: 1.0 On Tue, Jul 07, 2026 at 07:28:57PM +0200, Krzysztof Kozlowski wrote: > On 03/07/2026 17:46, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > Referencing these arrays in MODULE_DEVICE_TABLE() is enough to convince > > the compiler that they are used even if the drivers are built-in (since > > 5ab23c7923a1 ("modpost: Create modalias for builtin modules"). So the > > __maybe_unused marking can be removed without introducing a compiler > > warning. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > > --- > > drivers/nfc/nfcmrvl/i2c.c | 2 +- > > drivers/nfc/nfcmrvl/spi.c | 2 +- > > drivers/nfc/pn533/i2c.c | 2 +- > > drivers/nfc/pn544/i2c.c | 2 +- > > drivers/nfc/s3fwrn5/i2c.c | 2 +- > > drivers/nfc/st-nci/i2c.c | 2 +- > > drivers/nfc/st-nci/spi.c | 2 +- > > drivers/nfc/st21nfca/i2c.c | 2 +- > > drivers/nfc/st95hf/core.c | 2 +- > > drivers/nfc/trf7970a.c | 2 +- > > 10 files changed, 10 insertions(+), 10 deletions(-) > >=20 > > diff --git a/drivers/nfc/nfcmrvl/i2c.c b/drivers/nfc/nfcmrvl/i2c.c > > index 66877a7d03f2..687d2979b881 100644 > > --- a/drivers/nfc/nfcmrvl/i2c.c > > +++ b/drivers/nfc/nfcmrvl/i2c.c > > @@ -245,7 +245,7 @@ static void nfcmrvl_i2c_remove(struct i2c_client *c= lient) > > } > > =20 > > =20 > > -static const struct of_device_id of_nfcmrvl_i2c_match[] __maybe_unused= =3D { > > +static const struct of_device_id of_nfcmrvl_i2c_match[] =3D { > > { .compatible =3D "marvell,nfc-i2c", }, > > {}, >=20 > This (and probably others) should re-introduce warnings on !MODULE and > !OF builds (and other cases). With an x86_64 allnoconfig and just the things enabled to make this driver build (i.e. I2C and a few NFC related switches, but neither OF nor MODULES) the driver builds fine even with W=3D1. If I drop MODULE_DEVICE_TABLE() the warning appears. So unless proven otherwise I claim the commit log and the patch are correct. Best regards Uwe --khemwuvx25deahm2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpN2pEACgkQj4D7WH0S /k6Lzwf8DSkcD2KNkgrjPQ9dJBBjqHuxUaPDXFNacjjVAgwT6Pwfd+C7HF0KG1bs BqtoTI9+PXKyjz2yPy6tJFV8pq6GqGUAaDrtvBxhkUd9h4nK3BFWFlO7Z1HyiTgs syyZLelwtqqHOw74m5y5p2LDyRQj4VwwaFs1HxReBCEuCuVanb28I1/wONclUzMB +3lIl+0yVrDpvO3PknOzLV5gQo39ZyjaJr61mUr/ef2o5QxGvNE1MI1H/qaseYKI P0F0uWcnw/aUZxb2XL9+g8DFcSWUsBfx/zqKCivAMmnkgiyGS0GkzEE99yJ5sged CfYwRmwSUEwwsfH+5kQUm0TAa7CkaQ== =Jkjp -----END PGP SIGNATURE----- --khemwuvx25deahm2--