From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06E83DF00E; Wed, 8 Jul 2026 07:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496832; cv=none; b=toBMjHzzlp4VwW+zFoqeZVS35I6hBmCl4Y3U14xMlppyylyiLJHYMKyBE/zWPyTOWLhetVjiSdUiG6KmIyCI1/vQ87B3sx2unvz0oOi4tf+iNNZLJFyqVA0IbmZy40uxT3mmsc6gq1bjbp1x3JleLqlJjPoP4vvsa1vOeFmrA4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496832; c=relaxed/simple; bh=K9Q7SJnCDiRxFjGAjd6hdK0ca30lSYi1RwfNS4/WVXg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qZj0TuDjS8Tc6AjYehPoEI601cxAAWzNGrxEUzR2aC4bzd7A9ymjT2jOWWVW6JWLVy0L0ylUqJAHYm842m6JfmB531qTvyhsGtZt4R3hFyZKzuNmQw+bQhR+64uPo0oY5zoqWjLh6Aan36oPfDsagguHa0/IzY0VFVXn4+9pWHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eea4Ujqz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eea4Ujqz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C66DD1F000E9; Wed, 8 Jul 2026 07:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783496811; bh=neDS02cfQQVbwWO1slKZu1V0NB0VTVrZbXTSCvVa/Kc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=eea4Ujqz62FT0vySYF9NSerT3eNneByUh/zKAeLpIGg4Giepjmq9LwSzCfe6pI7qg t5/s4JlSgEOLi80un2HKW38j+1E+FgpoT47E6KaSAvGc7r9e4vHqNxZbgSTmc3N9sv sXNxZJfRXPJf0JKot1UJgMa2c8WHnIFd7vunEKRf3bzpMJdv/SIbyJSivwKrY8aoEi xrNOfxWTWt0lUjB7a0L0lNUYbQbCwmZ1X1oTyPSB+uXLQDnLmaWgTreYIxFc2SCY4r e2hp8QV9mvBJMcf5MtCZjcWi1nO5gDjdz7/sXDF9dh9/gTutMr7owKEG5uAhHVcWYN l4nN4l3c5wWkA== Date: Wed, 8 Jul 2026 08:46:30 +0100 From: Lorenzo Stoakes To: Mukesh Ojha Cc: Jonathan Corbet , Shuah Khan , Eugen Hristev , Arnd Bergmann , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Stephen Boyd , Kees Cook , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Petr Mladek , John Ogness , Sergey Senozhatsky , Bjorn Andersson , Mathieu Poirier , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 05/26] genirq/irqdesc: Annotate static information into meminspect Message-ID: References: <20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com> <20260708-meminspect-v3-v3-5-7aa5a0a74d5c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260708-meminspect-v3-v3-5-7aa5a0a74d5c@oss.qualcomm.com> On Wed, Jul 08, 2026 at 11:01:44AM +0530, Mukesh Ojha wrote: > From: Eugen Hristev > > Annotate vital static information into inspection table: > - total_nr_irqs > > Information on these annotated variables is stored in a dedicated > meminspect section. > > Signed-off-by: Eugen Hristev > Signed-off-by: Mukesh Ojha > --- > kernel/irq/irqdesc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > index 80ef4e27dcf4..4e58e7f5fc6c 100644 > --- a/kernel/irq/irqdesc.c > +++ b/kernel/irq/irqdesc.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include "internals.h" > > @@ -142,6 +143,7 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node, > } > > unsigned int total_nr_irqs __read_mostly = NR_IRQS; > +MEMINSPECT_SIMPLE_ENTRY(total_nr_irqs); Err... this is effectively exporting this unexported variable to drivers? This is massively open to abuse no? A driver could now manipulate this value if it wanted to? Why would we want internal state like this exposed to drivers/firmware? This isn't something you can even do right now without kernel debug symbols. I am getting ever more convinced that this resembles a backdoor EXPORT_SYMBOLS() but now much worse because you get a VA and a PA and more information...! > > /** > * irq_get_nr_irqs() - Number of interrupts supported by the system. > > -- > 2.53.0 > Thanks, Lorenzo