From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Lee Jones" <lee@kernel.org>, "Linus Walleij" <linusw@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"James Ogletree" <jogletre@opensource.cirrus.com>,
"Fred Treven" <fred.treven@cirrus.com>,
"Ben Bright" <ben.bright@cirrus.com>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
"Neal Gompa" <neal@gompa.dev>,
"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"André Draszik" <andre.draszik@linaro.org>,
"Saravanan Sekar" <sravanhome@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Kevin Hilman" <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Sudeep Holla" <sudeep.holla@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
patches@opensource.cirrus.com,
linux-rpi-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, asahi@lists.linux.dev,
linux-mediatek@lists.infradead.org, imx@lists.linux.dev,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 21/23] mfd: Unify style of of_device_id arrays
Date: Wed, 8 Jul 2026 13:18:35 +0100 [thread overview]
Message-ID: <ak5AG3ReEVvDsAAC@opensource.cirrus.com> (raw)
In-Reply-To: <ce43f6ec640a7835d64d3d696ff09229c3d31075.1783507945.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 08, 2026 at 01:15:28PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> These arrays already mostly match the most used and generally
> recommended coding style. That is:
>
> - no comma after the list terminator;
> - a comma after an initializer if (and only if) the closing } is not
> directly following;
> - no explicit zeros in the list terminator;
> - a space after an opening { and before a closing }, a single space in
> the list terminator;
>
> Adapt the offenders accordingly.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> drivers/mfd/arizona-i2c.c | 2 +-
> drivers/mfd/arizona-spi.c | 2 +-
> drivers/mfd/cs40l50-i2c.c | 2 +-
> drivers/mfd/cs40l50-spi.c | 2 +-
> drivers/mfd/cs42l43-i2c.c | 2 +-
> drivers/mfd/lochnagar-i2c.c | 2 +-
> drivers/mfd/madera-core.c | 2 +-
> drivers/mfd/wm831x-core.c | 2 +-
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-07-08 12:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:15 [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 01/23] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally Uwe Kleine-König (The Capable Hub)
2026-07-10 10:20 ` Stanimir Varbanov
2026-07-08 11:15 ` [PATCH v2 02/23] mfd: bcm2835-pm: Drop unused header Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 03/23] mfd: kempld: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 04/23] mfd: lp87565: Explicitly set driver data for the generic dt compatible Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 05/23] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 06/23] mfd: rt4831: " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 07/23] mfd: loongson-se: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 08/23] mfd: Drop unused assignment of i2c_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 09/23] mfd: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 10/23] mfd: Drop unused assignment of spi_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 11/23] mfd: Use named initializers for acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:07 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 12/23] mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:12 ` Charles Keepax
2026-07-08 12:55 ` André Draszik
2026-07-08 11:15 ` [PATCH v2 14/23] mfd: twl6030: Use named initializers for of_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 15/23] mfd: Use PCI_DEVICE* macros to initialize pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-09 19:35 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 18/23] mfd: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:20 ` Andy Shevchenko
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 19/23] mfd: Unify style of dmi_system_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 20/23] mfd: Unify style of i2c_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:15 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 21/23] mfd: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:18 ` Charles Keepax [this message]
2026-07-08 12:58 ` André Draszik
2026-07-10 19:36 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 22/23] mfd: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 23/23] mfd: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:19 ` Charles Keepax
2026-07-08 11:34 ` [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Andy Shevchenko
2026-07-09 16:08 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak5AG3ReEVvDsAAC@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Frank.Li@nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=andreas@kemnade.info \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ben.bright@cirrus.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=cw00.choi@samsung.com \
--cc=david.rhodes@cirrus.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=fred.treven@cirrus.com \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=j.neuschaefer@gmx.net \
--cc=j@jannau.net \
--cc=jernej.skrabec@gmail.com \
--cc=jogletre@opensource.cirrus.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.griffin@linaro.org \
--cc=rf@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=sravanhome@gmail.com \
--cc=sudeep.holla@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=sven@kernel.org \
--cc=tharvey@gateworks.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox