From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4FCA434E50 for ; Wed, 8 Jul 2026 14:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783520779; cv=none; b=JRgSBZqeyZ3OxtDoXbejDwUqL+3N3o4CFklAlMgDeyBL46udmGZp1bqYOercx4EY3NQlsesF6fWhDz2fg0iLVhL6M0ST6iZ9qWs3YDGDrUIWbnsYA5arFJWdYhuzVU3RVapwYSe5IQBP8LJ9XudO79INyszHFRkCPl3LdNUdZuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783520779; c=relaxed/simple; bh=l5jx+yJsONw53Xs1rk0fp9H3TXv8XQVs/u7K7+TGlEk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/gCB5HjvaH7RStkveVCV2pB+kNzmLL0vTMg8ADNhAEVnbS6D7U9ZrTKjZS6jco1429roJiqYw9+JwTYP4UoJe8r5i8MgNz3/uz1MYE4O8YCjmeivdpx6BnSJcoiZ1Y5dPxqGQVXKLspzk89PxGouEEzXwP8fuvTKfHAMEfRhZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VKC3eXUJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VKC3eXUJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783520776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hhFDpbr5Kcp7r2qIIZnGr+gxpzUklrwsX5DMooJhcUA=; b=VKC3eXUJnYkzPdC2rt4usB7ddXlQ0h+eYoaeiZ/iSHrTTJe57qmdTvacSzEutIJhl3bqgN sRw3hCi9SLRFpRXaJxc0tm/4uOyE8TT75JcScHpR0gDET+3HYfS+vRaCeaUx6ob0aL3ZXg 83Z7s8D7riR4PYH30yPvSwTVBQkei8o= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-5zOuvO6rOyG2JqdpDduWCg-1; Wed, 08 Jul 2026 10:26:13 -0400 X-MC-Unique: 5zOuvO6rOyG2JqdpDduWCg-1 X-Mimecast-MFC-AGG-ID: 5zOuvO6rOyG2JqdpDduWCg_1783520772 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B7FE61955D91; Wed, 8 Jul 2026 14:26:11 +0000 (UTC) Received: from fedora (unknown [10.44.33.83]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id A047B1800592; Wed, 8 Jul 2026 14:26:08 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 8 Jul 2026 16:26:11 +0200 (CEST) Date: Wed, 8 Jul 2026 16:26:07 +0200 From: Oleg Nesterov To: Zhan Xusheng Cc: Peter Zijlstra , Andrew Morton , Tejun Heo , Ingo Molnar , linux-kernel@vger.kernel.org, Zhan Xusheng Subject: Re: [PATCH] sched: Remove unused tryget_task_struct() Message-ID: References: <20260708023011.652637-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260708023011.652637-1-zhanxusheng@xiaomi.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 07/08, Zhan Xusheng wrote: > > tryget_task_struct() was added for sched_ext by commit a8532fac7b5d > ("sched_ext: TASK_DEAD tasks must be switched into SCX on ops_enable"). > All of its users in sched_ext were subsequently converted to > get_task_struct() by commit fbe3fb103596 ("sched_ext: Replace > tryget_task_struct() with get_task_struct()"), leaving the helper with > no callers. > > Remove the now-unused helper. No functional change. > > Signed-off-by: Zhan Xusheng Acked-by: Oleg Nesterov