From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29393B42D2 for ; Wed, 8 Jul 2026 14:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521058; cv=none; b=mj5U0A6f/e1aXmmDjm6uX2rkaee3V/Rsjsz6ruMatPEjlPFSy6ouvktelnfaSGXVMN3gvv9GfQZSVb7AYubo4jGm7WdWL9EshU1QmJTW08f7I/9O+V4jtcot511QLmf+rPkc+cDPXi7j6h76WWvG9IOqbVS/ha8l6NXDIlhpRyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521058; c=relaxed/simple; bh=shI0Xzbht7mrZad6P0/ohvAmiPWaDfwIYi7L66k8EZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Eabf028M92+rQwk+667Ikx9WkaK0ezq+frMPi1ZJ+eXifnl8LP0Rd+xAp0/IVOckN5HXMmdOKD/l5fHtnPZGHUIHKKPznMRoC53C1cWMrzQ8pVcDu5PQhoU9wvQgqg8Dvj3VJjTVTCumfWG/Rl8aekMrqnZKKmCH18gjBpFnyAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XOfl/jUY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W5wz5+TK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XOfl/jUY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W5wz5+TK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783521055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EnO3yEDF4hYIuImMBSPDhGh0xen2iTbirdV5LDk94Ig=; b=XOfl/jUYZhz0shCARdlHeeHRwqZ5ZEkd00qpS1fScGIepHYuRTewKK4SbZphT65awHyElL EQuql3X996XzYz3c6edyomggJlBeX0OwczHW35vB5aS3d1vh7SoVqWcLRNY3uWq3YejgX1 NgmTfI70C3T7pLsKxYOXlal2wwSqiF8= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-EEM7xmF6Neu04w_6sC_yJA-1; Wed, 08 Jul 2026 10:30:52 -0400 X-MC-Unique: EEM7xmF6Neu04w_6sC_yJA-1 X-Mimecast-MFC-AGG-ID: EEM7xmF6Neu04w_6sC_yJA_1783521052 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-667656a12c5so2015103d50.2 for ; Wed, 08 Jul 2026 07:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783521052; x=1784125852; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=EnO3yEDF4hYIuImMBSPDhGh0xen2iTbirdV5LDk94Ig=; b=W5wz5+TKlp9FESSolg+uq6LjU0EZksLrXiRNbTvSVg2eYCTjRoe1BokZZa5DLecuEf Lo7ODNfPPhSpMPIW69viVhDH3PkveZ/xRnX/E6WN7uz5a6bMtlVJoP+FqXEtrJAJcu3Y NYMf3prAAcvykH7aFcBI6NIpYVAdmx4amxzVNpwf1d7kX3Cx/HFjck1HFN9SA0xbH94Q udHF6/EI59pNd/9HcgkFPL0dYGXEg5jTdhBBcHwWiPg8qtLp4pT2htJ95UG0aDrzkRhX mVhF5tNFGF1F64i1S5ZeT08f7NIlWMN3KqI0LdxQlPl3SVcEteDTimn09tWAD4hQUwNu gspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783521052; x=1784125852; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EnO3yEDF4hYIuImMBSPDhGh0xen2iTbirdV5LDk94Ig=; b=LN0wt2PMYljcwxa7nPPGvfAfT4RfFuoxxg/NcAPXJ1k+DxKnE1fLijZKipGwAdN9Iz SFJtjrcb3CaY8SqWTtcHhsIInzdu/8ExHWhAjY78whA3Ri7ud2tSVlRe+f7ROLfoG4tw cXRY70Wf5fKFm7taPPZQgG8ckTO++ohdJHjHWkP+Dpll+RC2lUlxca+//rEKqnF1Mnp+ 8VlBSJ+H8vmpABy1gzKRQNhRjlDUTQoQXydbteFyK8QceBN+9cHrK9tNN4EEaxnA2+d2 prxDsslMlKQZICedLAFbCxwRmCFSRTYa+QJ+4uwUfVGepOeCbTGM9Xey3MQ17zRIbLA4 NASw== X-Forwarded-Encrypted: i=1; AHgh+RpWp4/tb0XiMS6f7TfYmcp92OCgdELkvPNRzxF/v6EY7zt+1F8i8dP+0NKpaKSJyEb//RppqTwUOlpe0Bk=@vger.kernel.org X-Gm-Message-State: AOJu0YzHloPYMbIzIrgDGuV+dtOTOWcSRDIB13nepGezmYDy27yicJF2 H0NaTj/vg4zHVlptXHEdonXbx1e7X0Nu571lqaaAFE/7h/WBVmuN0OAiy49ar28AO49rFTyXue4 KOVQ8V/KpnMOP56PZ8vEky4yGhQzbn1c0/0L8tXLviXzTd4DLa/RuY1x9Tj5n81pk1Q== X-Gm-Gg: AfdE7cnhF1NAfwTdkLsDMH9kJWS3s9c+K+UtTLzb9iOllZhIn+xJsmxjahW+Zu9t5Tw +an9Daac1jk/jk6xtAGHybq2oyeeuTWTJzt18BsgtXWJ+ReAQNUfzECwxOMte1LBrheiMvgCrn0 XwfO/Pwqsv5k4lf09ZzggIMlli7TF5dRQPuG+9IAdV/zZKQaRpiqeoLTwBLzSHw+WfciPJpTyHJ nxb0lDtOmEucDGzKW9PJLqRaSxPq33UbhX8RFswTR+rWT76x6D+V5G3Wueu1ludbgX+o750fLHn WFlKaLyKvK9VrLBullrMw/GSFWUJX/M6uGAjl0zcFm29Dq3tWpfCjlPU+vgzXGsNQPSH0KqamUw MyWUWhEisAQUFbwTYVQ5ZEodOoz/C5dgkVkcfOYqoID2Sjg== X-Received: by 2002:a53:ac9a:0:b0:664:874c:f54b with SMTP id 956f58d0204a3-6679f01a880mr2057789d50.24.1783521051774; Wed, 08 Jul 2026 07:30:51 -0700 (PDT) X-Received: by 2002:a53:ac9a:0:b0:664:874c:f54b with SMTP id 956f58d0204a3-6679f01a880mr2057732d50.24.1783521051022; Wed, 08 Jul 2026 07:30:51 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-667877aaadesm2148668d50.7.2026.07.08.07.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:30:50 -0700 (PDT) Date: Wed, 8 Jul 2026 10:30:48 -0400 From: Brian Masney To: Jia Wang Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] clk: ultrarisc: add DP1000 clock driver Message-ID: References: <20260617-ultrarisc-clock-v2-0-9cb16083e15e@ultrarisc.com> <20260617-ultrarisc-clock-v2-2-9cb16083e15e@ultrarisc.com> <178349718662.2043299.5991323028483371285.b4-reply@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178349718662.2043299.5991323028483371285.b4-reply@b4> User-Agent: Mutt/2.3.2 (2026-04-26) On Wed, Jul 08, 2026 at 03:53:06PM +0800, Jia Wang wrote: > On 2026-07-07 15:54 -0400, Brian Masney wrote: > > On Wed, Jun 17, 2026 at 02:02:55PM +0800, Jia Wang wrote: > > > +static struct clk_hw * > > > +ultrarisc_clk_hw_register_composite(struct device *dev, const char *name, > > > + const char * const *parent_names, > > > + int num_parents, struct clk_hw *mux_hw, > > > + const struct clk_ops *mux_ops, > > > + struct clk_hw *rate_hw, > > > + const struct clk_ops *rate_ops, > > > + struct clk_hw *gate_hw, > > > + const struct clk_ops *gate_ops, > > > + unsigned long flags) > > > +{ > > > + struct clk_hw *hw; > > > + int ret; > > > + > > > + hw = clk_hw_register_composite(dev, name, parent_names, num_parents, > > > + mux_hw, mux_ops, rate_hw, rate_ops, > > > + gate_hw, gate_ops, flags); > > > + if (IS_ERR(hw)) > > > + return hw; > > > + > > > + ret = devm_add_action_or_reset(dev, ultrarisc_clk_unregister_composite, > > > + hw); > > > > Use devm_clk_hw_register_composite_pdata() > > > > I originally used clk_hw_register_composite() together with > devm_add_action_or_reset() because devm_clk_hw_register_composite_pdata() > is not currently exported, while this driver can be built as a module. > > If exporting it is acceptable, I can add a preparatory patch in this series > to export it and then switch the driver to use that helper. Yes, I think that exporting this makes sense. Brian