From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7AF633E360 for ; Wed, 8 Jul 2026 15:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783524009; cv=none; b=cqncYbXf7Y+6+hBAvhsc4y6RX88g35Sc1/4VfcBuLX0/W9er1eOA453JxuOKkBkvUPNUWekqVGDWcQXUWAxlUoVcqh0oTrzBhVlvBV+fSxoyZGMBCwv3me2+cASmrn/oLqMdLbLKneH83ilYfgc5BwuOgdmUn3N9MkNnK8mCSm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783524009; c=relaxed/simple; bh=rVynhSGJQfBar7kSfKUFXagH6yPn9k2sg2o3J/K/fsM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mv8zmyWvmiwkChRIvTWoqV152wYmaPG56kTCUYwNORq1JwsRnBNsB+Lr/Cw/QyfNDdUH6DdE4r7oG8QzLHtf53Jk+ZT4VrywNUXnOXGsYhC67Xt4g51dSW3Hy7XQiDsAKtKeLi4UHG5rppRmQ6cKpKy+N0o3EcZNE7OMKox0LJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oe9B+adj; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oe9B+adj" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c12614b81c9so153700766b.3 for ; Wed, 08 Jul 2026 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783524006; x=1784128806; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mqSnMFPiVuGNOhIZD7zvUQogIz2kUM/yQukQ9r5KdO0=; b=oe9B+adjoMC9qjXenAlnRvS+8hwquFqufZPIL+U2C/8R4lW3HoMKUk83wa0K8WhFqH 8tLWtbUq/6hNexKgWzGHGYlE9VX2IwlwTCgkPgr1N+/s9LxeQ/xXagnmnq6g1gx0LI7d Zuo1nmB2TqDgpTuaB1ClP56v7/bf4osLo99+Om//SjyauoIA9Md+Dtarxi6hjkXTnJMt dONF0kdQ9aU/VrHdt2qlbPOzLMf5g4MDyJGZ/3aU0U4R+NxlYKAH4MhCh6S0GxGI92UV Qt6QkVrnMrUhlmRyYcU2lHWxy8Bq7EERn3ZoqWuR5XX4BD5HSMtyH2s2DZ9m3zzoZsL6 /zbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783524006; x=1784128806; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=mqSnMFPiVuGNOhIZD7zvUQogIz2kUM/yQukQ9r5KdO0=; b=rQIXp0VmyreA8mb8yj8hbKry/v2+KhsJmvWF9N9bGNKOXhUyIcaWy7tIwg/CVpwznq pZb95NM5BQFLTL8cLE3unEc9kSWdFxaBZ8vsW3oC4U67Q0vPY16kNPon7Fys5eS0TxPi vxjyVrJ0GsnGEJsThTPqSBPyahuqhiyZ47gbPBCYj7SzbxtNXEmhgzZt5PlT96b8FvT5 nn3Mc5vHFDIzSLVZGaDSwOorf/L6Xc51f5vBq2A/DTA616ckmt1r3dudEq9kIx5a2Hkm kvuSN5IY1ObBQVE/i1ZfGZnwhTHNA1SynARwGNdjls52Cqwy1GpuPYA4wvA6W0/tGANl +ZYw== X-Forwarded-Encrypted: i=1; AHgh+RoysByGdRMv3I+W1cwoPRCUwnVazJ8YvqK/d/l9NkQPXJrssgZom8on3lolOxp+FDUoWkCE4Vb+f/X9yQ8=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ0+PDLsaFCj8NPGv9PeJxCYneKf41dFKfTFgp1xB2JF0igeFi S72YsJnI6rt6f16TlXiicIQ/lbi4BWufyXoJrdfwL/LCMHZLGsqIrkuSikz4bg== X-Gm-Gg: AfdE7claBGm9bkHWXvoT8wUPFc0lGe4E3MtKl5ceEza5tNiBeQiDxfDcpDj8DdA4Rju ZWuz1+u2IuGpkXhEPjcSZY0LCBmJ8eD2YjvRhYO4RP0UO8Bl//PP88dpsEDZBfn8BWDCOzvLAYw paoY4K6ssM5lbeQsEjBODcRhRf3ACUrwLgZBHJpN9jzxhUwWL3ZTsyOVcB5Iu1xNMG33lDDmswP fgXI/hayuVYTKzBHBT+R6Sxz7l73Sh3Hriu0jIx8akpXX6ojhExd4Eknoe8sckPm0/pu0Haiwhj 1khULb9EtteXmKpD/ZCb0gmwItDNValTPrmVslYl/PdTIKPS9XghY2Tu08Bg051y5aI5VZz6QpB 60DLeY3FD7MWkgHW50lccf+XFQnugaQMy+DHcEiNHiVkqsJSLOZWZmPWacW/z998+p2QQQY0Ze0 jVHVQAi7XE9JAq5XlVIoFQXg1MkCRt8wq7ifiCuWWSfnek+lCd1vQIbdNUyqNobFfB X-Received: by 2002:a17:907:c00a:b0:c15:c81c:d6fc with SMTP id a640c23a62f3a-c15ce06f33bmr137514766b.9.1783524006035; Wed, 08 Jul 2026 08:20:06 -0700 (PDT) Received: from fedora ([102.78.12.220]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15d6cbadaasm89066266b.46.2026.07.08.08.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 08:20:05 -0700 (PDT) Date: Wed, 8 Jul 2026 16:20:03 +0100 From: Jad Keskes To: Greg KH Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: misc: cytherm: replace deprecated simple_strtoul with kstrtoint Message-ID: References: <20260622123124.2380612-1-inasj268@gmail.com> <2026070803-capable-economic-d54c@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2026070803-capable-economic-d54c@gregkh> On 07/08, Greg KH wrote: > This changes the user/kernel functionality, are you sure it is safe to > do so? Nobody writes garbage to these on purpose, and if they do by accident they should get an error, not 0. The only way this breaks is if some tool depends on "echo foo > brightness" silently setting to 0 — which would be a bug in that tool. > What is wrong with leaving the current calls? simple_strtoul is deprecated per deprecated.rst. It ignores overflows too — writing -1 wraps to ULONG_MAX then gets clamped to 0xFF instead of erroring out. kstrtoint returns -EINVAL for both.