From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9613747AF57 for ; Wed, 8 Jul 2026 16:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529567; cv=none; b=hUmi4885vHZYcQuyVJZjQ6Hd5c3nDY2JPLI6f4F0tE6+yxPc4t1NOGY6pIchY9kPTuPj39B+pWn5Td9y+4ItGfu9QAKdE2IBThJfo8AF0t9V/grUHAuegg373fSkuROPN8oIyFbB9YlzjnibIJbcc5K1vmdCewQ92glmk2DPuys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529567; c=relaxed/simple; bh=UKK74oBj//dCoC8VMB1RGDEsrghOWG3yhyS/irSiIew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=USChFCsAQFpmOTEtEA59ggQ1J3p3saCstwb/7zOb6ANYwQJjZ2tsbkdJCcZS30NZ3faqkFO17SFGbfkdGUMePZ309rPSBpoDpYQDQyS2JvHqcqM3sBTJAUN48NLGPk3UaXNZ5bdBvJDMqefDjNpTCK9cCgUmfFYPURk2w5F3Fss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zPlMnlvn; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zPlMnlvn" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-847a69ba83dso13030b3a.2 for ; Wed, 08 Jul 2026 09:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783529551; x=1784134351; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/8he9g4g1EMf9ol1adAgO+GmtYoJo0irIC09VPP3sRw=; b=zPlMnlvnzJoRHjuTsYu5AjvKVvDlE7EFacfJYZTsC/aUnU4duEuyjvp8xcv17r+DEH A/4hYiwevXMWkPGKldboYbgRzFdYe5YQyhtdfi8tCSdFf4hqFj3/Vvt91AAcmYE0vo9O QnlxiMUPc3/4VhbbSkPRnY/FiiuhDjOG0Pf6EcMKlg6lPgL1r32omwObLOlu5zRBLjU7 xs/pnkN0jhHIQg77e5YVTMbMJFN4gO7yauWHSfqtcMoxewIchkCdONLW9TfiIMn9wSfa Vb6OUtQvx4IuEaqcQeGIg4w2MgJlK913AFvZpSLpl7uoLwXwo3m1ACrnbwe9BL/b/pDG h44g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783529551; x=1784134351; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/8he9g4g1EMf9ol1adAgO+GmtYoJo0irIC09VPP3sRw=; b=pkdw06FP7vEPshv7jGEZ8jhx9UMFk5MqVxhXtq8l+jUDfUpHdvnxynI3bwpyAjIYhr pUcChSBqxIKN9ck4q7URRgVOvXb1118q68Af+KUynL2gnc9jN+GCJFON1os78YcMdL9d AaMTt37wh4LWwrAzhjULnK9AacKGL2Ab0UBzK6QKxCSEjc96C29aAEbN4BEfpO2oQZAu ajmAIfHjkN3A4mUzY/foqm+8ufvKcAw4t70uLhZ2RDyxltFl5iBejBNeTgwa9xW73aV9 XyiPNtTLyIYgHCWHwEODqB0TklFJJNyiz8c2sMHNias4x47kp736LEInfuyq4Ch8HqO7 Os7A== X-Forwarded-Encrypted: i=1; AHgh+RoAl7C2s8AtMKYvQOjQ2b9MYFYFvxyTVjR7dnt907xRuqkfx4MdR/pdbcsjAzXz/WHV/ujYF7vKpBFgLW8=@vger.kernel.org X-Gm-Message-State: AOJu0YzOP1UIY5VoQRceJXWbG4xDjUeSWc8ev1sw5qPsNqhUQCOLgIo5 6NV6veat3aRfcOk+eDRBVsaxZV9Z3+tdbZ4i51l2ejkCbe0/WwzZLLR6SObzXiZHk7w= X-Gm-Gg: AfdE7ckOa0DwGFhkPKI1hVLlfVN7zqApjojXRpeKzq2W3F2Dw4sfnddPTmCgIDSJ378 sNzmnQPVypmBHWFfd5qrDPkEdB5kdVrkShb6G95P0oKRS81XhBhM9Loz9wLlOgZUBw4QHUbYMkV qif6ukeuAUP4z4B+fMb/h0iDq6rKXZhL4rUTQCUJ/uRyeDH+Kdk6Mx68iWM12gxq4JHteQb/CeQ UjKUej3zyiDk8/rYzbZnXOiWr6VvP9U6Ys+lUkUcpgwT+5lJNQ30GM1T5wEpS8SpGyKqILEtJHs r+wv9A2VN/KYhbP7U533ukxpqCIKpE4QfvhyR0xcuouBILPxOtXK1GFmgxld5izQAHd8cIJTSJl +f3wlLCGdB+fH9nHiROI6XPcrA8nAOwxCZU02eJrVR+BqrnqkbYT51t3Wj+zbkPkB8IYRI21scZ 76EQ3kL5+ZVMPvs+GcdwB+MRaUFNY= X-Received: by 2002:a05:6a00:182a:b0:848:2f6e:e538 with SMTP id d2e1a72fcca58-84843241b9dmr3348154b3a.76.1783529550483; Wed, 08 Jul 2026 09:52:30 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:da71:a4fe:1ac2:9750]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84846b8a576sm1169973b3a.15.2026.07.08.09.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 09:52:29 -0700 (PDT) Date: Wed, 8 Jul 2026 10:52:27 -0600 From: Mathieu Poirier To: Krzysztof Kozlowski Cc: Bjorn Andersson , Philipp Zabel , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: ti_k3_r5: Drop redundant NULL check on reset control get Message-ID: References: <20260705172353.119031-2-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705172353.119031-2-krzysztof.kozlowski@oss.qualcomm.com> On Sun, Jul 05, 2026 at 07:23:54PM +0200, Krzysztof Kozlowski wrote: > devm_reset_control_get_exclusive() does not return NULL (only valid > clock or ERR pointer in case for non-optional get), so simplify the code > to drop redundant IS_ERR_OR_NULL(). > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/remoteproc/ti_k3_r5_remoteproc.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > index 04f23295ffc1..b1d04d082e44 100644 > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > @@ -1074,11 +1074,9 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev) > } > > kproc->reset = devm_reset_control_get_exclusive(cdev, NULL); > - if (IS_ERR_OR_NULL(kproc->reset)) { > - ret = PTR_ERR_OR_ZERO(kproc->reset); > - if (!ret) > - ret = -ENODEV; > - dev_err_probe(cdev, ret, "failed to get reset handle\n"); > + if (IS_ERR(kproc->reset)) { > + ret = dev_err_probe(cdev, PTR_ERR(kproc->reset), > + "failed to get reset handle\n"); > goto out; > } > > -- > 2.53.0 >