From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2466248AE3D for ; Wed, 8 Jul 2026 16:52:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529585; cv=none; b=chjzftAUYMzXDfBqsRqQhShEy8ucGeO/rroB9RQC2xGnWBp1GqSlXMT6AyFCJcmyOszgu8BAkvcNleXD2sIqS+1b7HeLk3vRZBNYfPSJscOcxDZN2pbaCPLO4rp5UH+vsvXB5pUdj/dYzrBy06ASe4JTZmRh3fkUXVIL8U+On3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529585; c=relaxed/simple; bh=ahFVzm/pHP34qDXNZCB90GnFKvBTrr8Ghtixl2Baw4s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ohpHhhdBA8CNm+byXFR7J9IHC0FIp3nGveErtGE0MU8MjROL6vZtnyU8XVW2Asvrqg5JQyWRLyCR++FfLCRBBJU3paxA7xe6KHhm2vxxvzR93ySLrX3dYgvgISmzHoyG42DAcZs8tb4zV6ztIg17Uh2HpQEsdkEA41AaFhFPW/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WSQpqJax; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eUvBhOK7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WSQpqJax"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eUvBhOK7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783529576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fkm5WUQgDiCqhtYtBp+OiJIKsSElXb8Y9+10KW5dz4A=; b=WSQpqJaxj8SNaJ0Cv7Taea252mV+QSiKBGIm2sPeU01EenQXlLAVRLowizajVRfSTazRzv t1ldTZqbtrUHX4taTb9yF5lM01XtyQDtKLLDZEChQ012KKQdawJdMs37Fro4feuar0kM2d g8Edmo544hRJYRuHPiaIlRql34zZwN0= Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-UqlWoydBNdG8b4AfKSayOA-1; Wed, 08 Jul 2026 12:52:53 -0400 X-MC-Unique: UqlWoydBNdG8b4AfKSayOA-1 X-Mimecast-MFC-AGG-ID: UqlWoydBNdG8b4AfKSayOA_1783529573 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-664c1e14361so2263248d50.0 for ; Wed, 08 Jul 2026 09:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783529573; x=1784134373; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Fkm5WUQgDiCqhtYtBp+OiJIKsSElXb8Y9+10KW5dz4A=; b=eUvBhOK747dAuqxRSSuDsyYTur2M2l6cNtcw3sA11qp++0BOxeGwbC2pu3DrZl+U1c Lg7i1gFA16XD3VohaaEZclD+lKvxnBPUf7oJUS5esFUby5p0OUkgRJfBtBU+SDu0tawy ctwWp0fQER2WFZZAaQj5JdVQ/fp8PSrhVkDyLKk/LhqI6E4GLUu+rYLHPWNZjk/UzIgS 77FlDG1KaCxhv/4gqoAY1ZnJSgv16BP3d/uBUQWMYESTjJanFkk3xntOibu8MAk4uiPn Dt8jhF5lSu4TbXICSQWmDPmkXHv57MnvZb/DFKyjcMpthIDcT0TWULbHDHdN/ok3ypqB a0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783529573; x=1784134373; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fkm5WUQgDiCqhtYtBp+OiJIKsSElXb8Y9+10KW5dz4A=; b=GjYPfjil/a7AJenf/FZL2kE+OtpGMv9LoFrISei8o5eq2Pb1Fpz/yvrg2Pz9mb9mrr luKKJ50a3nAfRnzyjmKaoxz/mNvADZaTtIV9Jl8EhS4M2NDXxrVV2lYkouISzU4yj5dE V2clkPlVX3TqNY2A/6l01CYN2spgRPsUcwm2ZNKqaNo0jSzYPvxAGTd1s/JyAce40Twx w2zbqzpOWfVBXTcWWp/HFSTBPBRwzNSuPe1avCaTY4+ACd1E5hAmVyKIMFBddmH+2BDt u1Tao3/QLFQJ5ADj+1KU7rsxWKFOrwkt+xeUtnK0NjXBU4rgUkYNAPJ0nn7LpfUS+BfL LNPw== X-Forwarded-Encrypted: i=1; AHgh+RoE1+tq38gIvFcCAy99GNB0Pm2Mba7lPuP1ntp7ZF62lYIn2AeF1Kn+jO7LdwrpKU6k5kfHbOVNqZ6hUyk=@vger.kernel.org X-Gm-Message-State: AOJu0YwEgjnwSdVJdovgcQlOEf+nL4KC34m0FzjzbE40akag1Vnu16/5 MD2k5Uj7GnRYRlTE5Ah0GF501ZgGQXvhTKeOjw/V1of0paNgujjGdE/p5fDBuVbAlkvjJLHX1cA wcbwCSOQNGt7nBoF2ZRguDdJwbgK0WBEq653tNhuG7UINZ6Vi42Y2ZhFh5yJqKUrqdQ== X-Gm-Gg: AfdE7clTU+sFasVU1XtlTJ00TmbdI1KwPiAWTLgcvgKjBuo4mVZStb36rm9UHdOSdJX 6Df+08puzZbqHLjQY0UJqqf/Igdopk2Bf6+oJxzl+gf9Z4R6mTFabOSK94c+9hsn7dwPPzTdA3v C/yYYuXwHcQdvTQVOOLnWelxuSos90aG4BZ4E6aIN2afqWH15JcNRbaKYsXoA5W0xRIfh+avODI 9XWcH7a9+7Swln3kb0HsYp3iK+dhMasB4TRZ0qGIyZPUU3yCyZSgGNUu1orB0+RLbnVpmSU35mo mcUh7Qz5NNzNejqEjULiaQ2A76ZmiHd938xskWuf0eAYrxeubO5UCy/dtnxbVbUMaQLmDXvokLV 4fWkrgPYmXo1G23mhvzkbN34CGw9SD4b/KDKQuwAbp0co5g== X-Received: by 2002:a05:690e:4401:b0:667:8b91:2447 with SMTP id 956f58d0204a3-6679f29b98amr1841315d50.94.1783529573063; Wed, 08 Jul 2026 09:52:53 -0700 (PDT) X-Received: by 2002:a05:690e:4401:b0:667:8b91:2447 with SMTP id 956f58d0204a3-6679f29b98amr1841286d50.94.1783529572418; Wed, 08 Jul 2026 09:52:52 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66787a20208sm2369797d50.14.2026.07.08.09.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 09:52:51 -0700 (PDT) Date: Wed, 8 Jul 2026 12:52:49 -0400 From: Brian Masney To: Christian Marangi Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: en7523: reset PCIE HB on init for AN7581 Message-ID: References: <20260708084045.8380-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260708084045.8380-1-ansuelsmth@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Christian, Thanks for the patch. On Wed, Jul 08, 2026 at 10:40:44AM +0200, Christian Marangi wrote: > It was reported that PCIE HB should be reset for AN7581 or some instability > or link training issue will be present on warm boot scenario. > > Reset PCIE HB on clk HW init to handle warm boot problem with PCIe. > > Signed-off-by: Christian Marangi > --- > drivers/clk/clk-en7523.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c > index 1ab0e2eca5d3..c450d89bfa96 100644 > --- a/drivers/clk/clk-en7523.c > +++ b/drivers/clk/clk-en7523.c > @@ -57,6 +57,7 @@ > > #define REG_RST_CTRL2 0x830 > #define REG_RST_CTRL1 0x834 > +#define REG_PCIE_HB_RST BIT(29) > #define EN751221_REG_RST_DMT 0x84 > #define EN751221_REG_RST_USB 0xec > > @@ -853,6 +854,12 @@ static int en7581_clk_hw_init(struct platform_device *pdev, > val = readl(base + REG_NP_SCU_PCIC); > writel(val | 3, base + REG_NP_SCU_PCIC); > > + val = readl(base + REG_RST_CTRL1); > + val |= REG_PCIE_HB_RST; > + writel(val, base + REG_RST_CTRL1); > + val &= ~REG_PCIE_HB_RST; > + writel(val, base + REG_RST_CTRL1); > + Sashiko has a question about whether or not a delay or a flush is needed between the writel() calls? https://sashiko.dev/#/patchset/20260708084045.8380-1-ansuelsmth%40gmail.com Brian