From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1300C4A2E02 for ; Wed, 8 Jul 2026 17:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530480; cv=none; b=ZybgsPiRyQIYSi5YadQEGT03+8CpS1STZEOPkbf+li0l0ZS4NjeFw2o/sYb7ZpVm3bKR9oeKkQueqq62mX3niKLBb4EHTNG2Ib7yd+LxZivLui2WqfYFSzkkUggAhmSSQc5gjPOQokqV9n8F7tAc2Qyhw8q2wXW7uy1L2JSA3IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530480; c=relaxed/simple; bh=Okun8PgF7PUdESpTukMLPfo/8mr/wu4lK2Kd+zVCkCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S0VZo6WoLqRZNDJVvIx0Ht+RM5NLBiGYQ1MCHDt2xgse0IDmUmuQjyISt8f1j8LdhVUhXF8TdZhzqvPjoD3tKaqJazlHIsI9MHQo4zXrA7tAi/iU/qcR6myEP1DnLBUYPaIKcNG6quI1NTV0DmFXlOOyQkRK8md1IaW6xH/aq5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N91GAFJT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N91GAFJT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-381065a7a03so721030a91.0 for ; Wed, 08 Jul 2026 10:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783530476; x=1784135276; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7wFTXwb6Z1kkFm2K1NVbhztTCfF3worZxBUKjCMRONY=; b=N91GAFJTo3Hlksu450DpqF01E3fLxMFEFcITn1lwSAzLecXwqB+QMeAQFMOpH0IZJM cxTFFRUQosIdgifTKPPtliig/XFu1XErwCrYFLsPbkyZd4bpeOWw5e8VKGpq1rfzJsQ9 NwltAFFXQxR4UYG7ajOkqb9MQQicvs9+K6vGQCK09Sj+VOx2lCnlOaj+3EbDZAzDWdHy nnxeBfycRTd7aY3GEl39Sjr7BnIIiHk3YTVkNiczvv8g+ilvjBl+M3G77oqaOETQZk8L CiW79kRzKMBFzcQd9+shfG51P0gWwjZS9ci1Mrp3kysYUhdCytfVa5k3AvMBmtBptQCv ZvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783530476; x=1784135276; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7wFTXwb6Z1kkFm2K1NVbhztTCfF3worZxBUKjCMRONY=; b=LKEvcctwR+5Xhx0o5paXOzRFzQFVIMpAZsksUB+lYpyzPjp9UF23P2yOS0Q08tRC/8 HVm4zBM6MzeUcZFEj4SWP/baMIxlwR3RJnCHeocZ+UEWGw4k+Ug35NTggRu77AzvkC6G FmA+Re/qZBjdK0MKCxJZNWEsJaTnETr3GF2BXClkLWz0pr0aHdbRVvr/B2YvKDEqfbJb 3GEs5j8djbdhWdG1Vw2HkYq6TPOh6LTFW5tmwO+p+TMxJGi26DNMX0lj+0Xc3jLPbG/b HlWEtL+N1e9VzmrtEAv7BUO1EEag6Kj74z4PkO/fiJ5EBWZiQWnXjUsn2mlN0I/vt4+T AH1g== X-Forwarded-Encrypted: i=1; AHgh+RpRJJTVq/fyCKRe2Mm6V5XpBbMtbZl8wQpZnPqih9c0YU10lDgGh7D0gAyUsJhspsIoH66pkv9uzaqDaUo=@vger.kernel.org X-Gm-Message-State: AOJu0YxR2wHnzXV/6iXnXsmwO9s+T+rHRtUAs6mE1QevhCwbDC4xGEB/ OghkQfIcZxFl5kppLFz5ljifIbzztGeFvAPYlRTB/JDoVT4WWeSLqmxukNEV7qgDAh4= X-Gm-Gg: AfdE7cnkEBau4UZiYr2/upmWZbje2QsW5kBzHZBOTrPXcI9tIvabxAPjFw//RQXkk9A mxqmzKFU+RWQ3SFvIcMLAPMhjbL+FA5WBi/a538dy7prSMBPsws/G2A7/rVn4kVxJZG4Kjj4ppP OB/XAzIEokLXeBFeLOqBY+cWJ3iZR+09+sNqXkSQ5U292HT2HyfM941zkTz4CVVKeERy7PQ5tbu pDjxAW5+wz+XMrbEYdo5vihJ8Q4Swq9zA5bEu+JZI2uUJwKJaXwwQWyCo1tJQpg9Dw7uhypA0da Bw/6wL1tIMO/wWH8Q38i5QOpjjQo4UIl2ZrPwgcwlUjEFH75e7GA+P2KJjoYmK3mDpamYT5l5cM 9vnsjJ+npVsANsCqGGCEHK5PEceB6LaQ88zzvZxLEIvYpyNvowAuBLmltVnEtm+NTJGb6rFUPNN 3r5abiMLi0Syg6Nsqz X-Received: by 2002:a17:90a:d88f:b0:37f:ef32:d444 with SMTP id 98e67ed59e1d1-3893fe5bb10mr3499928a91.1.1783530475481; Wed, 08 Jul 2026 10:07:55 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:da71:a4fe:1ac2:9750]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-388fdaa2c73sm1084089a91.1.2026.07.08.10.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:07:54 -0700 (PDT) Date: Wed, 8 Jul 2026 11:07:52 -0600 From: Mathieu Poirier To: Johan Hovold Cc: Bjorn Andersson , Matthias Brugger , AngeloGioacchino Del Regno , Guangshuo Li , linux-remoteproc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Erin Lo Subject: Re: [PATCH] remoteproc: scp: fix device reference leak on failed lookup Message-ID: References: <20260706065614.389412-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706065614.389412-1-johan@kernel.org> On Mon, Jul 06, 2026 at 08:56:14AM +0200, Johan Hovold wrote: > Make sure to drop the reference taken to the SCP device when attempting > to look up its driver data before the driver has been bound. > > Note that holding a reference to a device does not prevent its driver > data from going away. > > Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") > Cc: stable@vger.kernel.org # 5.6 > Cc: Erin Lo > Signed-off-by: Johan Hovold > --- > drivers/remoteproc/mtk_scp.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 85a74c9ec521..436656bdfa8b 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -36,6 +36,7 @@ struct mtk_scp *scp_get(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *scp_node; > struct platform_device *scp_pdev; > + struct mtk_scp *scp; > > scp_node = of_parse_phandle(dev->of_node, "mediatek,scp", 0); > if (!scp_node) { > @@ -51,7 +52,13 @@ struct mtk_scp *scp_get(struct platform_device *pdev) > return NULL; > } > > - return platform_get_drvdata(scp_pdev); > + scp = platform_get_drvdata(scp_pdev); > + if (!scp) { > + put_device(&scp_pdev->dev); > + return NULL; > + } > + > + return scp; > } > EXPORT_SYMBOL_GPL(scp_get); > > -- > 2.54.0 >