From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412092F8EB4 for ; Wed, 8 Jul 2026 19:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783538306; cv=none; b=W+MmMRaEuw9XN8Wj7AQJD3PAI2PwwLPpNVfsJUQLfoHpoBaKNjQyVteLgHrSES1u8To96KJ/WkBHjnG3Xj1fDEwowtjHVwn8gzbxak8xAGrfPMHpqrbdh5CecqhKZ21ok+g8WjYjvWjP4DxHgV4+bUsYatehDMohCqS0mTIG36w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783538306; c=relaxed/simple; bh=Nuobs42GWN9jY9nFDEzqJGYWYg8zA3CPFZD6afRvhWo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AiFwgcJ9x/eC6wX+TDlSc7rt4qWqK2KSYLf0Eqvyw699N1lN1buqyII//Vi4yGDegg6dPT+JUy242tUKNzF3Jjq0j6PbeDGZVYFYCzcS7bgdWt7nNWWjbmq8uEUaEnoXChD9s9mVoDNFbWlhMQe0CLgKZ4dNHeWkKu66hItyfgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S9l38A8g; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S9l38A8g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783538304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BvzY/mZGKEJx6zIsYvZa88M0P3VBfNQj1yFZq68GFbc=; b=S9l38A8gKNJKEk2dRM0RakS07P7mT5/kZ+k4YUeWi+7o9AwCVJ1d5vgqGFWzuZukD1pNCn kGhf/I1uzQS6NeEvu4yWVfTo9uUg0tpHOZWYYImK3pzYvTk68WT3Esezl49nndSJGr58JM n0p2hYas9CwXBm3TuV52U5mpuJ/2oRM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-Ks6cFFghP2WYJsger330qw-1; Wed, 08 Jul 2026 15:18:19 -0400 X-MC-Unique: Ks6cFFghP2WYJsger330qw-1 X-Mimecast-MFC-AGG-ID: Ks6cFFghP2WYJsger330qw_1783538297 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 565A91800615; Wed, 8 Jul 2026 19:18:15 +0000 (UTC) Received: from redhat.com (unknown [10.22.80.46]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB6591800370; Wed, 8 Jul 2026 19:18:09 +0000 (UTC) Date: Wed, 8 Jul 2026 15:18:07 -0400 From: Joe Lawrence To: George Guo Cc: chenhuacai@kernel.org, jpoimboe@kernel.org, peterz@infradead.org, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, kernel@xen0n.name, rostedt@goodmis.org, ardb@kernel.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, yangtiezhu@loongson.cn, jiaxun.yang@flygoat.com, liukexin@kylinos.cn, guodongtai@kylinos.cn, xry111@xry111.site, wangyuli@aosc.io, loongarch@lists.linux.dev, live-patching@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/12] klp-build: Add LoongArch syscall patching macro Message-ID: References: <20260707072031.231066-1-dongtai.guo@linux.dev> <20260707072031.231066-8-dongtai.guo@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260707072031.231066-8-dongtai.guo@linux.dev> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Tue, Jul 07, 2026 at 03:20:26PM +0800, George Guo wrote: > From: George Guo > > Add LoongArch support for KLP_SYSCALL_DEFINEx(), mirroring the generic > __SYSCALL_DEFINEx() pattern from include/linux/syscalls.h. > > Co-developed-by: Kexin Liu > Signed-off-by: Kexin Liu > Signed-off-by: George Guo > --- > include/linux/livepatch_helpers.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/linux/livepatch_helpers.h b/include/linux/livepatch_helpers.h > index 4b647b83865f..a8aad067177b 100644 > --- a/include/linux/livepatch_helpers.h > +++ b/include/linux/livepatch_helpers.h > @@ -91,6 +91,28 @@ > } \ > static inline long __klp_do_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) > > +#elif defined(CONFIG_LOONGARCH) > + > +#define __KLP_SYSCALL_DEFINEx(x, name, ...) \ > + __diag_push(); \ > + __diag_ignore(GCC, 8, "-Wattribute-alias", \ > + "Type aliasing is used to sanitize syscall arguments");\ > + asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > + __attribute__((alias(__stringify(__se_sys##name)))); \ > + ALLOW_ERROR_INJECTION(sys##name, ERRNO); \ > + static inline long __klp_do_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__));\ > + asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \ > + asmlinkage long __attribute__((optimize("-fno-optimize-sibling-calls")))\ > + __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ > + { \ > + long ret = __klp_do_sys##name(__MAP(x,__SC_CAST,__VA_ARGS__));\ > + __MAP(x,__SC_TEST,__VA_ARGS__); \ > + __PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \ > + return ret; \ > + } \ > + __diag_pop(); \ > + static inline long __klp_do_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) > + > #endif Nit: The other macros in livepatch_helpers use tabs to pad out to the line continuation '\'. -- Joe