From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011061.outbound.protection.outlook.com [52.101.57.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92AFF227BB9; Thu, 9 Jul 2026 01:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.61 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783561333; cv=fail; b=Ufz+zmBmfEros51qCVLWMJnyhS3cWWftv5rfXiQYYa+BCzbyG991yZOQMj5y1AOnFxuk/8VuQVd9MXioKBntQ6XFsXQp8N34MZOPsjcRX/Eyho+GZ563jq24eEddblI2gemUWp/4A0ewzGfbuMhW0ONJKFFANUmjmZuFYQbI/QE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783561333; c=relaxed/simple; bh=y0poN+1EPW7xNpWE3hOGaD6xIylh6eAvoaFETQpkerY=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lox+4hg8P8OReXN6SeJixSnP/ZGxRf9HGTgPy3hIMd+p8WyVBcWYplEuM22KU6BaH2a9gK0fSbeMw+gWCD5RVIgYGR9zdI0Xwb2vtwG2bBMdTnsrBsAB7b0gzbTh+5iMbXLrXMb8jSlw7Mgi+c3wY9lBg1xHX7br2z4cnuX7MMU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=g/MgjVCj; arc=fail smtp.client-ip=52.101.57.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="g/MgjVCj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hQ9OJizXG06KSniq0kBR2xAaeZQzQhkgZE8JWoyGCht+9AoVgMXgpx0xqN2IlB1OZjUAayUwdUCt9e+GL1JGfQezALSzjxe/ou2OcJcaDjlR+2a2j9iUqn8AS28m5EacFRDqXbKn9FP4n28xDfbokVBRI/tIbYvVrxi2VjwpgTKUi6w4VFyjiudZMSupqTdHcEaaMNOYmUuUge15SmCCYryQNhdJphQ3EOQLyrgcKtw5h/VbBCQzq7bjPIelDICD5btFpJNsGLME4+a6zflgyErv8OEkAuljMpDzLYn+t2EKfOfH32mxvhEoacRJK1lRnT6ZQTpPaGTV841OuaTStA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e+cfSAL3Q4PR7oNTHL4eRQO4PHXRrP50b849gIYO7nw=; b=pdUJwEsf7lt6LvfdQFDJzoxSNjXL2CSKRfj7MVO3gIR/wDCdHh8d8yT0A30tKv3Bzq5qOSQ0abaLESWbojyOxLE7alFCw0T+9QZmNt7mTxAk/g/bZaBOyUYbd5Y8SvNmwqH6542s5rajjaf/VwzC9tAeAtO0DoOUdxtrjmedtEUUwrvBb8tQOVpDDztCXKdCbOi5GIDUssqs4Q8FXvdw/y9KFzdNjMdvoqep3IhlxPUA9tG+AnMah5koZq+yn6JyKY9+MVcE10JmGtiiN6WMYwrjznf/DQceLsqUxZjN4sReOj+myk8Z4FBSXUyTL7uswDGlapHBILjbDuaWYYO6Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e+cfSAL3Q4PR7oNTHL4eRQO4PHXRrP50b849gIYO7nw=; b=g/MgjVCjmF5kBNXHhbkf1tvlf3gNrTvqMm9r5h+wGt1nOyLfRrvrfpX5bFUeesakASbxA+tY0zMMcgllPp8+7TT2knta/6IqXWtrfrSxviyQ/Lai6pdT8ES4R4MLUwKsrW3387S7ERRHIdcj07BNqh35EFBh/s9qI/4THPZmC+NukSht+4TU0Vjz41wrX/k8Bia/kvwRfC1lR9jewJLN/Jzu2XAXd9l+eIL40CmOG6MYVgUnqvxDK6yjDcuIhaifw/7bXAIvnP5zVxTyFIbtJtxpBCIJAxkWGBx2oMQC6VMcQIkEyPzCfPoWnxxRJNbJWU7PJCrRdpfzkOiQhdWb7A== Received: from DS7P220CA0104.NAMP220.PROD.OUTLOOK.COM (2603:10b6:8:25d::19) by IA1PR12MB8588.namprd12.prod.outlook.com (2603:10b6:208:44f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 9 Jul 2026 01:42:08 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:8:25d:cafe::97) by DS7P220CA0104.outlook.office365.com (2603:10b6:8:25d::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.10 via Frontend Transport; Thu, 9 Jul 2026 01:42:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Thu, 9 Jul 2026 01:42:07 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 8 Jul 2026 18:41:59 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 8 Jul 2026 18:41:59 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Wed, 8 Jul 2026 18:41:58 -0700 Date: Wed, 8 Jul 2026 18:41:56 -0700 From: Nicolin Chen To: Ashish Mhetre CC: , , , , , , , Subject: Re: [PATCH v4 2/3] iommu/arm-smmu-v3: Detect Tegra264 erratum Message-ID: References: <20260609073204.1760077-1-amhetre@nvidia.com> <20260609073204.1760077-3-amhetre@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260609073204.1760077-3-amhetre@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|IA1PR12MB8588:EE_ X-MS-Office365-Filtering-Correlation-Id: aa6fad2d-7431-4a71-1515-08dedd5b495f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|23010399003|1800799024|6133799003|56012099006|11063799006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ajXzsSZAXB/VSyjTsrVTWIXSbWsPaLqgLRX6sLdXE0NTQ6A8UrUwJbDRy+oezOjlZtMhBLddB0M8jtCA1XckiUfVfAc4glkuMVm+C8ZUV/6GS6LVBB5rz0/WIU/53dkdT5rOl230nEZbXP7xRR2WkI3Ciam+aSBhYTvh0eJZ6Vi594wP2KI+DNoYdAZXHkcJBa4qBIIZ7NRaL7QI4Mv4thEx1f5JxJ/3Jm4DyUsvjINAnm1iIDds+X3gSOaiWlncIvtcYyHhvpHJzDpsb+uVKtHMHiWB7ET5MSPDBlvV8Gho9ioZFh26JEeSlJ6A2JMi2Sv7VwuY0fsOwhh34LktBAnhHCek9PAHRH0nj8nnHbbG4FHN+nbNJ9Il5HUewBbQ32kcY5Jd9lcZI7iTd/S/vr+j5EaJ6lPoCnEEPRKBcWy5Z/KVwiQu2HMz0cNnbh/iYMkmz8tCcByeQq4ExIog7J+zFyW06U6Mrei4Sjh57uFxL79uXssi+OuTHw+xRDkEWN+3y47T7X2qpWWhgb68oUwzpwxytgxTcU63+mqU/MLbfDKHg3fn2BlzCFREMQqewbypWmvxWw50IAklQgXk9TiJnWaddzJymAT5pxdCxlxpeKhR7qOXLjsIk5tEdKxN75TCvzyiljFEL9X+uNK2n/4M0DMruLXkzS3pSueaDGSoYbtoW2biOejVxq935sjsB5GlGLiXE087ySeM4jf4+Q== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(23010399003)(1800799024)(6133799003)(56012099006)(11063799006)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1YfOaFnyp0NOpjABo9d7NWOFYaGHiC5gPQnZ7NG5ObwMmK8M0H9hpFhv/Wt35WAusBSnp/IliQVph2kbRR2J+ytoCy/BFZHOdxEkhv1gHjAvBKrHcVBEOaYtF+OFWABWpoByHBdneLiIgX97SXZ4moXZP/SdtcgKapm6P2ORKs6ZxkjTlrej/boxEM2HT9NtGEaEOPXF639Tp2DLKlB0wrs853fv1MA34RLioC6Tan+15Sgpx6phfswn7vnqMoDEMS8kqXYi9g1Hqev0FQCRPx4QI4hAmGyfCu45SMJ3QAWkCQQHGrl5xElhd37FswjVqvke68yR3ne27jq0K+VBD+98H+1hBqfOTVtMbVResPGu2oQnVSmx4RfPDK2+KDsGRkch7PbFbGCSYRkv1G9DFqvawSVaUoZyMpYZXpwEWDXEM18YFeDbSPvD1Tx+hrNi X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2026 01:42:07.4595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa6fad2d-7431-4a71-1515-08dedd5b495f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8588 On Tue, Jun 09, 2026 at 07:32:03AM +0000, Ashish Mhetre wrote: > @@ -5303,8 +5305,11 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev, > if (of_dma_is_coherent(dev->of_node)) > smmu->features |= ARM_SMMU_FEAT_COHERENCY; > > - if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) > + if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) { > tegra_cmdqv_dt_probe(dev->of_node, smmu); > + smmu->options |= ARM_SMMU_OPT_REPEAT_TLBI_CFGI; > + static_branch_enable(&arm_smmu_erratum_repeat_tlbi_cfgi_key); > + } This would be nicer to be the last part of the series. Since we need a respin, I would change the order a bit: patch-1 factor a helper for force_sync patch-2 define a static key and its WAR functions patch-3 detect per compatible string and set the key Nicolin