From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48D3B404BDD for ; Thu, 9 Jul 2026 10:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593159; cv=none; b=naTErVO6VvL5Mtj9m4WH8mYEJguGjvHr7eGFPvngL3OXYKl4TdJzjz2HKzgtgZme+yZam7Lp0qHZo2ofxg8SW4tbRsFF2T00sjGNQRBNWoNS6Pw149IDuh2o89Cbf7HD6uRD/SNTA2N19q59wccJf1ptOG9F4ZN5OcGonAcLdhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593159; c=relaxed/simple; bh=hhoTDi4cE8nBlTydhCg8xgeJgn85ch/Nua+FrdtzYVg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bAUJcBzKzWKsSjaiCBL/CG2t99FF1IEckCXvzISDR7ND1gcthGMIsMnFgGjAfhG1lWcRmYCSfzq0yR4dEECJxZpujs2ysgKLZgIZ38kJNUDOAdgG1E9Fcwyu84Q3SHUVR3jlQrpDXOIQTJyIDq8FB1wUmuTuGWl7X9I+hbSwx7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=er7/5bzj; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="er7/5bzj" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7e9f69eeb6cso946083a34.1 for ; Thu, 09 Jul 2026 03:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783593157; x=1784197957; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tnOfuF8AUfrsPAGPhFNYnroM0tYE5o0tbrD/pBbOhls=; b=er7/5bzjHqGgCZregc1XNr2SmRmE5gg8klgEaQFFKAunGBrXTY6kX+oYm+oVcx/+Mv dXRXr2sI7ivAkC95jSdJdIitHyQdmI6NxorW67KMWDb9Qepe0tzH9Uf8o2ggUGhsqDX1 ySqL8lYfdaPenf/PlYDXbNm6WnIsL9e3SvA5oYQ7oMjZkvF0xL+QLt0ZczMqZD9RFCp5 8u6Lkgh5cUcCxKjp5xKnOJJqh4boOtekVceIgHkaenx50VUlvAgfsATbHZjdu8gruCUu kiRrAQ0+fDkkrbQdG9TUtHg6VA320M7hlL+JCGPJEYQYgXnrB7Oa6slOisaU8Fcs72oc 0yBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783593157; x=1784197957; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tnOfuF8AUfrsPAGPhFNYnroM0tYE5o0tbrD/pBbOhls=; b=DftrdLU+TXVW4KNx1EYS06jQfBuB6cNHyLialzGmzgraI8S+aA1Z82dtUzuVeZh8XU e6ws9hS/jz6Y79BiXzIGczIRcWs7UsDZsXdxSmfcG8QcGJNTU/sA0A0oWcUmD1GmYZHK DHiKqDW8pnJCFj4jgk/4YdpQ9aewFAI2ZtkNIxDCRXRSHnYhnKcrCfODEUkI3Yx/1jOW 71+1u51EpYzXQkubHNm4zT2TzJ4z+bk/hICMZGm2TJk8we5i9i8hR7vjFJj4p5ftrRr3 1FvrWD+CWQAFmo9oMS4ZR6PlvqlYtgkJGPUOlx3pi+cBkeZPGaqaX5l/agx78fIwoHbL xFuQ== X-Forwarded-Encrypted: i=1; AFNElJ8b3zWasKaMQcTVGingzMCxkDaIX32BbcGdgezOWda2aLPg+Ai65WLA9n+QqkY35wN5BlO5gb6V5R0uqDM=@vger.kernel.org X-Gm-Message-State: AOJu0YzRC71lCBCpwJuiaUcbnQzp9ATkUNYU3O/Y/fmmSvhKDvYZd324 l9ZJiYgmZkm5nf/7pgxzNPbHZoSJB0g+/Ii6VKTZkSGUEpsSH8y9GcY/ X-Gm-Gg: AfdE7cmX+Xuv9dlqn3Ry9H5cDC0jcEM4MryspEI2Keow9jGAWZXgYAMHlL8EeAckIx0 EPJgfdNZX7ho8+OxrFFGqVERJi/GIPQmlf0A1v417a57ibVOH/mDGbVgGW5LJv7zlrJuMmLltAE BtN7+UDHZMe/28N+Ffe3tFf2dyBAxrRxTYDSry5FEdeV4CYtYm8l2g4cUbhzteyjTbMKxGoH/N5 BUgRGFVnO65yJjsWBCEeew0A1/5+OKZhk5Z2vkUPeXBug6+WykRxdgJ8kERB24FMIdIFH0swPVX taoS5aObW2YI1tqkh6RkK3U3HJvdj6hu3Bpl/HYSozYcFQng7Fwl4lmnjvB4uKEAhoSk2zyhCvm cZETWHnJoD9tefEdrU05lX5jd0kv9/Hn8EUUTyNbj0rBSJ740sXkM+/fJw2riXSqYynhx6gvAN+ y7dnZXtkYLuJlFbvk= X-Received: by 2002:a05:6830:6609:b0:7e9:e9a0:9a8b with SMTP id 46e09a7af769-7ebcff5f37fmr5352948a34.16.1783593157222; Thu, 09 Jul 2026 03:32:37 -0700 (PDT) Received: from localhost ([74.80.182.70]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcae1ddb8sm3865286a34.6.2026.07.09.03.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 03:32:35 -0700 (PDT) Date: Thu, 9 Jul 2026 13:32:29 +0300 From: Dan Carpenter To: christian.taedcke@weidmueller.com Cc: Vinod Koul , Frank Li , christian.taedcke-oss@weidmueller.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: nbpfaxi: Fix setting channel irqs in probe() Message-ID: References: <20260702-upstreaming-nbpfaxi-v1-v2-1-e6d6b178a278@weidmueller.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702-upstreaming-nbpfaxi-v1-v2-1-e6d6b178a278@weidmueller.com> On Thu, Jul 02, 2026 at 05:28:03PM +0200, Christian Taedcke via B4 Relay wrote: > diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c > index 05d7321629cc..bcfab62a71d7 100644 > --- a/drivers/dma/nbpfaxi.c > +++ b/drivers/dma/nbpfaxi.c > @@ -1374,14 +1374,12 @@ static int nbpf_probe(struct platform_device *pdev) > if (irqs == num_channels + 1) { > struct nbpf_channel *chan; > > - for (i = 0, chan = nbpf->chan; i < num_channels; > - i++, chan++) { > + for (i = 0, chan = nbpf->chan; i < irqs; i++) { > /* Skip the error IRQ */ > if (irqbuf[i] == eirq) > - i++; > - if (i >= ARRAY_SIZE(irqbuf)) > - return -EINVAL; > + continue; > chan->irq = irqbuf[i]; > + chan++; If we don't hit the continue then this could still corrupt memory. regards, dan carpenter