From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62D940B6FB for ; Thu, 9 Jul 2026 10:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783594360; cv=none; b=tOSw6BgnhgFV+YSNfKDNmp1FlYyv9YRgBABX0UTL/1YbvpZBCpx2JczjqAEvw09xVjVLBK9zA5svhmXy6iSjsTy1kZS7W7ulja+CGQQfNYJn9JnOnonrnCxLLa+HZaLhmgMdEJnLlvuDnG3BBRMIsL32Zrtbx44uXII1j98XX5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783594360; c=relaxed/simple; bh=tT+rsXtyCwdK9hnBUqWrLDMFJQTbKewUwmQ5pI7i0gw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LxxieQdIOLIJPLeEd7ga6nN6YzJJI3yj234mnZoe4vWGNg99+Vg1qLt0TENjzr4F09RqGs5l0fY+XKEQvg4QbYP5rKtdTrTwhDRKUN7uGALiI8Yl1lW+5EZwnKyVmZZweLtz3V9nFKZ7V7FeCErxpmsCrDvsm1cg2QeKV26XPoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k4kBJYXJ; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k4kBJYXJ" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6a31efdda0bso451351eaf.0 for ; Thu, 09 Jul 2026 03:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783594355; x=1784199155; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QG9Jt3raC9zxX2MSD3KhQhG4RBmV8v+5QIW1bbTsOTs=; b=k4kBJYXJ5myAVWNu43HcfR1nQJqQNSDj5bLAImSqRthIVv950ZRa7UU3AKMS3EWgSZ 5/Xu2v49A69iaAlnqtApjLM8zTJKvTyPTfC1YTOrjj7wddpRbJ5a15POwvs0z5JcJCHl di/EOxCR0TpGWzl81sPtQyPYvMwCOuAG3E3zNAvkLaNau269Dg+EXCXIWxrmfYZvGZY/ x/5rrEeJpdXbW/zp63KqxeEOuaA6W6KeWt8kwZuRxXTJxHFfRC300SPPzwfpC8i2Fpk6 EcjHtnvSLiCmeGY4/gsJkKcNFUlOICHeJpXpDXG9oieX+rMph6ljEsvLn3gBRe3j8j4R 8Xzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783594355; x=1784199155; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QG9Jt3raC9zxX2MSD3KhQhG4RBmV8v+5QIW1bbTsOTs=; b=J8OEEtlSVfvG99ja8k6LkSJmFmdXbYII3Q/cXqXUaRiqvi0k5RDVzmyQw6TTm8XKvM FkmPS79CNNiaE6blGmR9DioJBEA7f/fGqOQ3VkYjTnx9nCcqUD1IXPvaFVVAUiYls7Ny A4miKocB37mJO/Lq0QbG/76y0P4Zjkk76iFFCMDbIStA44umJqa47T572HQELlvpUok6 6HhlC5+QSGAyvyVfv3mKrT/tl9+q8PnS4DnU370KOfGTbRmRAaBXVQYez72tovF6Mjzx 6AoypdRptmtTTCaU6Se+QHtgBLXPCJJaT17QyRy7KQN14Coq0PebR3bnE5yXuWrYlBQ7 MmIA== X-Forwarded-Encrypted: i=1; AFNElJ+uJ/lBuH/jy2Sst6peVGEIOBG67Xp32E2CsDQyGY+OjqrD+qrkgc7k45KD2Kn64jacGYgbTqhLB9q/1GU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLyVLrGoOmceVfpXKqAIbAKhIwEva17DBzn5ILuOdxDVhxJqs+ XrjrumKm+Gt/6fu04lpzAjnPiJPRmmYKk40lYxzQoxq6kYkXwRzpP5h+ X-Gm-Gg: AfdE7ckG/Eg3KIoDBA3Vvxqtt7RCyQSB2ymwlgIF1bUfvJvuFJ6e+9UnZEL6zgbplzU hvvgSu8F1sHVYriuFuZQss6rEX2LToFSNqe5akp7qOe+byLsrZkavyP8EaxKP3LV5RlE9nXq99C nafxSpGbt70ptWeDauRGTik+6mTakbyD+6l4tpvmH0NXB37+zbL9SVzv8nRWZ+OuLtcksf7Ngqz o85yS/H/lcglJnoT9Yj128Ho64jwTf5OCmWloi5rJOoIAqRHHcohnh9nz1TL4uWY93AW/vNcO9g Wfp1Wkoyc1ZiAML3+xaDoVTMhxn/ch1fXRj5qenvBBqxeCPz6fJSs8j6FRlsBg3xWjVLMdP3/ob 3zADKg07JlOfp0TT7UEuhL1mHmPntrOtkOm8vEipVt/s0TDBeczauT9xo+/Ztm15NQBbnb/hIPf Wg4Vpb X-Received: by 2002:a05:6820:1ca8:b0:6a3:68f8:69e5 with SMTP id 006d021491bc7-6a37d88343amr1884175eaf.13.1783594355599; Thu, 09 Jul 2026 03:52:35 -0700 (PDT) Received: from localhost ([74.80.182.70]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4519124d07dsm1652855fac.2.2026.07.09.03.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 03:52:34 -0700 (PDT) Date: Thu, 9 Jul 2026 13:52:28 +0300 From: Dan Carpenter To: Hao-Qun Huang Cc: Greg Kroah-Hartman , Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] staging: greybus: hid: fix SET_REPORT return value Message-ID: References: <20260704081613.434445-1-alvinhuang0603@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260704081613.434445-1-alvinhuang0603@gmail.com> On Sat, Jul 04, 2026 at 04:16:13PM +0800, Hao-Qun Huang wrote: > __gb_hid_output_raw_report() stores the result of gb_hid_set_report() > in ret and even adjusts it to account for the report ID byte, but then > always returns 0. > > This hides Greybus transport errors from HID_REQ_SET_REPORT callers, > and makes hidraw report zero bytes written to user space on success, > although hid_hw_raw_request() is expected to return the number of > bytes transferred or a negative errno. The sibling GET_REPORT path, > __gb_hid_get_raw_report(), already follows this convention. > > Return ret like the other HID transport drivers do. > > Fixes: 96eab779e198 ("greybus: hid: add HID class driver") > Cc: stable@vger.kernel.org > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Hao-Qun Huang > --- These kinds of changes require testing. How have you tested this change? regards, dan carpenter