From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B66834071E6 for ; Thu, 9 Jul 2026 10:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591679; cv=none; b=uGzakaMXs6zlO27j0CytOwZMPPnPX3mDH/Nwd59XnaXGD9gPDzYV7BJ50Zrblj5ICoz0GffUMuEGPpyyZAGAl+H/r2YBT/tpGpk5GwgkDws1WmGQxcdYEIY1eAD6eHsGdKZhxd0OIfnRzQ6LubWpZQCEw38iuZI9KdcXOk1EXIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591679; c=relaxed/simple; bh=gDwGo8DP/0imjy26nD3R6LYtAXIxD222lR1V6wozdGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jH7gKMGdsiaN+4R2X/rHr/N0EnkxFIHjsAHBK2KkCurpgy7ahgrXYis1gKM2jrY+nvZPUN3tGD0rorzYAZABP7Dcz3wIFGQIZagvD6DnTAVrC5aR4AkaNEr8f3+MyKbuJJMpmA9tJ0FGj5f9hRiPZoAMmSiD25vZjmkloZfsTMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ez8buYJ4; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ez8buYJ4" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7e9f6b94a49so389847a34.3 for ; Thu, 09 Jul 2026 03:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783591677; x=1784196477; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DwCLb0ckE+tVbANtskaKFVxURqFo9s9DYGaLtVSy90c=; b=ez8buYJ4TWRETFhOhFit7a5WOgBguv9sHOnkvRMTTWK8TLL9WMUQqz1QNJ59dcyNAD Up0ZeRfvt/ePaHzDKj0cgaph1kxY0X9vOy2F8OJxEaVVtPN9Ie1DOzhsmuTiBe5iz6qZ JtpdecfkVMKGkm5jBCNDrpwdr+bK7rrRybsqTNHV5ywxDjj3AAfujI3/o7m9s9Ea49x6 7oFiDPPTHELzjzfRZ4S8kUupN8Hq8WMPmYsbFLu6fOD1n6CyJz3DgwXdUpUt5ia6XWsJ p20idzBYPvINF6g2dZjKvg/yf9/E1X9cEIK83HKZn01Byc1gcXMRiTWb6AgGXJwnPFYV PePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783591677; x=1784196477; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DwCLb0ckE+tVbANtskaKFVxURqFo9s9DYGaLtVSy90c=; b=YYlda879PBWNcTizjl1Iyz75u+UCtN9m8kUrXJu4CnMYr/+8wx722CjjNWDJy6pTMd 9gqdCMGMqQ/hkUtovtQObEI9pULwD8NPKXDO1Xic6MmvFvV1c7YQa06BxuVl2qFpcmU3 V2AitMqiPKiBwEA0e2kLB/044IMxPVKNNM7Xgq0UzZJoOWhefHI+6IcEIAeKfRlFLr9h 0o5eToY6tpnDkPmbwbeFI0uxWFJbe6ZEy0qG5njYsXyEBB4vILxX8d/MbA7dWAKZ+s04 Grwh7jGIv97VupCVl5Wf4Pw3H2oH3pd2+Zx3m74DchPmCXNECs8MmB13GIrPoX549P14 uu3w== X-Forwarded-Encrypted: i=1; AFNElJ8r7+sguaVrggNQVhWmUNTg+mzcN5dtWQNxoEuYYBjA2ipaKFN0Jv7FV28TjBprbDR4+DHmFIiHzZzNSiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8Jvb796bqFr6V4uH60MbP1FFJlZb6aL3SRe3GhfOJNH1C7K2K Mjn3PWDzTk5cnR84NCPXzf1uR9ieIbHHudDB1zhK7jgqOM3ZrF4l4HzS X-Gm-Gg: AfdE7cnrCUwPaTWQeu2kd0JMASrNYrhS27otKzB8Vk9GXbAKvhJVQaFuuwcxbeYxPLT ydwhcnD97TT/hLaCClR9elGI/XganD76MXchZzYnVq3DOPC2+W7wGUeumoJSrQmwu1ss5b5Z0vz LuD63KaZTRRJX19wRj6fpYt1AoXkSOH8wRfscEsBPnj644NVnuYp+1T5esFEk2ob/37+wEHuOZ+ FzEwbzbV4tPiZgJKzukRt+1IO7bL84bJQdai5Anc7mCyGmC8F/Du2P7+i7e5oeK+hrwCOLqb9BB 39Y95/VLEMF+Nvyj6elbPqfh1FRMd0pC8tVfQaROHMbbpvSEoDnY8d99bAS8Tgwy162w6gPa29w KU640iszmqDxqSWbTR6s1i4AZ90I2dA0r0iua1au+08rueqCNH/d4hRfjTioG6fQTBhd2ONhh+b daQPU0 X-Received: by 2002:a05:6830:6d2d:b0:7e9:f8e8:d8fe with SMTP id 46e09a7af769-7ebcffcb5a2mr5065564a34.24.1783591676690; Thu, 09 Jul 2026 03:07:56 -0700 (PDT) Received: from localhost ([74.80.182.70]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcae177c5sm3879123a34.5.2026.07.09.03.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 03:07:55 -0700 (PDT) Date: Thu, 9 Jul 2026 13:07:48 +0300 From: Dan Carpenter To: phucduc.bui@gmail.com Cc: Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com, Kees Cook , Cen Zhang , Len Bao , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check Message-ID: References: <20260702050236.30751-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 09, 2026 at 01:00:55PM +0300, Dan Carpenter wrote: > On Thu, Jul 02, 2026 at 12:02:36PM +0700, phucduc.bui@gmail.com wrote: > > From: bui duc phuc > > > > nonseekable_open() always returns 0, so the error check is unnecessary. > > Remove the dead error handling path. > > The idea is that it might return errors in the future. > Actually the comments on nonseekable_open() say there is no need to check. That would have been useful information to add in the commit message... > Also the patch is kind of sloppy... The sloppiness was fixed in v2. It's weird that there were no review comments on lore for this patch. Are people sending private reviews now? regards, dan carpenter