From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458AB2E7657 for ; Mon, 29 Jun 2026 06:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714853; cv=none; b=T+Lw/whnJSSlNnxqIkkgFmflIV8ULuylpqbsW6GO1Oq9z70geEgu6SGGK9NUyF4NYx6XDbiIVOcn5womAtCCU+Tn4rQop6ekFfDwQTlznJOJi3ABUNnvv4gcZlMnrzVDrw85qSJk/2I8dfTFBEFJl0U1RNZJt8EpbXojdAnSHh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714853; c=relaxed/simple; bh=VhRTQ8FqFqIhV14nNEqakbGwjGePfDpH5VBKDIP01OQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=UQcBT9GYck95JNs4qwnSv2v7I1B2k9HiHWIK1QBKEikmLdRDR7qEdT4cqwNTvgnVt9RiT5KGMryc+DLVUi8s70vNcqGikc2bkifJv/B4uH0kJWhn/wn1KN2SMvTGMPCnPJA1AOB4Mm7w6GHYoL/S3qt/hnNpCCNNJyYAKigJjgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hR6tOKKb; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hR6tOKKb" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-46cbe01d4b6so1633234f8f.2 for ; Sun, 28 Jun 2026 23:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782714851; x=1783319651; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=deDbtmrhTXIdh4Sf08VPUmvpFowe+xk92+r1s9mAVGU=; b=hR6tOKKbQS6BKmHavQar7rRd0t9HKW3XDQWoKb9bYprUGMKxv7G15mxt2ERYlmRmvU e7Wfdub4Nm4Duq5dZO1d44zkmjjixVbWKuZ/edtJS5vsi6fJaE35G2AK17kuZLXlCYbe XGby1DSo5nX91f4nF2Zqk5afojRwCrd24adJiaOAvzQ4q9nTjLNadj0D6p7Zl3vDAVxa zTGQ2cyJg1Kdt06ZNb76i+E5fmUtbEN33DErNTN8cwQrgB8p9NvjcvmZIYlrPzIpSuor sEqAuKdJnJxniyE5XeIHlK92V4d8nZRCOBy8wC0I9y24ASncQkRsY/5cuNd0FDLzBjQr KCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782714851; x=1783319651; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=deDbtmrhTXIdh4Sf08VPUmvpFowe+xk92+r1s9mAVGU=; b=kI0Ejt2phkPThh9eM1x1nbO8pJfFgmbtqZrtTrngMBFbscw23sciGrJ6Y3x2ZadbBh /TEf1DMnwmDROcev6zuPP/7QLl1t3Ag/DURg7CDz80lBQKmDtgRG9/fvZCXPVWv1FSuI LYGsVfF8L58DTSAw5jY/d9Ottl0OkAySa6G5TaA9W5PioFhoZUbhWeVfJgbUkAcDq50X jDimePbnV9NMO672upRwLfzR608sn+QdlBf0AdAFuoFqNQVTEWFg8zYmWm3iXNaW1r2I 2M2AyXbMziMEjCBih2wOJh/sehPCrAABwdqIF1UTC/658Em5nQ5OUO2Xy69NMRC3HV9x PF0g== X-Forwarded-Encrypted: i=1; AFNElJ9SFexxJK+6rKlLYR4GWiSfQo34vfD6uruzRtj4cn4evRBHXd6AlbjBqhX67GE8X+Hs+Mv6dzbWSB2mu2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7e7rxcDPsuJzvcijJKgJCdU+0ab1Iw6ka3cLKWt6FGLfyQNaf YX2X+kDbt6PcaBG22CkTJPsrJO24+TUpYOoyrfsw7bplclqkZ5xpleAR X-Gm-Gg: AfdE7ckiO2Dw13E55MDBEc70y6yEOtAfYdnXA3EygNVjJUqbDhAQPKyJkzpER/hA2I9 REm8CgEeIT5z7tuqvvegSLs80h+O+Bmjg9rkKaTXgmJsxH/T+YjUZqHZy7JJilBFG8Svxuiy5lo lGNd7W3WDsFphIj+u3Rkyh2gfc/E4EbnCDIuBmP6nSldq0meoEUUJxHmfQZ+GAnTaxPnPgdrEs6 miWw1KMKgfr5VHnpEJN8/E1NsgjV9ImirYu6hTknAWw7C+FiPtMGG3YnreDZXrS6ghd+co8FVpB p1jWtjyYBzAAP/VHJvWRa9sNy9qmKaK6IoJsZCJimnu0aP4XnE/TxiQT0UbRXUpxplBtO2DlZhn a4y4WoPhimPX5NKIp6LggVvXsQ3o4vV1KW+h7Bg820rb1SQ/EHvAjGhdBuQ5CQDFDXX0YvJ34WS YbbJses/5XlA== X-Received: by 2002:a05:600c:3f16:b0:493:a5f9:d341 with SMTP id 5b1f17b1804b1-493a5f9d611mr70376585e9.15.1782714850503; Sun, 28 Jun 2026 23:34:10 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:9cf4:43df:e612:817b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49271c1bb11sm186749385e9.4.2026.06.28.23.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 23:34:09 -0700 (PDT) Date: Mon, 29 Jun 2026 09:34:05 +0300 From: Dan Carpenter To: Zack Rusin Cc: Broadcom internal kernel review list , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Martin Krastev , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/vmwgfx: Fix NULL vs error pointer bug in vmw_prime_import_sg_table() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The vmw_prime_import_sg_table() function is expected to return error pointers on error and not NULL. Otherwise it leads to a NULL dereference in the caller drm_gem_prime_import_dev(). Change the NULL to ERR_PTR(-ENOMEM). Fixes: b32233acceff ("drm/vmwgfx: Fix prime import/export") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c index 39f8c46550c2..f25db04f8777 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c @@ -184,7 +184,7 @@ struct drm_gem_object *vmw_prime_import_sg_table(struct drm_device *dev, { int ret; struct vmw_private *dev_priv = vmw_priv(dev); - struct drm_gem_object *gem = NULL; + struct drm_gem_object *gem = ERR_PTR(-ENOMEM); struct vmw_bo *vbo; struct vmw_bo_params params = { .domain = (dev_priv->has_mob) ? VMW_BO_DOMAIN_SYS : VMW_BO_DOMAIN_VRAM, -- 2.53.0