From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F85734C83C for ; Mon, 29 Jun 2026 07:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782719162; cv=none; b=QD2//qWH4I6+ehHNywkK1vNsJGnKeQJbsgFNRRpZWmiHfScDItOnzUPmcQ+Er2z7+EcmVaZZr16diOtHhmvkc12flW+OjqXZ1VOD0R8tInM0U3L+x0fgYj3mnncKNvgQAwgb4+mgvX7M2YQRJXfb9MXh32/GWZwCRUgC1ehAtGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782719162; c=relaxed/simple; bh=9CUaYRcAaHQtDdIPed7PnMp/ErjQVUI/rOmFTiUhSiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tTnnl9jA/LL1LAsjkqWP2X1yx+N0kMQDupkdYilTbLFDETjazlKX0e1uuD/otsI7lxoLG0noyd4mzBWXu4KhCL5k7SOQXQnEZtGxqtrR7tqtFGDYEVLmLcuAB8oT1OI5aB3o0OCxguHVVOvVKm4z0dU+bjcexFDyj2KVDoAx4g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BtGkibzv; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BtGkibzv" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4720d22c94aso1067760f8f.1 for ; Mon, 29 Jun 2026 00:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782719155; x=1783323955; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MNwr6uPHxUKpGJAyNPQ8nhfoGztkDSccNjDWDuCDYb0=; b=BtGkibzvhue1S2ZPkWvJnqXqSQ1ox4cGbf0mUWuC/2E0gcdnwdeN+7JZHonjcDHSph FNpj7tOYPcIuVxWv82lDcGJuSkoF9zHvk3S5zw6yJhUiGN3mtpxbQbuvkmRtxzYaWMX9 /b9WinMl1M9Nih7iEHG9mqFEm9nNcIjaLEtTxFrskD5OX1795mtiJrDC5OND+kJzN5hY 8mY09LQK9yX6HVAkrc6/o5d9ZX9WfZFJ2A+i7MkjBwcfaxbTB3E4FvCYAnjxn7Ba9U4Z a6Ok21YLAwkQLbfsR9aWeTWF1/9UezvvRNaPdI3JJfXQ4Z4YjFedow6iOuwGBn33TlCv t1dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782719155; x=1783323955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MNwr6uPHxUKpGJAyNPQ8nhfoGztkDSccNjDWDuCDYb0=; b=l6WHrkD0O7xNp4V3w6zq1Fe+K/P37iXaZz5wWZf/8ISFe06zUxo8pg45WL5YvM1SbJ IwzqgantllHZK1XmIeoHWcTs9zRHxYWD6UphiU1MSXaiFCqONPyNLn1wyWXyq5B2GrRa ePaU08blmSE3q6zP6ISkEYKJUtMd/L1EJ/mrRlY0axS1OmgqX9GpCGwuApH1tCE+gqAO pxC0NL3tlj+gXCeGfU8Kuw8glODVbByBhm//waWkOs2kTF0VLklortsasCBW+bj1mPvi g04+F9x/AXU+23uhYXjA6Yev6x3KWbIqdE8z9TLF+4bzCseUr62woSPiwmL5vEsnCdZX Jg/g== X-Forwarded-Encrypted: i=1; AFNElJ978hUBX+MnX3yv7n8jonNR+zfVb48AFLqBlsNSH51OQPSwzKf67enwqKu4dorKj1A+PRlvtkuDEsJbfBE=@vger.kernel.org X-Gm-Message-State: AOJu0YwnxMZqBtmY0hdUJQfvHg6kdm4kYsWhD4KQ/UCXbabkSXa96cMG /fnC7JYOFSs0RlA4M/gGCwhTkFjahhSxLGYxnBozq/BIiVYIZbSc4qpX X-Gm-Gg: AfdE7ckuG0Ccf2k41srtYz0VMAvGxL1xhsY9bhAoFdhR7SrIQqEgsLOOkr1AR3FoaeJ 9TJRdnTP9P7LrXlx8qZfzMNAnO88cR6C6+AJFIr9tWqB82tzbDv8/9kAOg/p3PPKw6q2RcS6+pK BKs45bdoncwE3TlAoDQ8+L4jEiit3xo9/y/qEG9XDHunkv8BQ1466vshGnFT//ObWjYDa2p39mC CPHk99sTLGM+p5Mjs2lVfpwgYdqJfdCHNK0NcZsjW608vsyr674fN5NhglacLljGFEZe2XtDMa+ /nh5zWJIWGc0pAdsuftzKjyPIxyLoEZrhFZBGonDthynnHL+cN/ZKVWYR9YB9kJOPuZULq+rkW0 0fj6z9UM42m2mQcz6wlmT3zndaVb1FZPu/9xKndhrCt3eCnS8OFHcd72eryDtxNPByDl/BV7xOz 0zQdW84nUDxA== X-Received: by 2002:a05:600c:1f91:b0:490:abef:dae6 with SMTP id 5b1f17b1804b1-492668857d3mr228322085e9.19.1782719155130; Mon, 29 Jun 2026 00:45:55 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:9cf4:43df:e612:817b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-473b98814fbsm7499082f8f.32.2026.06.29.00.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 00:45:54 -0700 (PDT) Date: Mon, 29 Jun 2026 10:45:50 +0300 From: Dan Carpenter To: Prashant Rahul Cc: Greg Kroah-Hartman , Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: octeon: factor out device removal into a helper Message-ID: References: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> <20260628-staging-driver-octeon-panic-v1-1-fe8c34989254@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260628-staging-driver-octeon-panic-v1-1-fe8c34989254@gmail.com> On Sun, Jun 28, 2026 at 12:31:24PM +0530, Prashant Rahul wrote: > Factor out the common device removal sequence into a helper in > preparation for adding cleanup to the probe error path. > > Signed-off-by: Prashant Rahul > --- > drivers/staging/octeon/ethernet.c | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index f3fa221f452e2..e07c6911b8252 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -104,6 +104,21 @@ struct net_device *cvm_oct_device[TOTAL_NUMBER_OF_PORTS]; > > u64 cvm_oct_tx_poll_interval; > > +static inline void cvm_oct_remove_device(int port) It's a minor thing, but don't mark functions as inline. The compiler just ignores it anyway so it's just noise. regards, dan carpenter