From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 176D0363C7F for ; Mon, 29 Jun 2026 11:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782730997; cv=none; b=fFPibPz/CvAUApiZHJzPaRAetnxv2R2gfH9wbKcHAzvGFbGyx/2LW+ypPeBJ6OAjTAe0/x8xzzrjgmKY5J35VNyN6nXxbbmuUtBT0Nt8kzFSGeP0brq+m5JuyhhMbAenlCEyV/mxMHzGpYxiSXe/UQBttGoKM4pjw+0TwFI7IiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782730997; c=relaxed/simple; bh=rxJWyuhBTRSB/O+mauv2DdL+vehSsvLqh+VLsRPp7dA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ja3UkZARRtl/yDsL5t6k2uUccmTtEHu0PFq/QwgYezSCV5zd4y9sBgyfotkr5YsIiAgsASubO++gxdxMYWm+4Fhx7YH5FsZH4CwtCh0GbYw8xhaLuVQCWi936x7MCBtEu7T981WmgVSZVmd4QwELlYQhrSp4Pv5oxL3YDIml9VM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hovgqjww; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tiMfI7RD; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hovgqjww"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tiMfI7RD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782730995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5QKyV/U/ktAcTR9z7ikOTnCGUhOOpuAU9kKgERdXtwk=; b=hovgqjwwr6n1YDCWkqaZkxzoGo0lMsMbZcBUrECtUWGFJcJc57cYCzAmswvFPx37hocnrM QTu7pFu+A9Vt6SFHFZr/FYoUbhaSU0uEqRlWV0iC2x+G6HsDkBnIwbJUg69P0FsTyPIe3K KuMlw9v1WNJqtLv4+0NaEd1ZukLyR5s= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-03BqtYBkMuCxt7vGQVG8kw-1; Mon, 29 Jun 2026 07:03:13 -0400 X-MC-Unique: 03BqtYBkMuCxt7vGQVG8kw-1 X-Mimecast-MFC-AGG-ID: 03BqtYBkMuCxt7vGQVG8kw_1782730993 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92b0cfd4a7dso565549285a.2 for ; Mon, 29 Jun 2026 04:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782730993; x=1783335793; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5QKyV/U/ktAcTR9z7ikOTnCGUhOOpuAU9kKgERdXtwk=; b=tiMfI7RDiEYkd1nobvFpWcgl0KN+oO4oFg+LAeEEFhRyPT68dgBsBp81nrnRRL3Ylo /g9OyZqTW+7OxcIeWNkWZ1tjO7sUe4xOWNSqxuasSC/vgKpWBTzTvJVSrT5N26UfxgKM bXgTUGm1W5rj+U83q8O9zjKdGSySmA35LAGAWYiqpdJ5EX5tg/4P97Uydo+mCfked8Z1 Wy74npOmLNklr6mVjZU9zaLRohY7rvbWKTSQf72VioRIEzUH6MQCm0MWuHd6NozWMW37 cNsZh1Kddrl9jaavjoBltCLeopn71UiPrkLhpxUXOR1YCpgrYrHX0Da8FauM6hdJ4t5M 7WMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782730993; x=1783335793; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5QKyV/U/ktAcTR9z7ikOTnCGUhOOpuAU9kKgERdXtwk=; b=pesFrNOdIZuwnnYAOGwACExaPMcUTUa7Gii6O0AJ58XuN1KRXoMk0Jf+j4F5waZW90 2nttiYnLet8qYM/C8QCYzznKwy7xj3YyindrHGexU8LDJ57xIuE+49Nm70obT9UQyJrD BM7Wk5wDeM2gFvQG16t+2XdUGAIKzd9fSuvM037AykkbH2dsuSYSjAb3znfx/6R+PtX+ v2SfvBIiXFYD+mQ2+pmtdbB0XmYT4djYGcg5BwI+cKndNpHmHKcun2g6hUxEXpYWEh35 AqN59N/5VqI8ssky5pAit6F1AwFK9J4FokmTC4HYxixht6Vi92efm0VRgf4l2fKHxGxb K3Fw== X-Forwarded-Encrypted: i=1; AFNElJ9mNAOWVDXFFJMyl2utMaosHOvvfd+YX/wKJS8X03R14VOm8pZBqxUxEdWy7VelKmpBbxWmTyKrN+gIYug=@vger.kernel.org X-Gm-Message-State: AOJu0YwUCzCxsUrwWeca+o56Wn0CY2nDs/NFpEmaV87i36wS58uWgxaf xj1qcU/8VHfdyXJD+ITa1mpuY2KIAoBKOJC9aKoOHsvRGmuYBQTt9E+TbV7WM00fWYU4cUTFScV 9B3FXvKcHLpSVmfBnIYpJfywe47GXBufob0m+LoCp1VycPeFGFnJkxPHDe7S38mXIYA== X-Gm-Gg: AfdE7clXDEwL9yzkC5mmib7QCCe390ftd7nmgO1Bh+LlvemEcnPgeM+uq3NADliQFTl dNqm7nMdhL8/PxQhLZlCOY4oNoVOZdLOcBWYTpGTkKU6Q7ELussbDbHlrtBNnitnTP7WjMeWjjG ZwNHFS6IdHIdxKP+32rZrDNBBuSglKX6MfvlwFn9kkQrhk7TybMyWUdELd0JN0+FDg42dxHnh1V dUccvz19VH42VFvRyPTRXqrRdBASm3ZP0L5pPkT8U+pRE2KpnaRiyGy9BjL6+HB21fVzJ95GPKY 2kFfPOx5gNZUFhoyuqOIcutEu2kTdZoNpifUVdj4q65zdoI9CAykLV3sTaCfD5Iw1p4sZo8vRlW ikJ6+eXLoAn4cia3XwnAXf41ax/3Diq3uSY+RoQ2DmNsWSg== X-Received: by 2002:a05:620a:2552:b0:915:efa6:d718 with SMTP id af79cd13be357-9293cade740mr2654172985a.47.1782730992958; Mon, 29 Jun 2026 04:03:12 -0700 (PDT) X-Received: by 2002:a05:620a:2552:b0:915:efa6:d718 with SMTP id af79cd13be357-9293cade740mr2654160485a.47.1782730992022; Mon, 29 Jun 2026 04:03:12 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8df81cde21csm303262796d6.26.2026.06.29.04.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 04:03:10 -0700 (PDT) Date: Mon, 29 Jun 2026 07:03:09 -0400 From: Brian Masney To: Vladimir Zapolskiy Cc: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: enable ALWAYS_ON for titan_top_gdsc Message-ID: References: <20260626-camcc-sc8280xp-titan-top-v1-1-2ca246886493@redhat.com> <41a76941-2e21-49ce-b0cd-0ae6a8b2eb1f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41a76941-2e21-49ce-b0cd-0ae6a8b2eb1f@linaro.org> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Vladimir, On Fri, Jun 26, 2026 at 07:54:39PM +0300, Vladimir Zapolskiy wrote: > On 6/26/26 19:32, Konrad Dybcio wrote: > > On 6/26/26 6:26 PM, Brian Masney wrote: > > > With the introduction of sync_state support in the clk and pmdomain > > > subsystems, the following warning happens when the unused clocks are > > > shutdown in camcc-sc8280xp: > > > > Stuck at _on_ sounds wrong.. does clk_ignore_unused / removing > > the sync state from the clock part only resolve this? There may > > be a clock dependency for the TITAN_TOP_GDSC that we're failing to > > describe > > > > Let me remind that there is a series, which solves this problem in a proper > and elegant way, it would be nice to get the review tags though: > > [1] https://lore.kernel.org/linux-clk/20260331140142.892579-1-vladimir.zapolskiy@linaro.org As I mentioned in my other message, this series didn't address my issue. sc8280xp wasn't included in your series, so I had to make the following change in my tree: diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c index 18f5a3eb313e1..4724ea54c5f67 100644 --- a/drivers/clk/qcom/camcc-sc8280xp.c +++ b/drivers/clk/qcom/camcc-sc8280xp.c @@ -2995,6 +2995,7 @@ static const struct qcom_cc_desc camcc_sc8280xp_desc = { .num_resets = ARRAY_SIZE(camcc_sc8280xp_resets), .gdscs = camcc_sc8280xp_gdscs, .num_gdscs = ARRAY_SIZE(camcc_sc8280xp_gdscs), + .cc_gdsc = &titan_top_gdsc, }; static const struct of_device_id camcc_sc8280xp_match_table[] = { Brian