From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19182389473 for ; Mon, 29 Jun 2026 18:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782757764; cv=none; b=Fjelxv4Vrtj6rhk3/UvY3FMUG+zsPaxj7Pm27slWd2k4kudMEGNbU3wtgn0KrXDouVF4ompquw+fKVRbD56NawvGFK9EdagiscwHWJrzaxDeFRCPdFVI0Mr1EagDA/hTFDFgPnb5JR353N+yi9f/8PLWM1Wg+putw18LaC7Gics= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782757764; c=relaxed/simple; bh=hp4emrgPW1+9JiZgrAQPif9QEJd+0d/Y97D7puPOGGI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AFWk0qL/Ay7HcKpLqmmK2M2M5M2WPcGucSKO4PhNRG5pVp+IUvb4TAJjZ4P7QQWGxvDtCMCbncdgrQP60teOup0oGvKPJPZ2Gsx0JdU0Vq06uqpTpuRuABRCqLRHDa/Ybqs6lzklrBxI8HGzvNbamIRDOm5b5NIjz7C8Fgag5JQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WZ2n3yfQ; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WZ2n3yfQ" Date: Mon, 29 Jun 2026 11:28:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782757760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTW0XC8dEWZiwseOxkoyBChQncFjhrJXjY1B/hyy8Y0=; b=WZ2n3yfQsB7DAqunz7QrD8IzF/yt614EZi2fR064jPUt4e9EAcc3D0fbB5foVguLFClapW wDomh3rSE0EY0PDDI765Q6N5DIWs/kdrEOlBAl9NZeOvFRIQxvIhXSpUycwmJs9yKBWP8O Q47xDrZ41Cy1506mCfNsXUPNbhntU0I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Johannes Weiner Cc: Usama Arif , Andrew Morton , david@kernel.org, linux-mm@kvack.org, tj@kernel.org, mkoutny@suse.com, roman.gushchin@linux.dev, liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c Message-ID: References: <20260629130042.2649505-1-usama.arif@linux.dev> <20260629130042.2649505-3-usama.arif@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Mon, Jun 29, 2026 at 02:12:38PM -0400, Johannes Weiner wrote: > On Mon, Jun 29, 2026 at 06:23:58PM +0100, Usama Arif wrote: > > > > > > On 29/06/2026 17:48, Johannes Weiner wrote: > > > On Mon, Jun 29, 2026 at 05:59:37AM -0700, Usama Arif wrote: > > >> @@ -101,7 +101,7 @@ obj-$(CONFIG_DEVICE_MIGRATION) += migrate_device.o > > >> obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o khugepaged.o > > >> obj-$(CONFIG_PAGE_COUNTER) += page_counter.o > > >> obj-$(CONFIG_LIVEUPDATE_MEMFD) += memfd_luo.o > > >> -obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o > > >> +obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o vmpressure-v1.o > > > > > > Might as well move the interface part to memcontrol-v1.c instead of > > > creating a new file. > > > > > > > I think it would make it easier once we move cgroup v2 off of > > vmpressure. Then we can rename vmpressure-v1.c to just vmpressure.c > > and gate it to CONFIG_MEMCG_V1. The other option would be everything > > living in memcontrol-v1.c? > > Hm? I just mean move whatever you move into that new vmpressure-v1.c > into memcontrol-v1.c instead. > > > I think its nice to keep it separate as > > memcontrol-v1.c is already 2K+ lines and this is standalone feature > > that can sit in a separate file. > > It's all deprecated code with no active development. Containing it and > making it easy to see the footprint of the cgroup1 option is the > higher priority, more than maintaining neat component separation. > > No need to work it naturally into the file either - decls/variables up > top, functions somewhere further down etc. Just paste it into one > contiguous vmpressure block under memcg1_oom_finish(). That's how that > file is already structured with the other components in there. Yup, this makes sense.