From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 927E937C934 for ; Mon, 29 Jun 2026 15:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782747657; cv=none; b=XvACo5tV7QbICKZMQ7dgkGCG21sJ66m8fiB+kVQgHA+Ihzdp8aDBQgVbFgpw6kn7F9mJtYm044fePEZ813c3eD7G0lecXrJDOD0bGjLnqvbiQtuWxgQ3tHZpO2ZxmPOwKOlbrpb66Ob3wwMGmCHvS5FaNZrhjDTfwnFPFh3/Is4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782747657; c=relaxed/simple; bh=MNQAGoz+ALol9NKgyryDO7AijFzal2oIIYJVBa0fMPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gcDgtFgoQyrSwW2pJh8tgIqEKKRigSFTxoLXFCmLdPRXEdu6ECWw4jXehejC3n7ok/kuqeqBgw4BuwFyIRiG9ys/DYb6BJ4QZVGPMcaQ97+/POzrouLhLA7mVl1fdQwzMDa24zcK/i0UnetDwD16d5R4FNfYk4/Y43o0dLNKcpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=br2Yr/uU; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="br2Yr/uU" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-37fb434c547so1555229a91.0 for ; Mon, 29 Jun 2026 08:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782747654; x=1783352454; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9uvIhHDWUitzJSG00xb1K4ynHXiRoqOBFZ3s7K0F87w=; b=br2Yr/uURrtwbOg8COxnsdKoTmHpWGv/2eWgnlLQAS6ikyoYgcQpICv+waUo+ZCucI iT8jFw5AI0rqwKbYiRGexatJV+NMCZO1TpAye6GKCZQaZXC3Bb7uxrT1XHTbB14+XVQ5 DXH56xUJampR30ptS2AXkI0eox+24co13xcfgiQiwbiyUEcClVCE27cIJo5BWjDaq8SY 420lOrn7uuxb9b9yK8cCsxjH2B7hRnE2O6WWlSAbny+haUMb1wyqbws82occDuq7wflX 6JtkXLhn4AjnDhtDIv+/l1mrc9ohLycI/RQr2vrGxJVkDKGW2cvUMvGsqP+gyseM7mft HYcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782747654; x=1783352454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9uvIhHDWUitzJSG00xb1K4ynHXiRoqOBFZ3s7K0F87w=; b=JZbUCM57UkSD36uPnnptjk5groMJOMn1ffDCHld/dZHekfp4mxQAk+WYFXNYEaPECP uW3WMyEUmhFW8EXpe6y8uNvBV0ciHMqxyqA3009CElG9xlOmZ1yW4LSuyzDwenahIPH7 +WxAELfwLqwJUE/JfXObmFvhfctmcTEh3qDaA5itt0kbIcOCbFkE/fepc1vphIf8qzP6 b+k/sxlfCvJ8a2AEP0BECVRmna5YXD58nuVT77MRhBTftTHAJooCV8j4U8/yG/A8j7vu nw2YJnK3clpqYbbA1wONQkrXZm5u6m3DfMMiPxvNYMCrMfCNffTNB+Ho2o9iPTCxl1Y/ MXyQ== X-Forwarded-Encrypted: i=1; AHgh+Rruur1EtWp+920Laxi5C6FINSx9nzzONzqnAt4lJJEfJkOETSjjVeBi69ZbCTO+iXgq69a91kWI4t+TX+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1ZNCuag9iiX/niMQlShfWdIPvTq4KkH1k/PHuF6IxWchDOjjf QdgGkfQwPzlwDpNv/HJLBMTviQxZSzUoBZiwJCleZytq/WelkWowK7qENtNnyO4Z80HsuAVVN8e elo/4UNg= X-Gm-Gg: AfdE7clWzBBKJODoN5irNQH5W/nI6xAk2pIZPBRq86kpsxeBqfNv9QbpazeLx8K2j85 KOn12UBfk017jKjlp+nyOh/b5iLAaVvn6BYScC4fnM/yKyvI8+kqZO1dfFTYd3luIonWhKfEnDn 2PZm07+TOYALwfs3DkTOFuauj3ubtpXytjhd0f4Ie4Vk123xFRb1abH+0OGsFRlKCf1hNJbZ/ZG f5jE+cZk86jVUG/CbdDymwRKRD6M3REVcoH0vMJVMZ1gGCkrJLlqda9zFBZext+bu1ZLU8A78Ca EApJop5z4Df2Yc6qJ8y4bQ1dRwarWmk+kzwmE5Lx6/JN2Wzy378ZYJCuMa7v+KgrlmImrHbryZj QQefwQebbZqFZHU/dxRHVQru8azAhK+6K50gDVjValau5XJqiomap+2P9acAebqWhbZiYwKfLlU mHWp5nSxvnOoD5KbAJ X-Received: by 2002:a17:90b:5746:b0:36a:8240:2477 with SMTP id 98e67ed59e1d1-37dfa1ef948mr14589310a91.19.1782747653873; Mon, 29 Jun 2026 08:40:53 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:aa83:261a:68a7:9974]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37fa9629f8fsm5405003a91.8.2026.06.29.08.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 08:40:53 -0700 (PDT) Date: Mon, 29 Jun 2026 09:40:51 -0600 From: Mathieu Poirier To: "Rob Herring (Arm)" Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: Use presence checks for syscon props Message-ID: References: <20260612214959.1884404-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612214959.1884404-1-robh@kernel.org> On Fri, Jun 12, 2026 at 04:49:58PM -0500, Rob Herring (Arm) wrote: > The OMAP and Keystone remoteproc drivers only need to know whether > "ti,bootreg" and "ti,syscon-dev" are present before parsing them. > Reading those properties as booleans misrepresents their DT encoding. > > Use of_property_present() for the presence tests and keep the existing > phandle parsing for the actual property values. > > Assisted-by: Codex:gpt-5-5 > Signed-off-by: Rob Herring (Arm) > --- > drivers/remoteproc/keystone_remoteproc.c | 2 +- > drivers/remoteproc/omap_remoteproc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c > index e7fde5509786..83763d640c4e 100644 > --- a/drivers/remoteproc/keystone_remoteproc.c > +++ b/drivers/remoteproc/keystone_remoteproc.c > @@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev, > struct device_node *np = pdev->dev.of_node; > struct device *dev = &pdev->dev; > > - if (!of_property_read_bool(np, "ti,syscon-dev")) { > + if (!of_property_present(np, "ti,syscon-dev")) { > dev_err(dev, "ti,syscon-dev property is absent\n"); > return -EINVAL; > } > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > index cb01354248af..6ed0f28edac9 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev, > if (!data) > return -ENODEV; > > - if (!of_property_read_bool(np, "ti,bootreg")) > + if (!of_property_present(np, "ti,bootreg")) > return 0; > > oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data), > -- > 2.53.0 >