From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F76425CD8 for ; Mon, 29 Jun 2026 16:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782750275; cv=none; b=FkrM/H8xeXos2UNSldPkcuEj8rgIH+4DL+4PaAX5ynkmRcAlqL0gN6RZrUjxH/1SBr6izfTT4L3JiyvV0lLwMAbQfxJ0HT52SyjmNrX833Sd4poYSJolTbUGIXfCD1F5L+ljetFYSKDmDmHnd1ogI3iXyna1xgOZ3gNDoDAS6Q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782750275; c=relaxed/simple; bh=ySTaJdnZa62yhBnxOv6OcbAWc2ceyO8zhRkoDVDC8ig=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W2Y5dQLJakMK6YQyiqK/Ss2O++gx7fZJRPMV868nA2A324a2EPbra8IKM1ZFJsAB1dOCXAmLMrJU8LSyLGm0dkIqmyQbGri9x7XybHvYS9lDCeEa4a29oUfZCD5Wahpcf+kR589LLtO1T3sk+yrKa2mnAWPSmMQCFTf/8lbEnSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=G8/6HH5z; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G8/6HH5z" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c9b2ac97cdso61585ad.1 for ; Mon, 29 Jun 2026 09:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782750272; x=1783355072; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0iNSQseB1MUx/UyReLsxkuNDNXPWZeXUlBY5ARaf804=; b=G8/6HH5zW/j3X7EAMkwUfiPjgFnfuycMSuIIoyfykbgYXhWbepRMxm1nMXK1znxbwK zLXtBjvAhcs3HOuIlBgL8u1M/nCgydv9PBtrG0mBRhQWKSVQR+jV1J+lrZCURiCP8DI/ v83kzG4gi3CWn706j6c6TvWHynHWOIdeTD5gZXLV560bs6v9Gca28RF2OeDQqB8xI9gL OvmCVaCS9j0PjE4fyoJGv6JeX0g1InWSjNDaBohQs8Yfypb6JvZKeptnDHtErRLjiCDz JVrgBibanYh3Z1Bgr7nHSFzYugcjoayzriqUVzhVtedSY8r+G6HApeJnVwJduD599yNK KWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782750272; x=1783355072; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0iNSQseB1MUx/UyReLsxkuNDNXPWZeXUlBY5ARaf804=; b=lcNT7tVjnkj7oe94nr5qIEwsyntnGYVlxiL6Xr1vPDAht9GX9rBTMpguB7VJ98cyGo MXLCckCuaDQL8F6QxhkaDZSyHk03YDkWGuT16PZlLLq2JhgVBkr4v3kGyBiLr6kmCNW5 J4j1ExlnPEukproE/6n8Y6Dt9Jc125+Tm0l72H2RXLUVAG5ztvWVdQdZKbVh2xv7kyha 32Pw7AVoHfD/P8igs/rAXRjw84TnrieghQfEADtRMZLI3Jxbpap8QtUmVYv98PxWoMjD lmiMoPylKk5wv5wrVK/7GJdAWo314V6iHkwE0Nojkk5K6EBmgOzRvmJCWdwKgMmrVomF j8ew== X-Forwarded-Encrypted: i=1; AHgh+Rp3/YvsC8G9KoV28GshuAhad+ZLJJBda1Xir5fAiv3PgRUD52s2ZuvPT7mPEC9eCXPFMYDBfvpOR2PtaPk=@vger.kernel.org X-Gm-Message-State: AOJu0YybZoQ1rzZUwGW8ONAdRjjTHHIpyJAYBZWbToV1pLBrbgzXzIT7 sVUCBR1pOf38WCjkB7G5XtBTNgYnqnCl6bLegz680TnvMfUyu2qRSXeS3wC/0TmGEA== X-Gm-Gg: AfdE7clrbt4HPDlcC2pyyjIwgldIV20BojRAvJMYrD4uZMoLyUrIf3YKYcjvOPfm/4V 78/TrsxWmjzYoBc4/Li4qoK5ljI9KsqYjXe1WToJwkJuFvV2hi9OYDKQRrbKDkWcTYUFnVTEqKz nXHAF/tyi4UQwi6TL97+RvfkugMIs3yVB8xp2KkZZCLiD6sX603ISwrOAOnDnKK4zl+q3iAaROT wH9SK5dllQxJ1pvPILU+cw09WFaoPvlLDu1yqOwq/R/q0DeqcdTbRFo0FMWCFOQ5TansU8SrAbM 2rurH2uWqi9qSpc6aEgYKXP/bxD4Pu7CGvA7Hr6EHFGKc6l2ob0i6qJgUvhOIVzQXC1lXjJTIe9 4COXeaiqLY5gX5Xmu29jCoafvj7HYVK8BScnHCtXQbyMGHwxsXNwIhJBgEWVM6CXyk7SAAPB2A7 fpPTF9KdvHFc+YimulG7/M5FvDxjiwbTz1OcjjO0FAc8mfMEI= X-Received: by 2002:a17:902:cec8:b0:2c6:cbcb:bc72 with SMTP id d9443c01a7336-2ca2d062c01mr256175ad.23.1782750271674; Mon, 29 Jun 2026 09:24:31 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37eb013af70sm3876698a91.0.2026.06.29.09.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 09:24:30 -0700 (PDT) Date: Mon, 29 Jun 2026 16:24:24 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, jgg@nvidia.com, joro@8bytes.org, kees@kernel.org, baolu.lu@linux.intel.com, kevin.tian@intel.com, miko.lenczewski@arm.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, jamien@nvidia.com Subject: Re: [PATCH rc v6 5/7] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 20, 2026 at 10:03:22AM -0700, Nicolin Chen wrote: > When ARM_SMMU_OPT_KDUMP_ADOPT is detected, do not disable SMMUEN and skip > the CR1/CR2/STRTAB_BASE update sequence in arm_smmu_device_reset(). Those > register writes are all CONSTRAINED UNPREDICTABLE while CR0_SMMUEN==1, so > leaving them intact lets in-flight DMAs continue to be translated by the > adopted stream table. > > Initialize 'enables' to 0 so it can carry CR0_SMMUEN in kdump case. Then, > preserve that when enabling the command queue. > > Clear latched gerror bits if necessary. > > Fixes: b63b3439b856 ("iommu/arm-smmu-v3: Abort all transactions if SMMU is enabled in kdump kernel") > Cc: stable@vger.kernel.org # v6.12+ > Signed-off-by: Nicolin Chen > Reviewed-by: Kevin Tian Reviewed-by: Pranjal Shrivastava Thanks, Praan