The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: Usama Arif <usama.arif@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	david@kernel.org,  linux-mm@kvack.org, hannes@cmpxchg.org,
	tj@kernel.org, shakeel.butt@linux.dev,  roman.gushchin@linux.dev,
	liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org,
	 mhocko@suse.com, rppt@kernel.org, surenb@google.com,
	vbabka@kernel.org,  kernel-team@meta.com
Subject: Re: [PATCH v2 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c
Date: Mon, 29 Jun 2026 19:13:07 +0200	[thread overview]
Message-ID: <akKnaWhg5z7fI5CC@localhost.localdomain> (raw)
In-Reply-To: <fb9af391-b991-41fc-a105-7a3008860c07@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Mon, Jun 29, 2026 at 04:20:10PM +0100, Usama Arif <usama.arif@linux.dev> wrote:
> So what I mean is that I want to keep the effect of the patch that splits
> off v1 code as just that and not have the optimization of not running
> vmpressure for tree = true + cgroup v2.
> 
> vmpressure_v1_account_tree() compiles to an empty function in the split
> patch for cgroup v2, so if we make the splitting out v1 code as the first
> patch, the commit is not just going to split v1 code but also do the
> optimization of not running tree = true cgroup v2.
> 
> I hope it makes sense?

All clear now, it's clicked for me what is the optimization and what the
cleanup.

Thanks,
Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

  reply	other threads:[~2026-06-29 17:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 12:59 [PATCH v2 0/2] mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2 Usama Arif
2026-06-29 12:59 ` [PATCH v2 1/2] mm/vmpressure: skip tree=true accounting " Usama Arif
2026-06-29 16:46   ` Johannes Weiner
2026-06-29 12:59 ` [PATCH v2 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c Usama Arif
2026-06-29 13:34   ` Michal Koutný
2026-06-29 13:55     ` Usama Arif
2026-06-29 14:29       ` Michal Koutný
2026-06-29 15:20         ` Usama Arif
2026-06-29 17:13           ` Michal Koutný [this message]
2026-06-29 15:57   ` Shakeel Butt
2026-06-29 16:48   ` Johannes Weiner
2026-06-29 17:23     ` Usama Arif
2026-06-29 18:12       ` Johannes Weiner
2026-06-29 18:28         ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akKnaWhg5z7fI5CC@localhost.localdomain \
    --to=mkoutny@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox