From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAFF3803F2 for ; Mon, 29 Jun 2026 19:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782762044; cv=none; b=HO8otbGbIavpS3uZODJRThWgtSiqN2KHq2BKL9SYPk8mvnz6fRETaLT0ESJLv62ciKb6Ve/lp06E4sMAx4DoJXN1flIduufuBiyasnuQnqa91m4FzQaox4fG8Cc1F/50cC/Unfu0dwLoIpROkyXiqJXFprthzYFlzLon/bJzfl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782762044; c=relaxed/simple; bh=hnTiiRzl9G7eePzzIwjE22PBDOl75cM40NKb+PgReeY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XP75+W7FY3+4tNcG0Obv6cjWYuJMzoMrIBgq2C6z81VLq2Hwii70/V4bneuEZF+KLf1XKqnyhgZfxE8T0eqRa2x/Np5aFDrAgwNT2gPUXblOTTI6xexWbmZYjEQCMLbL6JsftISSuWXbtqZ8hCoxpSJiFRAoWZNM9SNsdprTKV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y5YtrWyp; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5YtrWyp" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7e9565cc13aso1128593a34.3 for ; Mon, 29 Jun 2026 12:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782762042; x=1783366842; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B5WmMKvjmzvyuGXbzKRG6hqivUgSDTWGVP+syryStGI=; b=Y5YtrWypdNsmTGOoeypgbId9DiGGA+zXtvMK2r7V2n9ANLkjKUhQ6ZJF5i0wKLP3qH roTPXgFqTB0MAmFB2ect9ZQhBLP9lsIuwRCVDExg0Hhzx2gDkInEYYRumBxH5e5n2O7s AXPRq7GLHmHG9hl+2TBa1lmvdQ0cCPHmguO0WY84sylCBWq826B5cgN04/M9QHaUumdT W9oPm9KUtNDUPwGu2tN3FfBnSn4uGYJdllBrDqOiKKogb69u1toXqXRUZZDGoGV8YtBR x6CfZq6DgPuBDLwPwyVlVi/Lc0LFAfC2VVMXifu4HA34lhrE5rXUh6Oa+IyJqk2xhQK2 bMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782762042; x=1783366842; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5WmMKvjmzvyuGXbzKRG6hqivUgSDTWGVP+syryStGI=; b=KdsNJUv+HJ9ZtDy9Wnb79kul+N+6QVa3ncdei0Os7dBDpzIasK7xWwyaaMChOh8/Dx ixUZzht5cLeA0QZiiJtoxC91ypE2Oa44618wutD2whopL73GRNAFpfAeAVVTxrwotLL6 0Qr84vUxvLhzz+eAjyRtDscHbysD4QYZAiqka9MvGioJ4YNPV7iNS3Qm30SAh/jHnvY0 eUgfpVsIvg9ks2U/KvOmWoO9AY8f9hJg15N21Ai8oP5C1EvCGm0ThN6qvL1Nvxlfj9AK 5fo94REkDkSRr7q3ovotZAe0bPqxSwLM4pPBdAA6VzoN1GczWlLZRltqfBozYx//orRo EEaQ== X-Forwarded-Encrypted: i=1; AFNElJ+bOT9xhuyqVxx0zmMdDDhzM12u5V+Jorp/Yaw9l4EtODdOfjY03QwTrCFmLAyDYtoz3wuNbY5YJBuDcso=@vger.kernel.org X-Gm-Message-State: AOJu0YxHSFSQBT+wE8I/vYUS4kFnupBX4LIBTxBoUGqubsczwZP0+Ajo 5LfprgYEcKCtjw85axES8Cy7p1VsajFcGXrBQHpvfEm5URl5tXZe9eJnORbznnd/EJU= X-Gm-Gg: AfdE7clI45UwWxR7+b9CxhNwhebVGxC5QFxvPuVeWgS9EaBzeb//FsfTgKmVn7K3SxL FHahTVSgUeDYpLuZGU/Hl/L6Cim6PTsIU+oNsYBBIwdRWwbxA+aZBR9xf0kcMWmRpAP/NGcKKXW LXwJ1Ooq66wkGBddKmQxuySTrFvS16cN3b0vp7U3bkvV8I1JqYVxNXYknIZYsTd287zWkyK19Ri /GSTzti5izyfegkLzjfYcyOoS7oMh1eIYHckueIQR8u4lihMz5Ffmg2j9wQrCGU2LLFFzGj4Ahp xJOG323eJKTsbj4la14ibrKfA1yiVSecnfQM5qQyEs6IZzKr/SxdxSdJ4SemmxPaljLW5vXHw7o bgNfTmWvZ/qjMzElu0q4LE7b/aDPvscEaVD/So3bSdZ/2e5fYmfHfCVe6BdIumceQg1CXwT1Yj3 6sKY3p6Rw= X-Received: by 2002:a05:6830:6e21:b0:7e9:ef39:1caf with SMTP id 46e09a7af769-7e9ef3925bcmr57606a34.16.1782762042018; Mon, 29 Jun 2026 12:40:42 -0700 (PDT) Received: from localhost ([45.136.154.250]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9ec2b8f03sm524966a34.13.2026.06.29.12.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 12:40:40 -0700 (PDT) Date: Mon, 29 Jun 2026 22:40:33 +0300 From: Dan Carpenter To: Prashant Rahul Cc: Greg Kroah-Hartman , Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: octeon: handle rx/tx initialization failures in probe Message-ID: References: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> <20260628-staging-driver-octeon-panic-v1-4-fe8c34989254@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 09:49:49PM +0530, Prashant Rahul wrote: > On Mon Jun 29, 2026 at 1:14 PM IST, Dan Carpenter wrote: > > cvmx_pko_shutdown() has a built in call to > > cvmx_pko_disable() so why are we calling that separately? > > Didn't realize cvmx_pko_shutdown did that. Will remove that. Also, Should > I remove the cvmx_pko_disable() call in the remove function in this patch > series? Or should I do that in a new patch? > > > Also I feel like probe() should fail if alloc_netdev() fails > > or register_netdev(), but that's not introduced by this patch > > either. > > My main goal with the patch series was to get rid of panic() calls in > some of the initialization error paths. I will look into properly handling > alloc_etherdev and register_netdev errors but in new patch(es). To be honest, I would keep your patch as-is instead of being more ambitious. If you get much more ambitious then we'd need to test it. Right now, we're only affecting paths which would have caused a panic in the original code, but if we added error checking for register_netdev() then there is a chance of breaking something. I was just saying that this might not be 100% correct, but it doesn't break anything that wasn't broken in the original so it's fine. regards, dan carpenter