From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8DE34041F for ; Mon, 29 Jun 2026 20:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782763979; cv=none; b=nHRUJh5dtY6tzZgzVgnJfVjzwthG+Fn2J6mBZOz2lvrUI+eyoNqQveyh36wQXSC4NRKc49JfslW4ESQVgCPYQJwlEb89/OTe5aB+6xa8MY0AsATrM/uynBdkDYPcaLcEpEGzmL69z1YI7MqdbE8GGhsSWmfPzNCtUX+j4hCvY6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782763979; c=relaxed/simple; bh=NeCSuH2nt5U2su0eIIYO0ttmAzpMlgQ9sGDO2MYNERw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qpW+TXOvODflMPB1nfvpyvF2y2mTR2Xs5OYcN56KixjJJJGjtCFrIT07nLrdUm/QGqmDqAJWYtrr32BFiWz4dBH6/Dpcpojk7XP92kVrzmIf1BaZoQSt5bD8mZxKLqY9JN9lb3Q9T5aiUFWaIL14cqYWqzophVffWqBmbm3vl5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EfCrCmE7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=moO70y36; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EfCrCmE7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="moO70y36" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782763977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRLe+V4vhd+rp9mv7dWMWv7QlRgt7F0xMaqSp5zX+2Y=; b=EfCrCmE7IIXNIWxqSIxPlwQrnYuZKwwg2oK2YgLWTpnLSvfuQx+INiFeepvOr6y9XMlHiK rYUYrz+42UxIPFiN9GCCnHaBsYqtDvlzpLy1y9xlnEny09vBh0XgQ2e07fdgCNf5AkdGGV L61W36JkOKpmE1UCFnTbCjT9CtBYpMA= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-iwnfpcPeMWePl1rHUAdxcw-1; Mon, 29 Jun 2026 16:12:56 -0400 X-MC-Unique: iwnfpcPeMWePl1rHUAdxcw-1 X-Mimecast-MFC-AGG-ID: iwnfpcPeMWePl1rHUAdxcw_1782763975 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e9d585d046so2713137a34.1 for ; Mon, 29 Jun 2026 13:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782763975; x=1783368775; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qRLe+V4vhd+rp9mv7dWMWv7QlRgt7F0xMaqSp5zX+2Y=; b=moO70y36g2xcFU44CzaSiIR1Fy55MAlJOov9qsft2wiZwyLYh3PJhrl6/+Hr7tPJzO HsQpJwHOYW43Y0LHJyd0Almsnk2UINkP+z5OwbnrOkCSD6pn243LKK+HlOY9HaYiMJkI oiNztgVEAUI3lJJ/Ebf7q+1tpryLln+aU8mNhybokK8bLITHDZcDVb2c49/ck7hhIIrJ ly44g7cyciccM6IA3+H8TUCzY/orqxm73el56+e+csB4Zwl338FdF4IY59ZGtqzQfVTH ybDtz64ySI3BTCarZMxISHtaUTIsu/PBMyIpyfvOYnPQQO03lvYF873Jj6xhy2xQN/U5 XV9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782763975; x=1783368775; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qRLe+V4vhd+rp9mv7dWMWv7QlRgt7F0xMaqSp5zX+2Y=; b=Iq6lHgr1IqEfz1DP+ZfXYG0xMDnfNIsjwZoNNYcN7YsRXVKUfTYHuzp+ld/rjiqulM 2Ye0Lj88g11BnLI+o7nonzPO4T7i666Fqt5d2ub31zKmx4BM5ruonB1J2Wug5G6UZEJ+ XBYEQWiQMiHHA0f55Li0elzF2DyifGv7iCguXnlj0Z+pfMunzjMbeDAGrYU/kkxlQo5E bKEtm9ETwZZApnXlt4YfY8j0T47oEaSkI0swraCNL+PWZfd6jjWwwBlY2MlRY8cfMsZc 45W2YtAVMiDYA9WZGauIldnF7L9ejDWcNscFZzkVy+2wc5Md8dbtt6BMOUF8y+rCSCa0 ax0w== X-Gm-Message-State: AOJu0YzPeZcmCPKKwXxOiG0l2WQsaibT6YmQH/WtDqwhexFAm2j1VAeF DiIeKLwrift+YjGOFJz5aCiHpQDjsOAeDD63ecEVn1oFUNj63PIf2NGtk7qvSr/sHoMTGqLcHNr 3Y3oKLYyeV8NSVhF88i71uEtl/+ZGUt2T73vPvMqpUi30BmlRifausF9+dJqn/jx+hg+j2u/n8w == X-Gm-Gg: AfdE7cms5jr6w54/fNy2Sk8Txpa7pFG/ba8F+ulB+xxpi6lf+uZ4xNovZMB55Ttqxcp VVVhKZKKxEwW4W++W4t0DU7oI+5+tMelNoR9rfL6AdwF30xqKrdLzXtdIHcivNr5qcoXQjOiH1+ NQOSeAFWKchs9g+JKAHvR2WbyRHb2DpdMc+9I/3x7bHriGlpWFXtillOnPe8ZKoiMDCetgsPdk/ Vf6KpXoRbKeo9e9FAJhXuIShFcLc+jv16oSpO2sDmXTmlMfqA7dIQsyDpFue5cNRSytTG/g7Xc1 BU1u9JFyg/0jbJOIu/kUSdjdXRoIxyoWyrG50xwCkUlC4wk767bPjRBYeoqs++3XCngHd5qZmbt +7K4Y2NRhOA== X-Received: by 2002:a05:6830:1b6d:b0:7e9:e9bc:ae84 with SMTP id 46e09a7af769-7e9ecb902e8mr408281a34.12.1782763975166; Mon, 29 Jun 2026 13:12:55 -0700 (PDT) X-Received: by 2002:a05:6830:1b6d:b0:7e9:e9bc:ae84 with SMTP id 46e09a7af769-7e9ecb902e8mr408259a34.12.1782763974655; Mon, 29 Jun 2026 13:12:54 -0700 (PDT) Received: from redhat.com ([2600:382:8127:f62c:d44b:25b0:6b89:f501]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9ec307edesm585857a34.21.2026.06.29.13.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 13:12:53 -0700 (PDT) Date: Mon, 29 Jun 2026 16:12:50 -0400 From: Brian Masney To: Colin Foster Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Shubhrajyoti Datta , Michal Simek , Stephen Boyd , Michael Turquette Subject: Re: [PATCH v1 1/3] clk: clocking-wizard: fix clock difference detection Message-ID: References: <20260506200555.2558434-1-colin.foster@in-advantage.com> <20260506200555.2558434-2-colin.foster@in-advantage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506200555.2558434-2-colin.foster@in-advantage.com> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Colin, On Wed, May 06, 2026 at 03:05:53PM -0500, Colin Foster wrote: > The diff calculation didn't take into account rollover. As such, a > target clock frequency below the requested rate would not be considered. > > Before this change, bogus diffs would be used to determine the closest > possible clock: > > 8<-------- > clk-wizard-test: requesting 133312500 Hz on output 0 (clock NOT enabled) > *** Clock wizard - Matching for rate 133312500 parent rate 99999000 > m = 33, d = 1, o = 25, freq = 131998680, diff = 18446744073708237796 > m = 34, d = 1, o = 26, freq = 130767923, diff = 18446744073707007039 > m = 35, d = 1, o = 26, freq = 134614038, diff = 1301538 > m = 36, d = 1, o = 27, freq = 133332000, diff = 19500 > 8<-------- > > After this change: > > 8<-------- > clk-wizard-test: requesting 133312500 Hz on output 0 (clock NOT enabled) > *** Clock wizard - Matching for rate 133312500 parent rate 99999000 > m = 33, d = 1, o = 25, freq = 131998680, diff = 1313820 > m = 35, d = 1, o = 26, freq = 134614038, diff = 1301538 > m = 36, d = 1, o = 27, freq = 133332000, diff = 19500 > 8<-------- > > Signed-off-by: Colin Foster > --- > drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c > index 032a688840d8..88b47b8cc387 100644 > --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c > +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c > @@ -408,7 +408,7 @@ static int clk_wzrd_get_divisors(struct clk_hw *hw, unsigned long rate, > if (o < omin || o > omax) > continue; > freq = DIV_ROUND_CLOSEST_ULL(vco_freq, o); > - diff = freq - rate; > + diff = abs(freq - rate); > > if (diff < best_diff) { > printk("m = %d, d = %d, o = %d, freq = %llu, diff = %llu", m, d, o, freq, diff); Stephen didn't pick this up last development cycle and I'm assembling a pull for him. This doesn't apply to upstream. Please post a new version that applies cleanly. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/xilinx/clk-xlnx-clock-wizard.c#n341 Brian