From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB9932F4A0C for ; Tue, 30 Jun 2026 05:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782795663; cv=none; b=CVYqMX5dg/7KiQweHNoiWa5KEZD4Cx38ItQ3kP68kayng11b/2dbkOSkgiujsDdgtX/cQv8w8QKhUWRBLQP1/PFNFR0sfHOOmZuetjoo5yQyGIWCw5OXsm453MZLlG2K4CoJD2uIMlo603I6ds9myqIrNUK5Rq4i2s/pvp1SbPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782795663; c=relaxed/simple; bh=cshp6EzvH/z+lGb8qp51J7AAzfUL7EToPgWpEXGShdA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p0kkgZVaucyZtNsSHkHpPIvZ61zoILMHuTlIdNAL6ll0o8Ylf+al1kPIYmgjjUkWajKkTljJf3nBJQNVOixEmqwl/RviTmyhxfX50Bfs9FlCxl2Ug1vUeOBUSg4pVpO7U/jvvXOs7+Gqxd2jW7n6s+V6bmag2D0MgL+WTXrDkWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=l8YmT/ii; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l8YmT/ii" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c81db32393so34115ad.0 for ; Mon, 29 Jun 2026 22:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782795661; x=1783400461; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qZlx3+QrS8E5J6yUhrTaagwhrce5Kq0xuQVQ07nl46w=; b=l8YmT/iiNVu0b0Yk8Clfeu1rVtvq075YlSg2Uu6daDWI11rUQUO7SDELb7sqU3Yrz0 cUMQ6PL4kBoYr3Wt6SkvCRnPVqFrM+/YkkK30ERDpl854tEUqCRLYvi2C6npUX2ZEwng N/I7ABaMj4zexAa5U6dRa4qit7ZBUUth//lnlHEecM9MNuYsQ2ZcRy20OXjW5itVv9vm JptNrdK+4EA3cV4Dw3ExbfmGxCW1f4sDbTudfBwL3Rjdv7xicfLBtM2V1Xb4gaFI5dHu iF4XhlD7nS2y6/N0w8N4AB3IJ5HMAz2mVyD/bQbQM1m5Up6E1Qv9Mcsx5Yp7EfvSQSIA DS6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782795661; x=1783400461; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qZlx3+QrS8E5J6yUhrTaagwhrce5Kq0xuQVQ07nl46w=; b=kTSlPZdU+y/pgDuvqVzAF8iiOZhCrYKfe04pjJuYZ4R+qNpDYdrD6ceu9WIKdduKuW YMJDAC0MF45KQT8VpORzjgnQepxTM3IeXnApa8UPluNQEfX6rKJdlv7R8fWOOIgfVxip +fE5wSGd9aGmbcIxeo1NHsmeEkfZmu7ZLx7Itu+S9CSZq/jc5K9RH6yHZ4c/3z5LpuGu JCFLxtugn8Du8+OJTjKhZC5WXcxsA3vvlQa+H4r3rTxuiS8oP/5fot9bl7AJLuISeAoa vFMactmrkVTqx2aNX090BS2PNZQbsUkDaquCqvALixNgsniUolVYoLXxsiLZvNBpQFmm skJA== X-Forwarded-Encrypted: i=1; AHgh+RpzUTo32Foq5MnVnCvrJJBfVfDkEPEtDeeJrcfv6sCQ8jdeVK/9YM4zRFrIUIZfnfWlxw9BVNkWthSYPwA=@vger.kernel.org X-Gm-Message-State: AOJu0YwfihPxWOa7FINvtDyUmtQr/zwDBL9Vf37Wp+StVbXFWieh6uek 0qys+oZCGe7N9wpV3elpnHWx2CivIztWp9cl9eF4h9vKqHJEFnM0YP/OQQBj67J7jA== X-Gm-Gg: AfdE7ckU+K9RA1I+WGhxwN3C5iq47+kQU6GyaYr5ROEk7nGWXq8g9HyWmfid0Kpn/R1 aGvujLSPmYEprYYsw3TJHUs9ZQZm+V+GjatKCCtkQK9KHJCeJSnz/pBzpbyaA1zi6TUYcswI5WM vtUHdZasj8PTBxM/lc9GiZA+gfQ4leMJcSxeGaZLrDN666JhHZbOj4U8oLg+Goz0EkJt3tnXF0C 4TbqYlFlgmiAx9VBYXsvBmPZykAh5D5oq22QCiTO591stOYyynOJvIh806+NxNVAvlLmaaEnket 2M/8qdXAE9SCHzzZbLDjKFqequwE2lWg4ekjCZjDLlItRjVHAF/QIwELcs6WnnylZH7MZ0vueh4 TOnYARyFdOypoP+cNFtQNyGKok0oz0iHdylCAE9sf/oe6cZqpepfjMHmkPPumoDMK9zJuCmQeer Po0/0BVjeD91qzmpZ1q8ksS6cDqkN8IUOiNTQeNlqZ92BLWjg= X-Received: by 2002:a17:903:240c:b0:2c1:ee6e:be1d with SMTP id d9443c01a7336-2ca3df01df2mr507815ad.27.1782795660514; Mon, 29 Jun 2026 22:01:00 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cd237sm986590b3a.32.2026.06.29.22.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 22:00:59 -0700 (PDT) Date: Tue, 30 Jun 2026 05:00:54 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, jgg@nvidia.com, joro@8bytes.org, kees@kernel.org, baolu.lu@linux.intel.com, kevin.tian@intel.com, miko.lenczewski@arm.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, jamien@nvidia.com Subject: Re: [PATCH rc v6 3/7] iommu/arm-smmu-v3: Do not enable EVTQ/PRIQ interrupts in kdump kernel Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 30, 2026 at 04:58:14AM +0000, Pranjal Shrivastava wrote: > On Mon, Jun 29, 2026 at 09:14:48PM -0700, Nicolin Chen wrote: > > On Mon, Jun 29, 2026 at 08:48:11AM +0000, Pranjal Shrivastava wrote: > > > On Wed, May 20, 2026 at 10:03:20AM -0700, Nicolin Chen wrote: > > > > @@ -5020,19 +5029,30 @@ static int arm_smmu_setup_irqs(struct arm_smmu_device *smmu) > > > > /* > > > > * Cavium ThunderX2 implementation doesn't support unique irq > > > > * lines. Use a single irq line for all the SMMUv3 interrupts. > > > > + * > > > > + * In kdump, EVTQ/PRIQ are disabled, so no threaded handling. > > > > */ > > > > - ret = devm_request_threaded_irq(smmu->dev, irq, > > > > - arm_smmu_combined_irq_handler, > > > > - arm_smmu_combined_irq_thread, > > > > - IRQF_ONESHOT, > > > > - "arm-smmu-v3-combined-irq", smmu); > > > > + if (is_kdump_kernel()) > > > > + ret = devm_request_irq(smmu->dev, irq, > > > > + arm_smmu_combined_irq_handler, 0, > > > > + "arm-smmu-v3-combined-irq", > > > > + smmu); > > > > > > > Are you sure? > > > > __setup_irq(): > > 1497- /* > > 1498: * IRQF_ONESHOT means the interrupt source in the IRQ chip will be > > 1499- * masked until the threaded handled is done. If there is no thread > > 1500: * handler then it makes no sense to have IRQF_ONESHOT. > > 1501- */ > > 1502: WARN_ON_ONCE(new->flags & IRQF_ONESHOT && !new->thread_fn); > > I meant without IRQF_ONESHOT: > > is_kdump_kernel() ? 0 : IRQF_ONESHOT, note that devm_request_irq is just: > > static inline int __must_check > devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler, > unsigned long irqflags, const char *devname, void *dev_id) > { > return devm_request_threaded_irq(dev, irq, handler, NULL, irqflags | IRQF_COND_ONESHOT, > devname, dev_id); > } > > Not a strong opinion though, just suggesting a way to remove the if. > I though I had given an R-b earlier, but I didn't. With that nit: Reviewed-by: Pranjal Shrivastava Thanks, Praan