From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB16330B01 for ; Tue, 30 Jun 2026 06:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782800417; cv=none; b=mH32KdXsXzAhn2nBOdO9yFrMD8E0kxieE5aa/J/qu6hqLEk2BA7vbdzL+NJsm+BFQAia6fn+dQs2owO1Rlitohz/AnE9r6uh3ki4F7ENCBPwEaGSNdOZgQ48Qiv947+/MBPpYBUS32SDMNMGNF0k9qxVs1teElWGobuJ0EFyqww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782800417; c=relaxed/simple; bh=13R0jmBo5lh7ve4F4WhClFLmWBYHnsZDG81nwCT6HDM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Da+K2m8YpyhMZ1H2kfnvKmlXDyRoUSREuAwGp+9WcAa8lOzuI/j3mXTbD6BPdj9VcSc/NCZmrBS9RlsaQVhvUDavyrYW28kbuG/Be1c/zvixGvUG5fe6DJtpIjo2BMhSDjVXpf/rRX5J1DQoIm4Nmpyxxf5pbU6OE2/cRXF/JHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BDf3mKem; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BDf3mKem" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-139b914bab6so5616786c88.1 for ; Mon, 29 Jun 2026 23:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782800415; x=1783405215; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JGHO4HPY6x7p5Tf7iovHkacr8DByArufqIExC8CB+UA=; b=BDf3mKem6s8KSH0EzwBCLIr8JcTnNWEH8EMgt3+b26WOVTnVWUvf8QjO5kxV/EpLx0 v8NMUDs2zP5geL/za+II26ggfmenK/t4/Go7WMQoi1sochVN/4e5vC1UUMOsVb86XCN1 iktqVG5AclGrtjZxucG2k/6r4SwGmqK5pR7pXkQW9eYlCicZpq2uhWwAyzOHoAeZAIFG v3tydcPytdVpl2i1Rf4Qs4CD2aoClTgsUO2B8gES5ylpLtW9bf2eBQCyrz5YTZh0F4cy Af8yn8XfYRvsiHHAFj6Q+7mk4PTAyAd6qv2l5sC/K8VYHODFsu2wQ1wOoTv1WUyEixl1 bdFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782800415; x=1783405215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGHO4HPY6x7p5Tf7iovHkacr8DByArufqIExC8CB+UA=; b=TjysEohqvPOLpPMwVqRb4lMhPx8wPA8onLOycRgD0uRgkoAzH6diepYT2MU/sh66wM DchSWd6Xxr9YXbYbOZGRxEBGZmWIBjsnDfFSV3vYQ20Lh7o7FmA7NP7tkPJjrd+VFeFA BC6Y3ScCxLAhAiVCR+xYGeewWQ8PNZaOnC+NBcQmpB6riVX/pQmD+Ic2Zu7MK97BXgOl bobek0ywfl2t/X+9Y97fmodj29JRXGWbcjAz8w610RedOIYFyv2bPtYjNJOWmSU6p/od DZcrIh9QuQckCpkn+WhpRH2MMEb1FeK954XjL/VQAW3MUcquatFDUcXt2szoNYLYf0z9 Lt5w== X-Forwarded-Encrypted: i=1; AFNElJ/ysU3JMuu/aJWkQWzLQDaON2bFizNUoh73JGUspXbUjLb/x/cgmKQv5Xo36AAaw/emOVXRyWdG1i1JpMY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5N9NPztzinWvhoo8RhN775arWPThqJTBxwys3K4kgc3Y9+WgP CSIRWJD0gbTt1P0xzT5cGDJusPYkrx47zawBFp6CrwrT6URGFNmL2Ova X-Gm-Gg: AfdE7clS/tcbK/tvz8PRmFRtYSICLYFIVLdPO6UW/lwJIyvnBQwSN3Rfl1V/UsBciDe 2wKseFFIGRK/Ul32RQKXqeQJEFs68QI7RB70P7E4srtkZW6RjT8X2tI7lIuGVUqTiORSRP/YmTR ypTdtglqFGtBoUwa2s4FYQBtAvIDLElzCLjcYeVY6BkW8B3vthr5yp6ZFR11Vk/nMyN7TKr120r pV0RiPdDzH+xAERgPTrZBnGQsi/nPiUq4sSGoSUIJZRt94LkysM9Tg3HIySoiUdVSONUKsHk6Dv LSz97AJsQrUEVeRv4ncDGWkcvjXN7E82kZKEyQ8jcaL8KROqqFAnpYbtyJA2f+vcKuYaxpV1dvD 3AelEkrXuHfDotCmI0zNZnvnL2qZybigwWJHtQZoy4/S3GlSRi2bZGp88kzuXRJ4UmX1kLVCXDB irT7HeUBKGzltMiRwISEiruXXHEFOgJ34k X-Received: by 2002:a05:7022:690:b0:136:6883:c4bf with SMTP id a92af1059eb24-13b2a159f85mr1439960c88.15.1782800415264; Mon, 29 Jun 2026 23:20:15 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::94ac]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b2ab2e0e3sm4132472c88.7.2026.06.29.23.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 23:20:14 -0700 (PDT) Date: Mon, 29 Jun 2026 23:20:12 -0700 From: Charlie Jenkins To: Nam Cao Cc: Xiaofeng Yuan , pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] riscv: probes: simulate c.jal instruction Message-ID: References: <20260627001939.3847-1-xiaofengmian@163.com> <178253409654.105999.9483335947060007692.b4-review@b4> <878q805jvd.fsf@yellow.woof> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878q805jvd.fsf@yellow.woof> On Sat, Jun 27, 2026 at 12:59:50PM +0200, Nam Cao wrote: > Charlie Jenkins writes: > > I was looking at this recently trying to figure out why this hadn't been > > implemented and couldn't determine why this one was special, it might be > > because it is 32-bit only. > > Yes. When I looked into this, I had no idea how to test rv32, so I skipped it. > > > Since it is 32-bit only, can you put ifdefs > > around it for riscv32 (#if __riscv_xlen == 32) ? > > Except for slightly bigger kernel size, it does not hurt to keep. And > #if stuff is quite ugly. But I'm fine with it either way. Yeah that's fair it's not necessary. The thought was for "documentation"/ just letting people know that it's a riscv32 instruction but it's probably better to just leave that off. - Charlie > > > Can you also add a test case to: > > arch/riscv/kernel/tests/kprobes/test-kprobes-asm.S? > > I already have a patch adding test case. Let me send it. > > Nam