From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1666388E51 for ; Tue, 30 Jun 2026 10:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782817106; cv=none; b=nsZS+6XEaPW2EZcjUy+hp3M2Z0a9xLh3hpSY52Q8axlG4+vW1RiS3hMHg1M4WUZagkZJ85xSUbD4LbP2J9Cuz6xGCDncxRAGGcJqShhIsW0mp4DoAwlMTRLlfANPkggGRYZ1vKLPoJGXc5+sAsrTK3UyjiRjDVxyBHtEmqMUNUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782817106; c=relaxed/simple; bh=xPOgNdAUqqfkmQJ9rcJfkDujHXRcscfJBgdbqpudeZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eaqSCNpIpUUqlynsVlRzyM8H86YymhSAOQWIdAZ0OJUHaXu8KhmbQffwGV+E4Ox5ZQTtQ0Y1d5tPyn8hKs/kIL5jJx5DZCGA5Gen57zemUJvSQ04eLOxBZFjeQEhqqRQQ8LS3xUO1PkiqcNnckxSenR73+63+Dq3s/QcqLBmsAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name; spf=pass smtp.mailfrom=shutemov.name; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b=mu6HTBN1; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=bT5cxKXf; arc=none smtp.client-ip=202.12.124.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shutemov.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b="mu6HTBN1"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bT5cxKXf" Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 20E971D000D6; Tue, 30 Jun 2026 06:58:23 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Tue, 30 Jun 2026 06:58:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1782817102; x= 1782903502; bh=nlydiMJW9RbHjskuOlBipQ6VukjrIll6ursGu3buz84=; b=m u6HTBN1lqRaj4giMMt0qbMZFcPVh/ssGpqk50bhm38HzIaBPCtqf8zE48nH753sx uN2ZZduiAkhwNwmXgOS7YDYAvuFGmJuzMd/kXgDdf+pHi4L1fAS2LxEwPZTdoB9B IyJhCmgINACaQRmtgK7RAh9s6m7Ql0I1D1sk4uNWmWINsyA8pa4wsqbOCQ7AucLQ 7Fdl95zVpPZXuQqM9HA0cNnLvvu19b5zZaPhMc5rHHJ6U4UzIOnZnapZEFyvC/IB pUWjRvJVcONY0DxcI9d0IcRgtSIqqmq6aHQRlzr3Xi/vKVDcykHyl0bB/U0PeC2l 4S84xe7rzwadAAoKqPp7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782817102; x=1782903502; bh=nlydiMJW9RbHjskuOlBipQ6VukjrIll6urs Gu3buz84=; b=bT5cxKXfvqkP27kB7ciD+geHl/91KpM41nZWZLYtrRgj2d+GXML U+MipqtYHUzgh7N/yy0QiMJLWLwgVBJa5Y18O/GJG95pNJzcwnDEMQeWGQQVZVVZ fcdHEYjGRonRjN4wRoDboYvaHuhWneYiQcuy5B+pNmcdnCdZbyNBfmLWB26Ysv/s c2VB7sjRt8ObcWzZkqT3taAJqN5AhEdFWIAhGldFkdLELQf0ztIiZsey7Xh7KFou UDS/5NNbLHuIPZxDZrYqauFdeX5l6bNnIWlfd+7VObXbrF26Snp50nx1AIqMGeN+ 8pKmbAV48MELWLBqPH0u32aX9R8RqP0yf0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGsj2JEFwh+c3qskAhajKYGDnGT+piVrlQpL7p3qhdJubLNRCSiA7k5mGw8mX3hJd q0+DdbVacWPVC2/+xBx5vOTHH3RV0XN/qU6Mhc6J3KStcUs4J4XzFVpqrwPkYWYAnkXRmp oNkZkoLiWaTxznptZVPFmvvrGrsf4zU3tzZ/07VmgDMG9YmEHcjW4t1+wr6fO/tHnjzEcE 3vJLerl7c8VVIZiOo1YbTi6dADQZTfXt0CiWJGlirkNHOG0W5AEHkS92xkP8PhT6xI9GtL 37yk+WDzstddTcf4Jpy/VzrXOoBxkXfR9x/166eOmzaUuWQ54+F8cfM8ArwKqCsKo+2nC0 a6Y3RJkZE+wCp5IfaMd7AnWcPvhnmw9DaxAGfK8unjIVih3KCw7UK5DVyd5/i8SrRnhfNC Fwuyiyh4n9LdCtU1n/1vjSFfixWe+DMdYJGiOB/ib1jbG9vpNgtUg8aCTGSGJqZq0TuXFK VNpkkmP++e2SJbRNS+X70iYE2ZnQVpmDI/cgB1O8JufdIj6oaiXGcckvLQC4UQTjIvqy2p pZNNvSYlzBSmfMoRuFCX3/Jg3rwttuS3zqFppCCwePbHqcEqpQ3/pHUZqHDB55HIPhGicR yFDrvaMNHYNRXHNeLasbJooqPWFIwiCnUfW47P1mSlvvOgi6/+MF8Ww8dnlw X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Jun 2026 06:58:22 -0400 (EDT) Date: Tue, 30 Jun 2026 11:58:21 +0100 From: Kiryl Shutsemau To: Usama Arif Cc: Catalin Marinas , Will Deacon , James Morse , Mark Rutland , Marc Zyngier , Doug Anderson , Petr Mladek , Thomas Gleixner , Andrew Morton , Baoquan He , Puranjay Mohan , Breno Leitao , Julien Thierry , Lecopzer Chen , Sumit Garg , kernel-team@meta.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/4] firmware: arm_sdei: add SDEI_EVENT_SIGNAL support Message-ID: References: <20260630105125.4006859-1-usama.arif@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630105125.4006859-1-usama.arif@linux.dev> On Tue, Jun 30, 2026 at 03:51:24AM -0700, Usama Arif wrote: > On Mon, 29 Jun 2026 16:07:16 +0100 Kiryl Shutsemau wrote: > > > From: "Kiryl Shutsemau (Meta)" > > > > Add sdei_event_signal(), a thin wrapper over the SDEI_EVENT_SIGNAL call > > (DEN0054) that makes the software-signalled event (event 0) pending on a > > target PE -- delivered NMI-like even when that PE has interrupts masked. > > It takes no locks, so it is safe to call from NMI / crash context. > > > > Signed-off-by: Kiryl Shutsemau (Meta) > > Reviewed-by: Douglas Anderson > > --- > > drivers/firmware/arm_sdei.c | 12 ++++++++++++ > > include/linux/arm_sdei.h | 6 ++++++ > > include/uapi/linux/arm_sdei.h | 1 + > > 3 files changed, 19 insertions(+) > > > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > > index c161cf263547..e8dd2f0f3919 100644 > > --- a/drivers/firmware/arm_sdei.c > > +++ b/drivers/firmware/arm_sdei.c > > @@ -339,6 +339,18 @@ static void _ipi_unmask_cpu(void *ignored) > > sdei_unmask_local_cpu(); > > } > > > > +/* > > + * Signal the software-signalled event (event 0) to @mpidr. Does nothing > > + * but the SMC -- no locks, no event lookup -- so it is safe from NMI / > > + * crash context (e.g. the cross-CPU NMI service). > > + */ > > +int sdei_event_signal(u32 event_num, u64 mpidr) > > +{ > > + return invoke_sdei_fn(SDEI_1_0_FN_SDEI_EVENT_SIGNAL, event_num, > > + mpidr, 0, 0, 0, NULL); > > +} > > +NOKPROBE_SYMBOL(sdei_event_signal); > > + > > Same as patch 1, can this be merged in patch 3? Its good to keep functions > where they are used. Patch 3 is big as it is. I don't think folding code that can be a standalone patch helps the situation. -- Kiryl Shutsemau / Kirill A. Shutemov