From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281803451AA for ; Tue, 30 Jun 2026 12:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821830; cv=none; b=Q0zwUvn8DNSps6cnx8x67BQ6SgnD97mF69bhTyIYjU+GGMr70d1yDFmAZxAXf8uKla3DtbhmL+zJ//SNJrI/XRL86MdlI+CBo/bbXAguClfiPG/9i7ZHrKZQG6N9pW1rWub9+5YU14qIfpu8Lb7X4MBfWGoMJxSVwT1qtgi0Td4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821830; c=relaxed/simple; bh=lpi8HmkVrz15YDKFvi6HG2jYJWtkJK/wF8kEEXrXboY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KAqZd36CWCfbpsynwh8keyIl28U/8xjpEuaEY+TUlpl8m5xV0ykLuva4W1SKrSYnJdHHiZ1vEbrbwgc8EyAdBpINiC1LP6OulehbA4bN2WJqY2ZNBdyZtSCeCVR3WkrSIH7iOsfiDZQHsLlK5GGUrx5KwrkgB/9woCQGcp13Oeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PyxbIoAE; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PyxbIoAE" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7e9cd40e582so879157a34.2 for ; Tue, 30 Jun 2026 05:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782821828; x=1783426628; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7cHes77q8EhrtBA+B/LAION1oySZSYHvNSe2t5fjkq4=; b=PyxbIoAE0ZWlTjbPRDHyVn+B5Vw4Fo0GK5+NO5YZsxqSr6itcfs4/sEIsONY5QsA3Q j+2nuSjomKyJ4W6fcUQ8qUKfVLwBOKKuQg+yVoHeJTIA1PWPiRmsFs49k7Ff1rBdJwyC JYhLCaT98hVg9wHJ9f0JC990X8TzcZViAfYXbX3E0vavFyo5YMi4tjm+YuAFAeJFAwpv /PsPPE18mESXT1dRguHTEoyMlFs5LOAguQQ3iZpnY/lx6iULG8icMmgoF+/6EDxoHeCw evWj4BZzn3R+Wqlu1m8eQzY2t8kndJiI8I16hK+P6jSQE7zYctaFvHqBD1QQkTRJeqUj wmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782821828; x=1783426628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7cHes77q8EhrtBA+B/LAION1oySZSYHvNSe2t5fjkq4=; b=nuXaeEQwnez2Sp8yhO3ZoY/575c42D0wGzxQS/vDTgQwqmkti603rBZv3JlqjStfem XC/U3J0HocxSVQ4vPbKNXszDX4DXKldDSpSAPj1yAEcX4dcBWz6rN7HMfJbd5WCbdWnN 00JklUiuZcBA7Nm6JRFrUQmDPU0rjBcrskjeUc+Aw2y4WtlnR0++WiqAOowfOFGCEmXm sd9rDkGKh15lCyxRJbWFv/paJRK3V3mB1h/6bSlMBQXjtYW33RZzocn4ifN/XlOQ4zFZ CUU66w+n1jDU725/3kJmewMmebuAmB9YT0TtwhsMpsrZFSQvAI6btOG/sybkutKMRjBs cP1g== X-Forwarded-Encrypted: i=1; AFNElJ9Kcs0viUreUIICrGAuWR/s3OgLTWulmuNA08tOqn4I4alMbNBmBHp4RD9/j8wjOvwGpCGJ0UIf9d3FZk4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1+UTVgvWIh8Cdiw4aoIsCuF4BWCgfcQqN7LJuN/5QtI7K08Y/ Z77BdJiFVK8Y3Z1sHvkIm9P8cDcX/igXKXQlXm39Oxtim+VRrnfF46Kv X-Gm-Gg: AfdE7cmQIy4MJ5RTU6+SwTHUbOopTUYpB7gIrzas/3u+CcsytzI/2K1Z2y7nuQhE+3A uWfcM8IEUIIco/X9sbIw/14nsdfCZm9FqksAtW0vcn/CD7nAbQ2YFiO+SHv2PFvwapcm7CvVGUh K/Ivu1tm3X7nljaqmKPUPhxb+WMVHXPG0UFkK5BbMimvJ/hGk55WTXA4aJc8tBdx8Nhiw4StMnN gur1rbPtU3RU/+SBrDEVkVhvlgudAtMRklVq4syJhOyjABgclQymYWpkqJhuSq7z+AVKo7cR4Ay /YKS+Q1w4n1CEB3jerBT3V87bTBa5cPOApwIXQM9zweO5EFYiOcKH9mY4AyTwnlO4906dhQzwLN wpeTStmhLnbnxZp7pHamvmC3THSuMvsrInen2eszwDIjauAu9jwoZrMs+0tfTMFTD+eCvGZohsX Y6GnkPGxPK42qim0u2 X-Received: by 2002:a05:6808:5296:b0:489:9724:1992 with SMTP id 5614622812f47-495eb006ee1mr2617762b6e.30.1782821828069; Tue, 30 Jun 2026 05:17:08 -0700 (PDT) Received: from localhost ([74.80.182.100]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4935545dad9sm8287677b6e.16.2026.06.30.05.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 05:17:06 -0700 (PDT) Date: Tue, 30 Jun 2026 15:16:59 +0300 From: Dan Carpenter To: adi25charis@gmail.com Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: split topology get into size and data calls Message-ID: References: <20260629144941.33818-1-adi25charis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 30, 2026 at 03:13:28PM +0300, Dan Carpenter wrote: > On Mon, Jun 29, 2026 at 08:19:41PM +0530, adi25charis@gmail.com wrote: > > + topology = kzalloc(size, GFP_KERNEL); > > + if (!topology) { > > + ret = -ENOMEM; > > goto disable_connection; > > } > > > > + ret = gb_audio_gb_get_topology(gbmodule->mgmt_connection, topology, size); > > It's unfortunate that we don't save the size anywhere. This code > relies on trusting the firmware for its security. It would be better > to move away from that. > (just ignore this comment. It's just random thoughts, not related to your patch. Someone took some steps to try make this code less trusting recently). regards, dan carpenter