From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBAB3D1A98 for ; Tue, 30 Jun 2026 16:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782838772; cv=none; b=nqagt+w6hb4TxjAQOvk/UlLVMXrcLZoAEzKk+0exVx3N4sZNV9Lu1Ex090MFnlL2HzErSoIYXJggW2Y6h50z1LmTCUDdxu4G4dKk1pmmpN2jDizX/2OU4pTkSnlAJVk1b6xM98rmptup6opKuYSRN58e5GU9ceTGiP2yb2rKX6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782838772; c=relaxed/simple; bh=FveIuuZW3MWr0DW5S0AtbDNefqSkX06Xtrdwa3y5Gzo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MAkpzh8QnyHqQx0W3DDdDIglY0MoK1os7oqKhP6pETBvOLMGbh8AmtyOojFRHeuvcYEtQ4w1YeT9GpFQ2G+Qj8eFS4AIkYyLNK11roR5fIYNQg24SsDkNBlR7eWgxmIUW/VnSOa1dAaZzd/EJD9bZc5VGEOpytK8D5P5m2TNWOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=HMv/7z6x; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="HMv/7z6x" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-4703bc0a99aso2082327f8f.3 for ; Tue, 30 Jun 2026 09:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782838770; x=1783443570; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ToPfySYGPKghPkEJRrJrIYgPfvQVtZ8t1xpbJGBGmt8=; b=HMv/7z6x82U/9firCQd5Xc3oP3uGYVM2fx9TKGFGMYXYnHTvKWKKmfbyZ2z2t7DAvB 3EAepJB16g7eLUhHebRs95S8JkTZgAYRJL7BPaRKc0BsGG9PDV7yudPm6lbxJcxf0O3X SuDzqsCYm9i47b+uEEp6R8x8e7lWtSVd2GusKejdq3kouLQeXYkIYqtQsKkJGox1vZgJ XG28bM6A2rAhPydowd/8pKaAfJON4PL4yF1PTLDayUb/sO2PkrhoPpFa7z4RiCb8KJUR r04R9pFDfCTBZMeE3eCbIvfbGefKgA++pu8MfwbqQTv30HK+MmYigTXXtBQvcJwg6o9L xvVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782838770; x=1783443570; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ToPfySYGPKghPkEJRrJrIYgPfvQVtZ8t1xpbJGBGmt8=; b=RpAl8CnXAcqGVNbKZggGOVE69xi538Al33UlFkQlO+ahyBvr4olzfBeMRatMtioxSd G/Q9YPk/Wbp/vnF5xorq1GgaKT99J0cx5eYaYXoPJVBKTO5FUSrFeWvog9QWfkhksFDf DviKGjnMpuSxnYfc/ivwPwjCbV+Xeg2XaeK25bOIO6ILI+OxC7tFXFXFh5pOf6HMVmQZ d+pFJwWHD4OdY7xRBqX2SOyS7QpgtRsYitoKzHJC0nYkcsNrbQUTOcLGF4AL9Pxb/19S c+XwUOvKFAfix9A0eLtUFw+50HxS+ACZoylPkmxvkflheP5tTk8Bew+sAQH5yLLT6Iw9 fg9g== X-Forwarded-Encrypted: i=1; AHgh+RrziPT1jsHeA/uabgMmKvlkl64yk7hydL04Fn3+0iInu5ASyRPqdpIUDNXVmh2M6HL4K7rG8y85uSvkLX4=@vger.kernel.org X-Gm-Message-State: AOJu0YxI0wFr8qr0wlnuWTV4eN5U9DZ6Zs13AzHzkum34pIjB95vKtmB n+ySyFTGlgi/QMB6OzMK/oCUmbU88MfhQ6UqWN9lFx+vIYKDMSOCg4AmIOQshrkwYnE= X-Gm-Gg: AfdE7ckfaCo16tuYC6RibpEG8HbxKA831JvfLplSH4p+UouTjXwvQe+OHm7Mn7uxst7 u6xeEWNjD/ksnAOWNklsCvKYht60RDNXlWeO7O/MyTq49wJ3T3ZIaNAgyWEaMColTvISCQBZ4xr uwJtjHrGJX3o53FSRgRZVq0u2hflbQTESe1U7bWGHJhKbL+42lND6t9ub264uciE5yobQxsPb0w Ohxs/OWGK1/zrJLrY/Gm2zv96+YpEVkC1HuK1J9CKJB2ZVji+P3xAAqlRn674WaBL5IUL50t5Cq Kw/PyNv5Ml5c4Svqo3QO+EZYJqa3vt/QMSNKkmEZ8I9a1jCmYJBwI7xNdz3GMR15FDPTVaFGcWK 082PfJdzKLy2cvgasGQQPgN4sgisRAhqj8hf74HUArN4xSE38hGa1430pbmjSaxeNNBjQFV1uGl JRcUAFFGJFe165yLWJrSupTDUAnrHPtjMjMnl16rYO9Oj5G6CsHPvg0OpXGdhtJAYS03fZxqTAS usX X-Received: by 2002:adf:e44e:0:b0:473:6e8d:7f8 with SMTP id ffacd0b85a97d-476586d066fmr1739874f8f.14.1782838769975; Tue, 30 Jun 2026 09:59:29 -0700 (PDT) Received: from localhost (p200300f65f47db042a9b551def0a6b94.dip0.t-ipconnect.de. [2003:f6:5f47:db04:2a9b:551d:ef0a:6b94]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47563d194b0sm9864992f8f.1.2026.06.30.09.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 09:59:29 -0700 (PDT) Date: Tue, 30 Jun 2026 18:59:28 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Richard Fitzgerald Cc: mturquette@baylibre.com, sboyd@kernel.org, bmasney@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v6 2/3] clk: cs2600: Add Fractional-N clock driver Message-ID: References: <20260630155549.824059-1-rf@opensource.cirrus.com> <20260630155549.824059-3-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uank47bqgvhpmjv7" Content-Disposition: inline In-Reply-To: <20260630155549.824059-3-rf@opensource.cirrus.com> --uank47bqgvhpmjv7 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v6 2/3] clk: cs2600: Add Fractional-N clock driver MIME-Version: 1.0 On Tue, Jun 30, 2026 at 04:55:48PM +0100, Richard Fitzgerald wrote: > +static const struct i2c_device_id cs2600_id[] = { > + { "cs2600", }, > + {} > +}; Please make this: static const struct i2c_device_id cs2600_id[] = { { .name = "cs2600" }, { } }; to match the common style. Best regards Uwe --uank47bqgvhpmjv7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpD9ewACgkQj4D7WH0S /k4xTQgAjU7n2LgMUu9Q0GkPON5In9ieUddR+wc8yV7m4IKTBvEFVmoq69UniHC6 uVr+Lp+vDSMKPXAm1ZzppVFCb0C6N2GlZpg++smO1/ssBrCHxeCn0j3WlcgAy3rL 2/o8dMDwYk/kfqYNoXCnYHkGE83aPsfM4zqFlz0BZ6vsOPdAJ1g1QZIgzjPEEGgQ +VR0HuiIFc3OadpTDVnq/SFN4vZ8ONt889m2O6SXWdnXM6Z3Bcf7CC2EwpYJpwXb Ov2Qvu+f52plS8czZ++zwS4ZyKpAn/gNY48tAW5Ax2gJHYo+XXq3lC8U6zecvRXc zHXTvrJLZCC0s46GMcVdh5SbgYP2aA== =x3xX -----END PGP SIGNATURE----- --uank47bqgvhpmjv7--