The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: "Bohdan D. Marcus" <bohdandmarcus@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
	andy@kernel.org, sakari.ailus@linux.intel.com,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	"Bohdan D. Marcus" <bohdanmarcus@tutanota.com>
Subject: Re: [PATCH] media: atomisp: fix block comment formatting style
Date: Tue, 30 Jun 2026 16:29:55 +0300	[thread overview]
Message-ID: <akPE0_FWWMAe8BfS@stanley.mountain> (raw)
In-Reply-To: <20260630131226.23374-1-bohdandmarcus@gmail.com>

On Tue, Jun 30, 2026 at 04:12:26PM +0300, Bohdan D. Marcus wrote:
> Fix a block comment formatting warning reported by checkpatch.pl
> in atomisp_cmd.c to conform to the Linux kernel coding style.
> 
> Signed-off-by: Bohdan D. Marcus <bohdanmarcus@tutanota.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 6cd500d9fd26..20abc2c0de80 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
>  		if (sizeof(*cur) != sizeof(dvs2_coefs.grid) ||
>  		    memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
>  			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
> -			/* If the grid info in the argument differs from the current
> -			grid info, we tell the caller to reset the grid size and
> -			try again. */
> +						/*
> +						 * If the grid info in the argument differs
> +						 * from the current grid info, we tell the
> +						 * caller to reset the grid size and try
> +						 * again.
> +						 */

Why did you indent it so far to the right?  Something went wrong?

regards,
dan carpenter

>  			return -EAGAIN;
>  		}
>  
> -- 
> 2.55.0
> 

      reply	other threads:[~2026-06-30 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 13:12 [PATCH] media: atomisp: fix block comment formatting style Bohdan D. Marcus
2026-06-30 13:29 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akPE0_FWWMAe8BfS@stanley.mountain \
    --to=error27@gmail.com \
    --cc=andy@kernel.org \
    --cc=bohdandmarcus@gmail.com \
    --cc=bohdanmarcus@tutanota.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox