From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9390B4219E8 for ; Tue, 30 Jun 2026 13:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826088; cv=none; b=dl41WCbjNIGzR6DUfwIyi01QRgU7jWxyL/kttOjKPf+4say6cPNHhETnh8uQRUlsNeMNZIgDuBTYBruZiufgFdhcODL2LVvDQhd7M0ejwuNeMbFUWgEsC3/tpnWoU7zt9KJBo2R/gbOnqIbNEXZyifaoHd8v9SM+yeEV9kUvkbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826088; c=relaxed/simple; bh=XC4U/RvjohytAMvYA3ZyJOjOfjBhi1bX8KkCsIJHQwk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mz/chd28c6GkWi9R7Dzcz65xGjUMYN5ioUAIoMhcLda6lfFhFtpNQY4DbUrNpQsLM4CPiFluJZoeohVVRLrG7+lDtu9/YdiLb+pa2z+zcZ5OiL/6XSRcvTa+13SPLM/Ow5sVtgfxA1lKubouIwWPCqjv9GZcdkyJ2OGTJh2RqMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ctuhH+71; arc=none smtp.client-ip=209.85.217.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ctuhH+71" Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-73a75f251a7so228711137.2 for ; Tue, 30 Jun 2026 06:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782826084; x=1783430884; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=63L3nK7vrBcvN1li6echQyTJBc1iw1dvXuudNEEXZeY=; b=ctuhH+71WOhWmNxFUZmYcddxVaRIOBFhzSVZN2zNsUoN/BSI/HRPG4I0qFzFq7OhUv 9RoWr/udiLd3dxTlLNC9H7OiPI3nQH1U8uJ23R7iiLivkP8uPtN4DYW9ldu4tO+1xlcq X3+ogtCf+0mghmOpO2vtHFLJMVyOjAzSdFHpk9ncS5BKsBP2ebzK1+WaCRgU17+Yb+pp RG3n8XApgYkCIYuHk3hSTTj4ekFqVPGdDHXabFaCW74QIC1n7GBx4vMgY0q4q9pDPY5S cQpmeJH+1/azk8OLDXOl0FkfeR2uFO69rQE8bvuY/g/OJSE80FQhxTwjNQB0lKIawr5j ClJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782826084; x=1783430884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63L3nK7vrBcvN1li6echQyTJBc1iw1dvXuudNEEXZeY=; b=RXoQfcxZyjFNbPKaTgAIZxWVo6TRFzMRugyaW9MWTlWu5fha9PPzPjvIq1rXDO2P1A xAiqS89jB0CvSaTZd0s5T91WVJZYztBweGu57QFylVw267TFjZwoLbV0jhwGOYDqNeWf JMgba9T8YATw/PvwHNFTvQAHEclDzfA/2Cbc9gD76nzXlgpXPGrUx0ZrpbPk3rdEfxHK 4LJbTqiDUHnMMZ11YXlzY7r/UvrIDvPPXtm99bRdSGMD2SX1TNuiKTX7J4DFZy0atQws cgp1uuC8dZd2SNRNTsDNJtnuRMJBcNqoOuMWUa4eoh/TFJYon0aLWsvDpV7kJz4p+Aq/ c5NA== X-Forwarded-Encrypted: i=1; AHgh+Rro5MnU/qWWpy7DrSQY1WRFPLvYVszrF0YAYLYKH/6vlsnYPDRr3zNB6J34JFU3dxmpkEVTgd+jGiTWpZY=@vger.kernel.org X-Gm-Message-State: AOJu0YyVGj0E3CyX0TAS2OMCfNyqzEB5XZ4cMdkJcV1BWKVgnv6UkqhH RYfLjijb772bJnxJV9+stNf3d3cbWoi0JyTurfvXhEVnamhh9b1r7Qwh X-Gm-Gg: AfdE7ckybRG/fKYoSfgk9oEecSvF9euf/1n/1tRBHrWZ0Swq6vtueucTsXtmg+uwRik EIT9lkSd5PFtwcU/GTtH5NxtuSycoxO3FYRIxhm8MN1XkVfZTM0cx1ldGXmAeEPdhmNqnEMuDlc e3JiC9682lZLI+1Nd3K/vOS4WPX5o2+ZNkQ9CsRaSGeRTEvHCk85PCbEiMe9GC1Jm0d2Io1/VuG w2KYKCd/xTLW+gXxVKgXeC0U7kPiQqB7zj2xjSuH42C6V6zGc++Hg4uF/ZIBdaxne3ncm9pUMkY gDYyZ2ryjuGP2ofURJkfoVQb1nlkDm4rXtIOAeq4mfn/YqiG0143eC2PK/B/gnXThWvgFvxaOdk eJaSGwengr/gagbMCvq4osKWevm8w2D7C9dwUKujQQZvdIzbim7WtkKQxofXf7HN8mxLRyR80j0 9lY2p+ X-Received: by 2002:a05:6102:a48:b0:73a:e9b:26ec with SMTP id ada2fe7eead31-73a37f2634fmr1452767137.16.1782826083923; Tue, 30 Jun 2026 06:28:03 -0700 (PDT) Received: from localhost ([74.80.182.83]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-96965e6fb4esm909719241.1.2026.06.30.06.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 06:28:02 -0700 (PDT) Date: Tue, 30 Jun 2026 16:27:57 +0300 From: Dan Carpenter To: Joshua Crofts Cc: Andy Shevchenko , Mohamad Raizudeen , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, gregkh@linuxfoundation.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: frequency: ad9832/ad9834: use div64_ul instead of do_div Message-ID: References: <20260630032322.5805-1-raizudeen.kerneldev@gmail.com> <20260630093931.00006eca@gmail.com> <20260630150755.0000266f@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630150755.0000266f@gmail.com> On Tue, Jun 30, 2026 at 03:07:55PM +0200, Joshua Crofts wrote: > On Tue, 30 Jun 2026 15:02:02 +0300 > Andy Shevchenko wrote: > > Since we are getting more "fixes" in the area, perhaps it's a time to add > > a comment in the code summarizing the mentioned discussion? > > > > Good idea. I'd also mention Coccinelle and its false positive in the comment > since patches trying to fix this always mention it (my attempt included). Generally, if the code is old then someone has already looked at the static checker warnings and decided the original code is fine. You should look up old static checker warnings on lore before sending a patch. regards, dan carpenter