From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Selvamani.Rajagopal@onsemi.com
Cc: Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (pmbus/fd5121): Add support FD5121, FD5123 and FD5125
Date: Tue, 30 Jun 2026 18:49:43 +0200 [thread overview]
Message-ID: <akPy0zCESKoGgsF1@monoceros> (raw)
In-Reply-To: <20260622-support-fd5121-from-onsemi-v1-3-b31767689c65@onsemi.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
Hello,
On Mon, Jun 22, 2026 at 10:55:39PM -0700, Selvamani Rajagopal via B4 Relay wrote:
> +static const struct i2c_device_id fd5121_id[] = {
> + { "fd5121", chip_fd5121 },
> + { "fd5123", chip_fd5123 },
> + { "fd5125", chip_fd5125 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, fd5121_id);
Please make this:
static const struct i2c_device_id fd5121_id[] = {
{ .name = "fd5121", .driver_data = chip_fd5121 },
{ .name = "fd5123", .driver_data = chip_fd5123 },
{ .name = "fd5125", .driver_data = chip_fd5125 },
{ }
};
MODULE_DEVICE_TABLE(i2c, fd5121_id);
See e.g.
https://lore.kernel.org/lkml/20260515103150.164887-2-u.kleine-koenig@baylibre.com/
for the rationale.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-06-30 16:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 5:55 [PATCH 0/3] Support onsemi's FD5121 multiphase digital controller Selvamani Rajagopal via B4 Relay
2026-06-23 5:55 ` [PATCH 1/3] Documentation/hwmon: Add onsemi's FD5121 controllers' documentation Selvamani Rajagopal via B4 Relay
2026-06-23 5:55 ` [PATCH 2/3] dt-bindings: hwmon: pmbus: Support for onsemi's FD5121 Selvamani Rajagopal via B4 Relay
2026-06-23 17:36 ` Conor Dooley
2026-06-23 21:01 ` Selvamani Rajagopal
2026-06-23 21:14 ` Conor Dooley
2026-06-24 22:36 ` Selvamani Rajagopal
2026-06-24 23:05 ` Guenter Roeck
2026-06-25 0:35 ` Selvamani Rajagopal
2026-06-30 17:22 ` Selvamani Rajagopal
2026-06-30 18:58 ` Guenter Roeck
2026-06-23 5:55 ` [PATCH 3/3] hwmon: (pmbus/fd5121): Add support FD5121, FD5123 and FD5125 Selvamani Rajagopal via B4 Relay
2026-06-23 22:07 ` Guenter Roeck
2026-06-23 23:12 ` Selvamani Rajagopal
2026-06-30 16:49 ` Uwe Kleine-König [this message]
2026-06-30 17:13 ` Selvamani Rajagopal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akPy0zCESKoGgsF1@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox