From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E585735B636 for ; Tue, 30 Jun 2026 19:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782846916; cv=none; b=C3k4mmgiCWtCuG2bYgBq0sKhbTRPxCmgmoV/HjZRNtwxxIOKrttoSAF46bEk1EACmk5Aj1fAGH2tkNer+/vQXh5OCTLdeNDF79K9og5DPVfrqZ9o4PmYagam9NySxbR56AcdxiVqm8q3SAkf6oCUrTQ7xna4liAwKqQuIT99RrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782846916; c=relaxed/simple; bh=mEUU4k/pxnVZW4pACXwnVdN0YhBTqZv8x9zqIafDgcA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HCxG8vnN6sFf/84rKmcHxQeOsfHhWJg/QdY+7/DDgm33KbfHddNdBSSxygkDVztF1J9vc7WFDXa3zr4BuX3DUQ9DAZRyrR971qWwTZwdiN7G2j4j5DXJeGqQuoBOueirqW+R3k+Q3YQEworoB9nWAbiz04i2Fn2iFQ9A7YqgxZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WiRDK+l6; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WiRDK+l6" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493a5d32e8cso30602585e9.1 for ; Tue, 30 Jun 2026 12:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782846913; x=1783451713; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zuBq1qAG84ZA4NHRdfFmCaMLtFQOMgrbPaV8NPBW72k=; b=WiRDK+l6HRvApjZB1/kAUCWarT/bgLY4n0LOtdXENX6mpoSevUHgVbINBPRDo6cgpK JWCQPjVv2t2PQfqvxVuwrNWFjXmgJcV33HrR3jvc3/WT5ZRnf5TJUMFGDc2ROc8oGid6 /JMbY+hZpDUwyVo5Ztl3l5O0UYaF8kFgJm3242zUSbBahfEzx78I9VqOCFg6Noix4gPQ 3TGdFD3VQzj/d3ndo+QhSVo2c6wpLRButUuN6dYi/2NXyt9Sb1PxzWvkO1NpxcUmhgX4 TP8pZbdMnWJuGf7MIgl3Y9hZE9xeQyO93pIvtT/jvA0PbJ45/i0ACJ61c/7d13x+YyKg l5Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782846913; x=1783451713; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zuBq1qAG84ZA4NHRdfFmCaMLtFQOMgrbPaV8NPBW72k=; b=bGmiRTvh5I/LXCdQ/yTmEukZy3VR2iRSDXlA9uq1d9Ub4/yZXLkiwkuoKkvqSqEJmV /RdKgT8IWEB9o7TDZHnnxu5rfDhJoduPt3gKBZtHvvtzsBtCJk9JRa0S9hKenjIjNgFm SrvDLeqLkjwyEBPAL7QuwcneQR5b7REcrqar1djmnLgMFgsmPXkGycfmSnl60Nuuy9QK Pid9yA80Hv4wXVXENOAA6n+qCj4bPESyZ/HJ9CaRZhMePgCqc1XFYyUFC8hudj4CIiMg 9KptOQqtzeiY8rpaoVq/NeU6nf0iQAyp/Y6kr4WV9l1wKwhm3WEz44Z5/EhI64SsASOD W1+A== X-Forwarded-Encrypted: i=1; AFNElJ/zKsraHRAuf99W7GtAxHhO7pasEC1koVJLIRPixChu5WQgtSmebqjIjbbUt/WBPj+B02fQovPAZP+LAis=@vger.kernel.org X-Gm-Message-State: AOJu0YwsGHwDIsZQqIdrFIEXfaPKHYjsMiLT7WC822naMuUxBmgK4p/N kBoeZXh/l1pHQ7PXZLoEPYmUcW/fPbii3yu2+LRaJ3ZoOh8XqfCWEaE= X-Gm-Gg: AfdE7cl3G34m9E71CxokcntO/+bdneC7R0hw6HIJ0DBzMRFzlfLucYTZ11vnPHlH83r z5XrAjgvjvmAmSG8JYYo/go5tXoeNWW7CFk4IcQslUOjUGIWRlF5ihS+2lJ7ELzl82+myt3KcRF ew1AygTNkE08BEzmLKF6Is74NSIy/S5mcn4IHwNDjK/+YnJqUcAkQoAVA3u6HVzEqZRLMMzRO/M +g9ncqhVWaE/OCIvGD0zO20mk9yTfoAS7CyGKJR55nLz1lFaTqKvPmfp3TIcO1a4U80ZZJa+55P eo3Zf57mQNTp55rMg5Q8ySGtxbamjkeo7ZZ3fXm3lQ2rsszISC9HknSfi9rCyPyuGhggZUmM4v5 jcwG3HwxCmS0ae6qvoghYjEu2Ylnhap2NsVkcR/MX9Wx5WAgZqaNJqAtXffdsavahUAWT16brnr QLUnFOu+fBruXR55Ydnpp2FwDhfC/gTCWnuacKXKOHPCxN+tLfpP3nvekRrXRPoFve4YqMjBXjV 41t X-Received: by 2002:a05:600c:4e90:b0:493:b962:4abe with SMTP id 5b1f17b1804b1-493b9624c71mr60343825e9.36.1782846912994; Tue, 30 Jun 2026 12:15:12 -0700 (PDT) Received: from lithos ([2a02:810d:4a94:b300:989a:410e:90cf:c762]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d1f1asm17141585e9.7.2026.06.30.12.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 12:15:12 -0700 (PDT) Date: Tue, 30 Jun 2026 21:15:05 +0200 From: Florian Fuchs To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Adrian McMenamin , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: maplemouse - set driver data before registering input device Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 29 Jun 22:47, Dmitry Torokhov wrote: > Set maple driver data before calling input_register_device() to > ensure that it is available if the device is opened immediately and > the callback is triggered. > > Cc: stable@vger.kernel.org > Assisted-by: Antigravity:gemini-3.5-flash > Signed-off-by: Dmitry Torokhov > --- > drivers/input/mouse/maplemouse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c > index c41182766538..0c8f7d1b02aa 100644 > --- a/drivers/input/mouse/maplemouse.c > +++ b/drivers/input/mouse/maplemouse.c > @@ -88,6 +88,8 @@ static int probe_maple_mouse(struct device *dev) > mse->dev = input_dev; > mse->mdev = mdev; > > + maple_set_drvdata(mdev, mse); > + > input_set_drvdata(input_dev, mse); > input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL); > input_dev->keybit[BIT_WORD(BTN_MOUSE)] = BIT_MASK(BTN_LEFT) | > @@ -103,12 +105,12 @@ static int probe_maple_mouse(struct device *dev) > goto fail_register; > > mdev->driver = mdrv; > - maple_set_drvdata(mdev, mse); > > return error; > > fail_register: > input_free_device(input_dev); > + maple_set_drvdata(mdev, NULL); > fail_nomem: > kfree(mse); > fail: > -- > 2.55.0.rc0.799.gd6f94ed593-goog > > > -- > Dmitry Tested-by: Florian Fuchs Regards Florian