From: Dan Carpenter <error27@gmail.com>
To: Ruziev Miraly <miraly.dev@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: make g_fbmode array const
Date: Wed, 1 Jul 2026 08:06:48 +0300 [thread overview]
Message-ID: <akSgaOdkxQHL2R7t@stanley.mountain> (raw)
In-Reply-To: <20260701041423.7881-1-miraly.dev@gmail.com>
On Wed, Jul 01, 2026 at 09:14:23AM +0500, Ruziev Miraly wrote:
> The g_fbmode array of pointers to constant strings is never modified.
> Mark it as const to move it to the read-only data section (.rodata)
> and comply with the Linux kernel coding style.
>
> Signed-off-by: Ruziev Miraly <miraly.dev@gmail.com>
> ---
For old warnings, you should assume that maybe it's deliberate and look
it up on lore to see why.
regards,
dan carpenter
next prev parent reply other threads:[~2026-07-01 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 4:14 [PATCH] staging: sm750fb: make g_fbmode array const Ruziev Miraly
2026-07-01 5:06 ` Dan Carpenter [this message]
[not found] ` <CAOW+FoFQVdBXMVfF2n2eV0_2u71apaQM8fV+uO1JVasqcqq-vQ@mail.gmail.com>
2026-07-01 7:26 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-06-21 4:44 Arnav Kapoor
2026-06-09 1:17 Brock Haftner
2026-06-09 6:12 ` Ahmet Sezgin Duran
2026-06-10 0:58 ` Brock Haftner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akSgaOdkxQHL2R7t@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=miraly.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox