From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp01-ext2.udag.de (smtp01-ext2.udag.de [62.146.106.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDD84218B8 for ; Wed, 1 Jul 2026 11:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.146.106.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782905968; cv=none; b=Ep2QH22fA2jpJwTXqmgr9OqX1imgTios8zu1ayMk7DnHpnYmoJ7p3rEk/JRnjhdnioJ5nU11DPHC4bb31iS0FrGYqltHmiWiOGl6eStTkEFQJeERNHfEPEEu9J1mLWLAbhc6+L1ehrQfw4YVjLLCwQCbv+7sF4JvlmHoysZUq+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782905968; c=relaxed/simple; bh=uCej0eMw8YQZOH+KmOmo0z+iVjeQ/NOKURCGRT+G1Wc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eNyihMbuPC2/Rssr+htxPrpDUg/CetgiaRnyU8vzN7C2Yl6RoxYMToTWGcRmzn2j8Wq8gHCDRJrjFfgOKKtGJ/m51O+aAmNpb2cU0dVm6++4rOBixGWrSDzkgEuxBae8VHiItW0F3vaygpxWKsRT1YsX+DLtBl4348oX5dixZao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=birthelmer.de; spf=pass smtp.mailfrom=birthelmer.de; arc=none smtp.client-ip=62.146.106.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=birthelmer.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birthelmer.de Received: from localhost (024-062-210-188.ip-addr.inexio.net [188.210.62.24]) by smtp01-ext2.udag.de (Postfix) with ESMTPA id 53836E0682; Wed, 1 Jul 2026 13:39:17 +0200 (CEST) Authentication-Results: smtp01-ext2.udag.de; auth=pass smtp.auth=birthelmercom-0001 smtp.mailfrom=horst@birthelmer.de Date: Wed, 1 Jul 2026 13:39:16 +0200 From: Horst Birthelmer To: Luis Henriques Cc: Miklos Szeredi , fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Matt Harvey , kernel-dev@igalia.com Subject: Re: [PATCH] fuse: cache POSIX ACLs when setting them Message-ID: References: <20260701110052.5309-1-luis@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701110052.5309-1-luis@igalia.com> On Wed, Jul 01, 2026 at 12:00:52PM +0100, Luis Henriques wrote: > When setting an ACL in an inode we can immediately add it to the cache. > This is a small optimisation, as currently an ACL is only added to the > cache when reading it again, which involves an extra GETXATTR hop into > user-space. > > Signed-off-by: Luis Henriques > --- > fs/fuse/acl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/fuse/acl.c b/fs/fuse/acl.c > index 31fb50e16aed..c2584bb75ec7 100644 > --- a/fs/fuse/acl.c > +++ b/fs/fuse/acl.c > @@ -155,6 +155,8 @@ int fuse_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, > */ > forget_all_cached_acls(inode); > fuse_invalidate_attr(inode); > + if (!ret) > + set_cached_acl(inode, type, acl); > } > > return ret; > LGTM Feel free to add Reviewed-By: Horst Birthelmer