From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76CB2371D07 for ; Wed, 1 Jul 2026 20:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782939343; cv=none; b=KTRUotPQaJnZ+5MNW9y1BVpWmmt03a97VkgB6Cg4GGUQZSMF3nXhGgMllcNIsQTkAt5X/stSKoy+F0paPURA6/7C427cNQprZBlX3OhP/R4MFVG3cSFL3Tt+2ylCKHFTwxVSb10Mo15zuHHNObZ1jwN3UInV/J3AxieMLbonBBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782939343; c=relaxed/simple; bh=FqZMsBuYJd2/BcwWY+U/gdKv5IzDxRMftE3Mwk/Bxgk=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DSQwfCiwEyLoXE8MwbSn8mDaN24Q7EhMkzs8QuD1svdoMCf6nLMPmwf4IaqLIC6k3ddfrZpUt2aluXP/p9CgZP47atOGzAlOPDDetqOykOvUAnFFerX/3pFC2aaFEAVRIjl1nB1jb5wJJA+RJJvhWetqwcW96lHnYZfVlweOHoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NS+/Tox6; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NS+/Tox6" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c9e0b89e228so410394a12.1 for ; Wed, 01 Jul 2026 13:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782939342; x=1783544142; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=HzyayHOctkQ2V84W5loiQdWT8uv8bQ5hqh0s1FE+kT8=; b=NS+/Tox68Po5J/Y0PlwBJqwt/T3QHxv9q2KikU99nGOwMAGKFTs29uW0sNhoulFxCT dqzKbCsbYOcMm6Z+hEEnFXZmyu3DidCF+RgkZifT1g6SK50q9JfaQytEaLc9NOh7Vwsr 9g8Pk6TkWDEmoib/IkyKOxiC4LO5SBprAJV+TK2NE9cOYY0+VJ87BXJUY/n5lucIchwU bBY90m9KXMx7mPT5uSNbu3W1aRDK9Ftsc00AhzI9UKtnJhOE0hyZ8Eeo/p0olj1+pYoC Fbgke3CcK7Wrq8s1VzHU0jNNp72edk6xDXDUIbOU4dPlmDGoPLFaz3iENFfrXeHzL92M BlWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782939342; x=1783544142; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HzyayHOctkQ2V84W5loiQdWT8uv8bQ5hqh0s1FE+kT8=; b=Z9yfR+6BqB9mACbA11P1r4Rq9+jU7V12TvbsGIi9HBEftqdgA+Ysa9QFBssODw3vLZ KrFC6KHPGr0aItOC6T/41cl0bWB6mvdw+pTMK1AU6v3cPxEkkEFBP9FORdxWrT1w8PTl PmJH79ieMMIiSIKXct/s8LJndUIez2KI2fCdfSXQdfb7w/QnnpKoPm5Mkj53r8deFS1l OhgAPqKJcAlppIGec5jN/fSCi2AD7TKPHh7YCYcEznKpuDaRdUaK3B6SVHkNrY9YiC9j N5Rfel0ttowQgtuKwgZ+SEk9sQUZXKtSdrurRlGYxccC9hgp0RTCENOxqqCVMoEsNFAh jvEQ== X-Forwarded-Encrypted: i=1; AFNElJ8+0qjKsrggJpOFehIqQcUrpRXuU37955Mhqp+AlK+ogZq0tXacj5pKgnepvNzkc6H0exnhgtTSoFQO748=@vger.kernel.org X-Gm-Message-State: AOJu0YwNqWqlKW4oDqey1sx0oLpZ3woD4w7Rt6dIRAeEGrshHgb8PSOo zKFnxh+HP+ig1JIEgSVJkPAajy4xzPche808g745014/RooTnXU3mDat X-Gm-Gg: AfdE7cnEmr8NIbpwMWyCWQ0laZHNvy2eUokdqR6RLp9yohPV4MfoZkB+/Pei3ykJo17 LeCd8kxXSlGukwbmOa46xnVckBDiyK61qgGCLKzmzt+Kr+icZicOAdaIPRAEEJb5RJrfwUpa5Ar U+CTWiGjuVA7vse7pNK3vFXyHlRW77ZPxP4WwryJMR/kSXvr+B8QOnCxm8B1cVBHSBpcYhVrL8K UcvkuIpNEmoZ7IO8cuZon9ZGt1axseKNvzpEprcxAMJC/n1jjwXn22qgP0d9NpPUAAqJ72rOpmM KbxFKwQFBeqZ7IjC9J/gNZaRusyxu0gPpWpo+nB95cEqjUwxjnhM8pvwWz/JSSjit6yIGBhX0f8 kEa7AKGebIs4v2GA10ewOKqhB4mZ43IEPqZ7w7dSMEvjWNKVCewvk9ojUkKxGugP6FDZiYdwXPT ylW5QQ0MWV X-Received: by 2002:a05:6a21:390:b0:3bf:c126:baf2 with SMTP id adf61e73a8af0-3bff42e3e34mr2607570637.47.1782939341671; Wed, 01 Jul 2026 13:55:41 -0700 (PDT) Received: from localhost ([216.228.127.129]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b7b8e3dsm1350231eec.6.2026.07.01.13.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 13:55:41 -0700 (PDT) From: Yury Norov X-Google-Original-From: Yury Norov Date: Wed, 1 Jul 2026 16:55:39 -0400 To: Sang-Heon Jeon Cc: akpm@linux-foundation.org, Madhavan Srinivasan , Michael Ellerman , linux-mm@kvack.org, Andreas Larsson , "Christophe Leroy (CS GROUP)" , "David S. Miller" , John Paul Adrian Glaubitz , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Rich Felker , Vlastimil Babka , Yoshinori Sato , Yury Norov Subject: Re: [PATCH 3/4] powerpc/numa: set node_possible_map from node_online_map Message-ID: References: <20260701171851.2447626-1-ekffu200098@gmail.com> <20260701171851.2447626-4-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701171851.2447626-4-ekffu200098@gmail.com> On Thu, Jul 02, 2026 at 02:18:50AM +0900, Sang-Heon Jeon wrote: > mem_topology_setup() intersects node_possible_map with node_online_map. > Nothing sets node_possible_map before this, so it is NODE_MASK_ALL and > the result is just node_online_map. > > In preparation for changing node_possible_map's initial value, > mem_topology_setup() no longer depends on it. > > No functional change. > > Signed-off-by: Sang-Heon Jeon > --- > arch/powerpc/mm/numa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index f4cf3ae036de..2fdecae90a01 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -1179,7 +1179,7 @@ void __init mem_topology_setup(void) > * that we expect to make use of for this platform's affinity > * calculations. > */ > - nodes_and(node_possible_map, node_possible_map, node_online_map); > + node_possible_map = node_online_map; > > find_possible_nodes(); And in find_possible_nodes(): for (i = 0; i < max_nodes; i++) { if (!node_possible(i)) node_set(i, node_possible_map); } So, assuming the code reaches to that point, you unconditionally online all the offlined nodes. This doesn't look correct at the first glance, and definitely it's not a "No functional change" type of things.