From: Mike Rapoport <rppt@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org, kernel-team@meta.com,
david@kernel.org, osalvador@suse.de, akpm@linux-foundation.org,
mgorman@techsingularity.net, hannes@cmpxchg.org,
vbabka@kernel.org
Subject: Re: [PATCH] mm/mm_init: handle alloc_percpu failure in free_area_init_core_hotplug
Date: Wed, 1 Jul 2026 23:14:15 +0300 [thread overview]
Message-ID: <akV1F0yx593BwaN3@kernel.org> (raw)
In-Reply-To: <akUwUv_rrgmRP4bK@gourry-fedora-PF4VCD3F>
On Wed, Jul 01, 2026 at 11:20:50AM -0400, Gregory Price wrote:
> On Wed, Jul 01, 2026 at 09:38:57AM +0300, Mike Rapoport wrote:
> > On Tue, Jun 30, 2026 at 05:40:39PM -0400, Gregory Price wrote:
> > > We miss a failed allocation check for pgdat->per_cpu_nodestats, which
> > > results in a NULL deref when we offset into the per-cpu area.
> > >
> > > Propagate -ENOMEM up the stack and leave per_cpu_nodestats pointing
> > > at boot_nodestats so a later online can retry the allocation.
> > >
> > > hotadd_init_pgdat() returns NULL on failure, which __try_online_node()
> > > already maps to -ENOMEM.
> > >
> > > Assisted-by: Sashiko:unknown-model
> >
> > I suppose it's rather
> >
> > Reported-by: Sashiko <sashiko-bot@kernel.org>
>
> I honestly wasn't sure here, Assisted-by is the tag for LLMs lol
> i can change it
My understanding is that Assisted-by is for cases when you drive an LLM to
create the patch.
And Sashiko reports issues so I believe it should be attributed just as
kernel build robot with Reported-by.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-07-01 20:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 21:40 [PATCH] mm/mm_init: handle alloc_percpu failure in free_area_init_core_hotplug Gregory Price
2026-07-01 6:38 ` Mike Rapoport
2026-07-01 15:20 ` Gregory Price
2026-07-01 20:14 ` Mike Rapoport [this message]
2026-07-01 8:35 ` David Hildenbrand (Arm)
2026-07-01 15:05 ` Gregory Price
2026-07-01 16:54 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akV1F0yx593BwaN3@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox