Re: [PATCH bpf-next] bpf/selftests: remove lirc test

[Sean Young <sean@mess.org>]

Hi Bastien,

On Wed, Jul 01, 2026 at 05:26:20PM +0200, Bastien Curutchet wrote:
> On 6/8/26 2:51 PM, Bastien Curutchet wrote:
> > On 6/5/26 5:21 PM, Sean Young wrote:
> > > On Fri, Jun 05, 2026 at 06:39:51AM -0700, Alexei Starovoitov wrote:
> > > > On Fri, Jun 5, 2026 at 12:58 AM Bastien Curutchet (eBPF Foundation)
> > > > <bastien.curutchet@bootlin.com> wrote:
> > > > > 
> > > > > test_lirc_mode.sh fails with the following when run from the vmtest VM:
> > > > > root@(none):/root/bpf# ./test_lirc_mode2.sh
> > > > > Failed to read decoded IR: Resource temporarily unavailable
> > > > > FAIL: lirc_mode2
> > > > > 
> > > > > As part of the ongoing effort to get rid of any standalone test, this
> > > > > script should either be fixed and converted to test_progs or removed.
> > > > > 
> > > > > Remove it.
> > > > 
> > > > cc Sean
> > > 
> > > I've sent a fix to for the test in a separate email.
> > > 
> > > This regressed a long time ago; is anyone running these tests? There is
> > > not much point to selftests if they're not run by anyone. I should add
> > > them to linux-media CI, but is anyone in bpf running them?
> > > 
> > > I am not familiar with test_progs, what's that?
> > > 
> > test_progs is the selftest's application run by the BPF CI for every
> > patch series sent to bpf@vger.kernel.org (or PR done to the BPF github).
> > It's made out of the C files located in tools/testing/selftests/bpf/
> > prog_tests/.
> > 
> > The shell scripts under tools/testing/selftests/bpf aren't run
> > automatically anywhere (to my knowledge at least). The goal of the 'on-
> > going effort' I mentioned is to get rid of these scripts by either
> > integrating them to the 'test_progs infra' or removing them.
> > 
> > If you're going to add this script to the linux-media CI, maybe we could
> > remove it from here ?
> > 
> > 
> Gentle ping: would it be OK for you if we remove the test from here ? I've
> seen your fix, the bug was introduced in 5.17, which means no one had run it
> for 4 years. Given that, I'm not sure it's worth the effort of porting it to
> the test_progs infra.

So the test is useful and should be run regularly. It should be ported to
test_progs or moved to media-ci. I haven't decided yet which way I want to
go. I'm just a bit busy right now, I'll get round to it soon.

Thanks,

Sean