From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B408B386C1B for ; Wed, 1 Jul 2026 17:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782925776; cv=none; b=ATbDLs4to+au41MfBVbHt7jeGBSRvXDcNpLgJa6ID2m8t6XDzI7LfKJ0cUCv3rTGVLTh7emhsP2eSjtMWBrmGBcRIE/JPsNM2V0dshPVANh1xmz+iE9Y0gSU5br0Cc4way9b7fUzDWMOuZHNotobRZ088uvyLsHbTUqCVeHBilk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782925776; c=relaxed/simple; bh=pGdTe5jucAj6lC+EhBxqPdjiXtKkjSbna21RWhM6Epc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C4jdaMEVkmO4rTWgdqyHgC5REZnS5xosnJteq8YnJ/zhgY78zm/U+QYe+7kDngtVsHSuuZmeEI+nG+y46C9Jn7TM+hDgfdBsnBGwq2Xgojte/h9dE13EjMNJTtEvrMqkLsogr8TWDgXsHXtrEPRt5NPsi7kh++E+uoHTC8x4MFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QwwZDfFw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QwwZDfFw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2013E1F00A3A; Wed, 1 Jul 2026 17:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782925775; bh=ajykTxkMfwB9zl67Z4jf7zzFk36k01o+dotaOXLVQWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=QwwZDfFw+hzSBMcbO+Pl7Mxfx8FsnipBW65084+NPq5QtggZbnZiVIPJdZ28BoVNz GCp6XCvhipBWnIJnvlfmvofRPM1svCbjtZw3KzzTjCZ5IHh2GcuBNnwiLXyD8450Dc AeDjwe4dMtg5nR/+mIvm3cb2XWogXj71FcJF2jWdHISgj4LhEb8hWQgee6YmeA3ZD+ 7MMtVK0p1Cyf0YPNvy/bU/X31Q0LgawsB7uUvY5zh0yW1NHYpSKCIh2EOixH4b/04r NuK/0DgFKVEhVVcD62AHvwtjyxzUJw273qSvWlf10Q6XOXQq2zRKIsamnObTRciSA2 mY2tojhEc2Xpw== Date: Wed, 1 Jul 2026 10:09:33 -0700 From: Oliver Upton To: Jia He Cc: Catalin Marinas , Will Deacon , Marc Zyngier , linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , Mark Brown , Sascha Bischoff , Fuad Tabba , Anshuman Khandual , linux-kernel@vger.kernel.org, Bin Guo Subject: Re: [PATCH] arm64/sysreg: Fix BWE field encoding in ID_AA64DFR2_EL1 Message-ID: References: <20260630222347.1449737-1-justin.he@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630222347.1449737-1-justin.he@arm.com> On Tue, Jun 30, 2026 at 10:23:47PM +0000, Jia He wrote: > Commit 93d7356e4b30 ("arm64: sysreg: Describe ID_AA64DFR2_EL1 fields") > encodes the FEAT_BWE2 value of the BWE field as '0b0002'. Binary > literals only accept the digits 0 and 1, so the intended value is 2, > i.e. 0b0010. > > The macro generated by gen-sysreg.awk currently expands to > #define ID_AA64DFR2_EL1_BWE_FEAT_BWE2 UL(0b0002) > is not legal C and would fail to compile if any in-tree code referenced > it. At present no caller uses this enum value, so the kernel still > builds cleanly, but the bug is latent. > > Fix the typo by using the correct binary literal 0b0010. > > Cc: Bin Guo > Fixes: 93d7356e4b30 ("arm64: sysreg: Describe ID_AA64DFR2_EL1 fields") > Signed-off-by: Jia He > Reviewed-by: Mark Brown Hah, I screwed that up pretty good! Reviewed-by: Oliver Upton > --- > arch/arm64/tools/sysreg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index bc1788b1662b..7cb61aca3797 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -1806,7 +1806,7 @@ Res0 15:8 > UnsignedEnum 7:4 BWE > 0b0000 NI > 0b0001 FEAT_BWE > - 0b0002 FEAT_BWE2 > + 0b0010 FEAT_BWE2 > EndEnum > UnsignedEnum 3:0 STEP > 0b0000 NI > -- > 2.34.1 >