From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796A43EC2F8
	for <linux-kernel@vger.kernel.org>; Thu,  2 Jul 2026 09:39:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782985168; cv=none; b=HDFUCUZ9OX4YoxisXJ7pTq+CPpQB290wnCHS8faxfNaLCpP2FnHroiJwo1xZj+alDiURIga7HLzME3REWZcW+wG1J6bfZLBL6mZC0Tvhm0dTDyUXRxc1SdnBBz3VEASRTRqxfZBqq0bZldrmlE8htVeICxPU4H77tBfTUBGA/gU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782985168; c=relaxed/simple;
	bh=3aqyY1qmD77Wr7UbIFr4rpxXhIgOubWT6VaebDOqpT8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=I+kL5Cpr1X8n8i05vE66bC03RVY4LV/OpMudX1hMEsWbCsO7FYc31w19d36CNiL/Ymu1qE4cSJswEzmGjTMKqhO9C+K18MFOOJXwLDJu3yPBiwMwBG8HMroHiahQxP4VrQifaHNNkXHEm1r+yY60LR/j4ZS/ebLrkGrmWU/tMRU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wy+Xn1D+; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wy+Xn1D+"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05F641F00A3A;
	Thu,  2 Jul 2026 09:39:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1782985167;
	bh=pkDuCI6sUDLyDgXUNnIpcUvS5noti/w347y7Uzulnwg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=Wy+Xn1D+50Y7GQ84CCh2O1mPTAYDCzNxd509k4Jj3P9/VlAjVCRsuP+Oa4JO8iG+n
	 qETaJ9/aeavpEtZIP289Bj/jwQ3E+2YKiaswTekFtIS6O2Ob4F3/zsfg6Jz6AOQLjW
	 9NaJxXGskL+kUmMKmfwMn/5NBR3YqHr+LmIaiW0d5wmJSGQvxst3vC+wyekYO+8oS4
	 OEmn2ZlOZoT2ItbjpyVq32MVjzEbCLptamGD4sR8ryP4BsbiwLY8e3kc0NESbcYqr+
	 VMFu+A4mo/imQJdw8YV+obC9Q2cXn5zqEF1HFxDYvWBMHaA2jPiSkYy+tBZ9t28oeU
	 Yp6Uh6KsXlNew==
Date: Thu, 2 Jul 2026 11:39:21 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 13/32] x86/featctl: Stop using 32-bit MSR interfaces
Message-ID: <akYxya2Iel0xnEhG@gmail.com>
References: <20260629060526.3638272-1-jgross@suse.com>
 <20260629060526.3638272-14-jgross@suse.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260629060526.3638272-14-jgross@suse.com>


* Juergen Gross <jgross@suse.com> wrote:

> -	rdmsr(MSR_IA32_VMX_PROCBASED_CTLS, ign, supported);
> -	c->vmx_capability[PRIMARY_CTLS] = supported;
> +	rdmsrq(MSR_IA32_VMX_PROCBASED_CTLS, val.q);
> +	c->vmx_capability[PRIMARY_CTLS] = val.h;

Please keep the original assignment that puts this into the
'supported' variable - which semi-documents the meaning of this
field - even though its use is arguably minimal:

	rdmsrq(MSR_IA32_VMX_PROCBASED_CTLS, val.q);
	supported = val.h;
	c->vmx_capability[PRIMARY_CTLS] = supported;

> -	rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS2, &ign, &supported);
> -	c->vmx_capability[SECONDARY_CTLS] = supported;
> +	rdmsrq_safe(MSR_IA32_VMX_PROCBASED_CTLS2, &val.q);
> +	c->vmx_capability[SECONDARY_CTLS] = val.h;

Ditto.

Thanks,

	Ingo