From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E83433E9F for ; Thu, 2 Jul 2026 15:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783004728; cv=none; b=C7hV0WjtG5imcrgyj7+EMDeVDi7Wd1xW35CurnrfrEJUmfUzWGVYlgtgECnnb1pVqqIDYOnSqAgHFHRho90rkYaiEzbVqN94JaJTb0ahLmPLoD2qsV63aK6l+LrymTlOD2pF2Y6x/Mx3gTQJFyfBp3z9oOkqYv7mJr9hdzbyleY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783004728; c=relaxed/simple; bh=YCpC3z2Mm9LjQyPLfuLvO28v7VtBiXIyE2W8Vn+gKdw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=foiJ3zXIuGRqqX8KC/jOY8gy8xZtsFB6N20K8MFiZrYpyhPlESjKxBHi40LOlYioAOvBSCy/ITiM/V7AIKzhjMkS9XroYyQsWQvKvywqwtpjk6zqndcqizFo5wMhGUysGo38PztIwuEJVDMlmi3n9Nb2Oq6y0/DMJV+gDQ7naRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t9FftbLo; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t9FftbLo" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-51c10e86e52so627411cf.1 for ; Thu, 02 Jul 2026 08:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783004725; x=1783609525; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XSio1tefA8hn2ItHYltO++r3B3H0zvF625Ng9n3K4Tk=; b=t9FftbLoZUG1rfhrHFsaZsTjxV//eOBcA5ozHm2lUdZQtHY1v8biYip0r/8l4W4mbM vxAmipVddlixNX9WmCTn7Er/JtTsI5bV6+8o0XfVRz2R+2Kdgucn1ZjYxP/cL+liMdPb 6mYINYRNsqJ5E3O2WU7UE900Ozr3XveRCNYYUwHbQNyCKoAokdZDzsWj2vUdPImx3ttc WS0S5NjrnziBQwWUQqTG1AHnLHJ+pky4zZE/MjqAYOyUkfidzqG8/SnPIyc0RGbWhiFF ViMx8KmiSPYJsNHI1tTzTI/JdF5xXTtLQRISFGsWVAYC1yea9VRY/HtPDtIq7wMLqkjs GaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783004725; x=1783609525; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XSio1tefA8hn2ItHYltO++r3B3H0zvF625Ng9n3K4Tk=; b=h77VgyF10ptYKvi/jtpbKFdWE64/ixlbqDDD+/b1zNObMCTzAuVksiB3UmCDErjd2b vmZDk7f/ydyuNhxE0QuvCl9MavLFXw2rEV+VC6P/IBQE75wbOqp5spWpEv18my+P2dy0 KHYq5rWWTIA/+8du1Kqlw53e96KcbK2azvEKmZwHd0ecJvU2MJj/zOs/HElEKjMpSJJ9 M1BGsqUeXJVoW8tL3VJqjiFmRQKuxKVoa5ga8s7NWy7mEPTUy3eHAziWzq3TXaGkkQMQ jQe/ilNMVutrPkamHzAgALi70k+sHkcDse90CUSFILyUZ9ggGiCm6eGswLUApsmARvxh Btjg== X-Forwarded-Encrypted: i=1; AFNElJ8f+YkLAIzqW/jF4y3RbceC+nuyZmOcSq9QGqKXExqvBfs1Cx+lTjZJtzQjlmrOwuDFuKFLUFppa6M85zA=@vger.kernel.org X-Gm-Message-State: AOJu0YwfhQeE7GszIZNaoxa9otfBvPEx6Uk92JPv5Rb/1DN3y0fFuBSF CW3d5fnqp2WUm/HE4SniQrSAHnCk9scnj/EBW4rsJAsKCrNp29LCyXxXMrGkwkBHpg== X-Gm-Gg: AfdE7ckXw9A4eCEGpSom/YcL66+KAVnmJn151yljNwYFdYvmk/28k0UQpL7M+OmI7rI FQYAMrkgPLjzkU4MhZw8PYhgplpk+6K+aCcphuCWRXqhEdNjURRHHKvmndnKNyIqAiAJTuPH4sf MM3dI2X+WYl+Sp2406dwB9bWMyLn46sR/NrZW3oooIj/KfsH5PpBuv4v0yinJ1sBV/J3rvHf0Zq udBZ+Zj6P93i4FAVH2zASmARaoh78ocUqMdzRWLhGYofwyqQnqqGyuwVs8OsmZjhJHc+7wIcr+j dC3ImGw0pj/Wbmz5WH9iBOWG14q1sl3MMQ08pOb88/qhzsXopGVyKG98qWKzpbYa6zbg+uJprKv Cm3KlFoRubdcvZ4QazCPACOdIfkbJ2EGyQ22ug4fdybQaJiTb4fgbkeLnRzkw4VyWJyeJz+uVOq dFSfkdPF0XRkx6FZLBHyzvHDXU9Ftcf62z/77/0LCbITUhXTg= X-Received: by 2002:a05:622a:1811:b0:51c:d16:b48e with SMTP id d75a77b69052e-51c3191132amr7766811cf.22.1783004720401; Thu, 02 Jul 2026 08:05:20 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cbec93a70sm3241630fac.11.2026.07.02.08.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 08:05:19 -0700 (PDT) Date: Thu, 2 Jul 2026 15:05:12 +0000 From: Pranjal Shrivastava To: "Kiryl Shutsemau (Meta)" Cc: Will Deacon , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Nicolin Chen , Kyle McMartin , Breno Leitao , Usama Arif , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iommu/arm-smmu-v3: Shrink command/event/PRI queues in kdump kernel Message-ID: References: <20260702112825.781750-1-kas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702112825.781750-1-kas@kernel.org> On Thu, Jul 02, 2026 at 12:28:25PM +0100, Kiryl Shutsemau (Meta) wrote: > The command, event and PRI queues are sized from the maxima the hardware A minor note here is PRI & EVT queues are disabled for the kdump kernel (see arm_smmu_device_reset). We could just mention all SMMU queues are sized [...] in the commit message. > advertises in IDR1, which can be several megabytes each. On systems with > many SMMUv3 instances that cost is paid per instance and adds up to tens > of megabytes of coherent DMA in the capture kernel. > > A kdump capture kernel runs from a small crashkernel reservation and only > has to drive the few devices used to save the dump, so deep queues serve > no purpose. The queues carry invalidation commands and fault records, not > DMA data, so dump throughput is unaffected; a shallower queue only bounds > how many commands may be in flight before a sync, which does not matter for > the capture kernel's small device count and modest I/O. > > Clamp every queue to a single page when is_kdump_kernel() is true. Doing > it in arm_smmu_init_one_queue() covers the command, event and PRI queues > in one place. The command queue still holds at least one batch plus a sync > (256 entries on a 4K-page kernel, well above CMDQ_BATCH_ENTRIES), so > command batching keeps working. > > Suggested-by: Kyle McMartin > Signed-off-by: Kiryl Shutsemau (Meta) > Reviewed-by: Breno Leitao > --- Apart from that. Reviewed-by: Pranjal Shrivastava Thanks, Praan