From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E616143148B for ; Thu, 9 Jul 2026 16:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783613302; cv=none; b=AnDQveBgfKbkncOlQtNNCrqWYuKQeCYdV0EdG47CeJNdyZKAsfo665aHQ5t8ZtaVIsx0xKoWPBaZ2A1zsZC4PlRP6oOTANo82dx59YshxPRk1+dbr/yyDhSjokjLrmcsU93adMtEr6OxtyNSNi+sw9IX4QUWJCVkgAjZkyXGFCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783613302; c=relaxed/simple; bh=O4qNM2C0nbt2VbBlFC31/e1eUeaxHOXJ2oTMrSmpe0E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XHcnsebvW/ynpDURHp64AIXbAg8YK8Ja8mdMJZ1VIvui5EMzg00k55B455/lClLZAla+hF+1QsHAr07IZc/XBSnpxJQRDHNt9NLdJGFiiAk5uqhU18meDQPrgANRr2REErgm8CJB9wY4daVrg3696AI1X04WgSUruhBqCI+EYDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q3CX03Bo; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q3CX03Bo" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493b77b150aso16800185e9.2 for ; Thu, 09 Jul 2026 09:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783613296; x=1784218096; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=E6idM/+ud/Xn7x4a5piPI4eTdbJ2+tm5HROj0RrFqGw=; b=q3CX03Bo1EI6Xj17QBACUu2hZO9GeMn6jlSukLMs8bE2/Iarf+HuJ+nCuuKLX5QbMn 9Qd/ntD2Iq2J8lS4XEiA6AtJvZo5+rNeKthQtJ9Vk/6xdypBYmX30pObmjxoZ3IeCBg/ QElwVDrqKoR/SwVA4At4rg5b47OidgzvcOLVRKsRTrfqggsFMnwywQ5G4znG+nQ/AH/X h7PBPMlfPXXL7abEc/NBFZHROrh9g4X8+XBdWdxYtM06oA6rY6i3K6zn+n6nUfFgeQdz LT8jT4aEcBC1bKq/LNGmPXYlWz58fJLfq5guTIfwgCSWlNb5XmNmT6pEsXo2ccUdNMuY awMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783613296; x=1784218096; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=E6idM/+ud/Xn7x4a5piPI4eTdbJ2+tm5HROj0RrFqGw=; b=KbMqGXzeWt6wQvCvgVgAqbtt0UDn4zimfu4TLezydyoHmBg4XlOfdfPL2AYSFoytRs qFjp5KINJZQnZopUR01Gk8JxRzazLGND5mg3D/5rVYm935qdR4RM9yIB10VlbH3roATF PgmuV2luEfepX4wkvMlCi8+OLhihH2e56E7wa1bV5ZKzS7+8h3lQc37me1qIE7vCOa4M IRZz+VIPH4RdKiKG8zLPqHBrL2JPPmFlFpXjCsmDi3XptL6aMJZA+tI1og8rmgetYbY0 jh6JjtTULBjjgbrLl4KwZlUetR+0rBDVylfvxmBNqywQ7RG3S+xnnZl/1utWdhtr+Gcv sMCg== X-Forwarded-Encrypted: i=1; AHgh+RrWQa5zmgiRMU6lUvLQK0AakzRSZj0cZ6G6CeW7uGxktA5LdW9N4hBYaIRIxPFOs8Mla0Bj4CeZ0pK5gN0=@vger.kernel.org X-Gm-Message-State: AOJu0YwHkV2zooSAldcL+2YmeTemPML0KKRIf3DxDaf1pQR3cvQ/j8UJ nbD/4gjRZPoDM78noJlQXsmDMqwVUirONUYJcDaEYWxeE+ohM1vRGlHd X-Gm-Gg: AfdE7cktLrVwlQN8JFJIqAfgj5Xay78p2tFVAgHPB/sI+0JrtE//HDSn8ZXetlfE7vW fupc2l7ut6o8EIp0jSJrf1uDxThdrqxXp1moFyrm0A7Kh/BR5lCj+E/ufy6KRML0VYza9/1/T8f 0tx7LHYFSssz4jB8s0w4dyWRZ4IrCBJcy8XsaEm04crXwRimb63GHY5+vcjkHScG8oh4PYIUoya d5DskoJ5O48fnhwTU8CGRRiS29TZVegVRhzkI+XbEaL8uwnIupwD22UvpdAd22pOYHlAwnrvQE5 g7z0U09iFbZZFx4rz9oBGr/PdlVKZbaGUoQ6Bcp4l+IuSGH1DfQ4r7VwDagA3Jx5tCkZHIoQNKb PajoNGXclNrd61C5AarfHz38jKwIuJrQ8v3TWbsD0wlNUkjL+GxRRmi7yhP55ceoRda00VA6UVN 9a0qZK5zIWc0FaUr0= X-Received: by 2002:a05:600c:a00d:b0:493:a96b:fa0b with SMTP id 5b1f17b1804b1-493e68beea6mr80777025e9.24.1783613295994; Thu, 09 Jul 2026 09:08:15 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960b06sm51644492f8f.28.2026.07.09.09.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:08:15 -0700 (PDT) Date: Thu, 9 Jul 2026 17:09:20 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Guenter Roeck Cc: Fred Chen , "Torreno, Alexis Czezar" , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Jonathan Cameron , Wensheng Wang , Frank Li , Brian Chiang , Cosmo Chou , Dixit Parmar , Eddie James , Antoni Pokusinski , Thorsten Blum , Ashish Yadav , Syed Arif , ChiShih Tsai , Abdurrahman Hussain , "Paller, Kim Seer" , Colin Huang , Yuxi Wang , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 2/2] hwmon: (pmbus) Add driver for Analog Devices MAX20912 and MAX20916 Message-ID: References: <20260707122701.751878-3-fredchen.openbmc@gmail.com> <20260708-true-carp-of-champagne-a0dcca@quoll> <5b865eed-ae58-47fc-8d80-e14a76a93050@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b865eed-ae58-47fc-8d80-e14a76a93050@roeck-us.net> On Thu, Jul 09, 2026 at 08:54:09AM -0700, Guenter Roeck wrote: > On Thu, Jul 09, 2026 at 09:54:22AM +0100, Nuno Sá wrote: > > > > > > Based on the MAX20912/16 specs on my hand, these chips do not support > > > PMBUS_PHASE (0x04). Furthermore, the spec only indicates support for VID mode > > > and does not provide m/b/r. Therefore, some of the features you mentioned might > > > be specific to the MAX20826 series. > > > > I see, phases are not supported using standard PMBUS. > > > > As mentioned in my other e-mail, it can still be supported by the driver. > That is what the chip drivers are for, after all. > > > > > > > Regarding enabling VOUT via GPIO, our platform handles this via the CPLD as > > > part of the hardware power sequencing. Managing this pin through the driver is > > > not a requirement for our system. > > > > But we cannot assume all systems will behave like the above. But now i > > do wonder about controlling the GPIOs in the driver. In your system you > > clearly did not need to do it. In mine (testing with a rpi) I had to > > use a GPIO (well I could have used hogs or pinctrl). But if you control the pin > > you do gain the ability to turn off the regulator. If you don't it's always on > > (which might be indeed the bulk of the real usecases for these systems). > > > Agreed. I don't really like it, but if the chip and some specific hardware > mandate it, it should be supported. However, that code also needs to be > tested - an untested implementation would be worse than no implementation. That's how I tested it :). So from what I understand the preferred way is to support these pins as optional? If they are not there we just assume the pins are always enabled by some other means? In contrast to what I have today which makes these pins mandatory! > > Note to anyone from Analog listening: It is really unfortunate that I, > as subsystem maintainer, do not have access to datasheets. That means I have > to rely on assumptions and can not really provide actionable feedback other > than guesswork based on the PMBus standard. That feedback may and likely > will miss essential details. I cannot make any promises but can at least raise this internally. - Nuno Sá