From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F6D449983 for ; Thu, 9 Jul 2026 18:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783623050; cv=none; b=SQ+puqLDCHa5SWmUh6ak9B30krtPItKuYImjS4SoYMmzYti0GJv4q/ujjXhd4tSYXYZ5/4zcGAyUUYv7KzjHjvsRiY+JBvGnNbjDv0QgLkCWY7KxlVZTXGolwtTb0w7jo+LJT/kYLufp3h761gQTzNdtyaozitq+aUvKDEDOX3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783623050; c=relaxed/simple; bh=1bAtBPGgK8NHVISEj+GO0iePzHotuB8GIB2HKxOWIDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QE39N/bCxwf12+Z4WbxzdwAo8KI4iN6TLPk9sAE7tdooSMgXJkwIcP47AyGZkhliwc8DCkJMjYaoU7BGw+Y+d4px68Zv/0SYcCb16J7IdJHrSJ+vp75cUuvLMjhXG5lLv/HI8ptQelSZl/qZkqMFmm7fXgb45dskx0Ha7h4Na9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YiODXUm/; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YiODXUm/" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-6a3776acb16so139006eaf.2 for ; Thu, 09 Jul 2026 11:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783623048; x=1784227848; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ZRHeCwFsmKFBk4M/1QJH4iLci+OyPvksYnhoTo8Soao=; b=YiODXUm/RdqUk8QyL6bv8yqEjaZGXYX+bei7y0JwDGtdi23iAw/sPyrx23WKB55fe6 s/owIYx7kf3YTrP3bUBRoKlzULz+q12IVh329z7E2jTmSg1Ts2WIez9qsLo6JyMoA148 kUKtYjMJ9p5icg3gQ+6zluvJgtOrAkZH0jPKfUtyvGevIg7SQorHl/i0fENUg1P3JtGa KCVp5jI8UIWINWkcq8TbY77WQhxiXCCrg3hKNnfm7NvXt3ngJ76GmOT/tIgkUisWoeYM B7hZO03BDKlz5i2M3WCttCa8bCVXVlIL2Y1k0bzuil5/XAFvaJp/dm/rj7FMvk/SuQMe qRoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783623048; x=1784227848; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZRHeCwFsmKFBk4M/1QJH4iLci+OyPvksYnhoTo8Soao=; b=PBimT37Ca/lW6OS9H1GfpvlKqmFqQ3sV7IZMrAnOC71hXblRd2EU15kSExi2kZ/SPF tQJZDmpOMuuiUpxcy783Hh0vftgAEtQXE+w8UiJMEoMWd+tBe5yd25QWmUSFnIzPtWR0 3tWH2wniF70PAqe1qvrCdu+DArtqCmpcY6HXtpMJ+KpECkNYUFJoUtqGHnsp2rgVhN9T PCnwKvVn3t5paFHPo+F61Okn27d0grm5Wk/D8E04N1H1oRemTKP2bj7i+0rA0RVVKjkx 5tSZcSYH/gfufZXVC0TdkEqJJnRBi0Ua6P99fw4RZGSAArlMi51KzOD2t/vmoLcSfEEm X8ww== X-Forwarded-Encrypted: i=1; AFNElJ/WnQQ0SX57/6dEKYbmbxdHQntHFEEHamuvV6wcJ5A2tJZ+o2u6vwNySGvrQH+cSFIFX8JKurhFFQ9R0AA=@vger.kernel.org X-Gm-Message-State: AOJu0YxC5I7GkNBTyKXMEJmIIhJL4ZYbpAp1am9h6OCOWrGDhOIcx7xd E3MLXgkTHJMlwRO1R0o4JSLtcvnW0qV09nuMLrh/72owh0H7o9AVxwD9 X-Gm-Gg: AfdE7cltFs87l9m2qsmle37tzlCoCSzaKu7lfAyzBGgw2aWYt6kz0n/i1NOvf0pGTfT SCLVCuEW3E+7ZExMZ6S6Ygolg5NBZLMWjEtU9943xqnE14wJgkmNnrPAIT8OdgRv+3rCmt2ksMe j+N5Fm0EY1HsJZFqOdtOJMv5RQATZvp450hEqL8fLRpbravO8an67gQB8nMJi9bwGxob1MXxNIl 6IPCkd2/8K9u54FoAejGkHhMQwuxhewchq3uzjoV66l+9cklx46bQcdom674Yd802e1r+yC+tWi +m11eaEV4OpJJ2lDuwsMXm+vMPwB/7u0l4qyfCo6jJ9bNJAdtHJ8CmA8BeCH3vdHC3ixg7WSrSD GAlyiWXSodHJ28eT5N8jvsOW+7vA+KX0SGPkJp7qiA2FhF+aRDPTwNrejD2RgtUtDJikrkkLH3Q faakbZWRU= X-Received: by 2002:a05:6820:82c:b0:6a3:8023:f344 with SMTP id 006d021491bc7-6a38023f40bmr2648403eaf.2.1783623048208; Thu, 09 Jul 2026 11:50:48 -0700 (PDT) Received: from localhost ([45.136.154.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a377bd9cb1sm2973603eaf.15.2026.07.09.11.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 11:50:47 -0700 (PDT) Date: Thu, 9 Jul 2026 21:50:40 +0300 From: Dan Carpenter To: Hao-Qun Huang Cc: Greg Kroah-Hartman , Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: hid: fix SET_REPORT return value Message-ID: References: <20260704081613.434445-1-alvinhuang0603@gmail.com> <20260710020644.6728.alvinhuang0603@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710020644.6728.alvinhuang0603@gmail.com> On Fri, Jul 10, 2026 at 02:06:44AM +0800, Hao-Qun Huang wrote: > On Jul 9, 2026 at 6:52 PM, Dan Carpenter wrote: > > These kinds of changes require testing. How have you tested this > > change? > > I compile-tested it (W=1, building gb-hid, greybus and hid together) and > traced the return path by hand. I don't have Greybus HID hardware and > couldn't find a working emulator (gbsim has been dead since Ara), so I > haven't run it on a live device. > > The bug is that gb_hid_set_report() returns -errno on failure and len on > success, and __gb_hid_output_raw_report() computes that into ret (even > adding one back for the report ID byte) and then returns 0, discarding > it. So a successful hidraw write reports 0 bytes written and a failed > SET_REPORT looks like success. The GET path next to it already returns > the count, as do usbhid, i2c-hid and uhid, so callers already handle a > positive return and greybus HID was the only one returning 0. The bug is not hard to understand, the issue is that this changes the function completely... Was nothing checking the return before? regards, dan carpenter