The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Pranjal Shrivastava <praan@google.com>,
	Mostafa Saleh <smostafa@google.com>, <will@kernel.org>,
	<robin.murphy@arm.com>, <joro@8bytes.org>, <kees@kernel.org>,
	<baolu.lu@linux.intel.com>, <kevin.tian@intel.com>,
	<miko.lenczewski@arm.com>, <linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>, <jamien@nvidia.com>
Subject: Re: [PATCH rc v7 0/7] iommu/arm-smmu-v3: Fix device crash on kdump kernel
Date: Thu, 2 Jul 2026 12:25:43 -0700	[thread overview]
Message-ID: <aka7N6oLVq3CoBqn@nvidia.com> (raw)
In-Reply-To: <20260702144157.GM7481@nvidia.com>

On Thu, Jul 02, 2026 at 11:41:57AM -0300, Jason Gunthorpe wrote:
> On Wed, Jul 01, 2026 at 01:36:29PM +0000, Pranjal Shrivastava wrote:
> 
> > However, I agree with the overall problem, i.e. IF an active device
> > unmaps the DMA addr after the transaction in the previous kernel, 
> > (with the SMMU powered ON) but the TLBI was missed due to a crash/panic,
> > Any new DMA in the new kernel may alias onto a memory in the previous 
> > (crashed) kernel, not the kdump kernel.
> 
> It looks like there is an issue in this series, it isn't doing
> anything with the VMIDs.
> 
> The VMIDs that are in-used by the adopted stream table have to be
> removed from the idr as well (and similarly for ASID if we don't have
> VMID HW support).
> 
> Then the VMIDs that may be dirtied by the prior kernel remain isolated
> and are never re-used by the new kernel. When the new kernel wants to
> do DMA it will replace the STE with a new, clean VMID, and there is no
> problem.

I see. I assume the reserved VMID for the kdump kernel will be a
clean VMID (!=0). That should guarantee different cache tags.

But, do we have to scan CDs for ASID? I wonder if we could limit
to ARM_SMMU_FEAT_TRANS_S2 only, as this series does not memremap
CDs at all..

Nicolin

  reply	other threads:[~2026-07-02 19:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  6:15 [PATCH rc v7 0/7] iommu/arm-smmu-v3: Fix device crash on kdump kernel Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 1/7] iommu/arm-smmu-v3: Add arm_smmu_kdump_adopt_strtab() for kdump Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 2/7] iommu/arm-smmu-v3: Implement is_attach_deferred() " Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 3/7] iommu/arm-smmu-v3: Do not enable EVTQ/PRIQ interrupts in kdump kernel Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 4/7] iommu/arm-smmu-v3: Skip EVTQ/PRIQ setup " Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 5/7] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 6/7] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption Nicolin Chen
2026-06-30  6:15 ` [PATCH rc v7 7/7] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP_ADOPT in probe() Nicolin Chen
2026-06-30 13:17 ` [PATCH rc v7 0/7] iommu/arm-smmu-v3: Fix device crash on kdump kernel Mostafa Saleh
2026-06-30 14:51   ` Pranjal Shrivastava
2026-06-30 15:33     ` Mostafa Saleh
2026-06-30 18:30       ` Pranjal Shrivastava
2026-06-30 19:08         ` Jason Gunthorpe
2026-06-30 19:24           ` Nicolin Chen
2026-07-01  0:25             ` Jason Gunthorpe
2026-06-30 18:59       ` Jason Gunthorpe
2026-07-01 13:05         ` Mostafa Saleh
2026-07-01 13:36           ` Pranjal Shrivastava
2026-07-02 14:41             ` Jason Gunthorpe
2026-07-02 19:25               ` Nicolin Chen [this message]
2026-07-02 23:50                 ` Jason Gunthorpe
2026-07-03  3:32                   ` Nicolin Chen
2026-07-03 11:57                     ` Jason Gunthorpe
2026-06-30 18:56   ` Jason Gunthorpe
2026-06-30 19:27   ` Nicolin Chen
2026-07-01  9:58     ` Mostafa Saleh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aka7N6oLVq3CoBqn@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jamien@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kees@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miko.lenczewski@arm.com \
    --cc=praan@google.com \
    --cc=robin.murphy@arm.com \
    --cc=smostafa@google.com \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox