From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B028367F40 for ; Thu, 2 Jul 2026 19:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020679; cv=none; b=dsitXfvXd+AngJZ/EUhVJU/gv1Z8cTQdLjqnEsP/HK+j7kayb405XHDkYYpF4gBpUtEzjvjDE/ODaBp1jzb2Xdi5CoNeBG9CxbwT9wHVSiBRRCloFqiB44m0priHj34ODZwDOS5QZVLjUypMmTZBYaa0AKSc8aDnWmaIMaYZ6t4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020679; c=relaxed/simple; bh=mVlwxbaTIXTFcWUPnTkQZM+YyeoNCPkbEme+G5x0FLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=go3b9uB5Sz6YczLJTUbbIAp3Nb3G2PKDYwRAz6U1F2BqjAYY29SuJjdMl7puNSY5UcUUgXeaGh73DADbApjrlmrTjRjqO3GqEsqgLx6ogYYQbPPwvuZDB3I3O+KtUMCbzaOxauzUTnZNiTwzUcfg+urOO+t3gGFW/35tY6+odeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ser2G7/g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ser2G7/g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0008D1F000E9; Thu, 2 Jul 2026 19:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783020678; bh=YqgqhnLGnVEDfWjNjM0BXN2S8815yYGAUBSzi9h+WUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Ser2G7/gyDTtPclUiqGqOPKsh2tfck2pPmsUN1wlniesfdGw3/hRPW4tbqharLuV6 O8a0ACdZe5VW5cH1DG0i4s5q5wLoUgXxmWf/cWOR1zu6868nJYXXqt3b6c+UirCti3 nm/odCPm5+XUD0TekX/6Gze+G228ED+0hL4aXlC55YHfpZTYQHo4kjeMUVrxxuZOrV W/2K/4FX3VUHhWskVe7e7eXAy8/WTtxKJWCIf/6HhsLm1BSxGi/ijigNB+6S/7FnNy KRMSXxj1OQxd8FiZfCe+l+6gLgBL1+v9vGsIHJHSLXk7ISqbbozINRxBvBHg1I7lBf xpcwEzEzHDGfw== Date: Thu, 2 Jul 2026 22:31:11 +0300 From: Mike Rapoport To: Borislav Petkov Cc: Pratyush Yadav , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Pasha Tatashin , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH] x86/setup: do not include kexec_handover.h from asm/setup.h Message-ID: References: <20260701151536.3068791-1-pratyush@kernel.org> <20260701165714.GAakVG6p191JTJ0nJS@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701165714.GAakVG6p191JTJ0nJS@fat_crate.local> On Wed, Jul 01, 2026 at 09:57:14AM -0700, Borislav Petkov wrote: > On Wed, Jul 01, 2026 at 05:15:33PM +0200, Pratyush Yadav wrote: > > From: "Pratyush Yadav (Google)" > > > > x86 asm/setup.h includes linux/kexec_handover.h. This is because it is > > used by setup.c and kaslr.c. But this inclusion is problematic. The > > header is included in many places, so it results in the KHO header being > > propagated there. Also, the setup header is used by realmode code. If > > KHO header includes things like mm.h, it causes a big dump of > > compliation failures. > > This is exactly why we are trying hard to block people from using more linux/ > namespace headers in the decompressor code. Please split it and put only the > bits that are needed by the decompressor into a header in > arch/x86/include/asm/shared/ and use that in the decompressor. > > There are examples there. The examples there are really x86 specific. KHO needs decompressor to recognise 'struct kho_scratch' that's defined in include/linux/kexec_handover.h I see there's a duplicated 'struct efi_unaccepted_memory' for decompressor needs, should KHO do the same for 'struct kho_scratch'? -- Sincerely yours, Mike.