From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85243403EF; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009908; cv=none; b=Tw9UHvblnmKDlVkQSgvA1G9Npto2hqIq55J7z5RXqd9lGRYRw7ZfKxkqWteN/l2kYuphsVfz/2J1ke31XtkXmKg8c4fj9iQU8hg91r9iVlqYviuTsPCqsvV2aN7irhhQ2gMVwSnTDIzrlX7C5L96J2HzEbk5ZQX/GbWhVCii7Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009908; c=relaxed/simple; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=srWY49Ny5fAH76APObP7+PdbvAMYyjdhJ0zitLwHa3jVuM+OwMSwk8wwCjftXnnVA/8lL7/aMS5mlfLIwojmXrgBMKqJADZPm9awc3su/KEqVPQhGf6zyeMBfAq9G1Aqo20zhhyozag9zcnk2RMXFzMu/725HIs7/Vksr8nZQ8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTJm75v6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTJm75v6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5261F00A3A; Thu, 2 Jul 2026 16:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783009907; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FTJm75v6g78dw7nc2yIjeNrtd/XXU46WO/2u8nnziEKlJYchAWQ9hGEChgT4F31ah HiH5xTUbuFOhBbd6C1duQ+RhK7b4oHictxqHPOAi/lrzXWZ0FTN2EDGOuyFEWt0mD1 vjw0IUs1vrHYSMCjr+3zzHxShdi1SoTmUIrBx0H0nw1oUHkfV6THw+nOZBnbM1ksv+ +IgzClZgoCati852KoF+eqgYzFxCjgh+OL3JRZibavJHQwCUYoiGfhSnInQcjeQExX M1Tr3eyxRp2MXQhzrXdgxW+NoNc9BMVcJx67MLhqeaR6Vs6Z2WBP6mhtT0mJnysYek vPOd4U2WlHy2g== Date: Thu, 2 Jul 2026 17:31:24 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Message-ID: References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> On Fri, Jul 03, 2026 at 12:17:29AM +0800, Lance Yang wrote: > > > On 2026/7/3 00:07, Lorenzo Stoakes wrote: > > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: > > > > > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: > > > > Replace use of the legacy vm_flags_t flags with vma_flags_t values > > > > throughout the mremap logic. > > > > > > > > Additionally update comments to reflect the changes to be consistent. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > --- > > > > > > The vm_flags_set() cases below spell out vma_start_write(), but the > > > vm_flags_clear() cases don't? > > > > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing > > this is completely on purpose to get rid of that :) > > > > But I haven't been clear enough clearly, so I should put the argument as to why > > that's ok in the commit message. > > > > Will do so on respin. > > Makes sense, thanks for spelling it out! A short changelog note > should clear it up for me :D Yeah absolutely, that's necessary and was an oversight on my part, will correct! Thanks for your great review here, much appreciated! :) > > [...] Cheers, Lorenzo